fix(use-dataloader): ignore some eslint v8 errors (#513)

Author: chambo-e

packages/use-dataloader/src/DataLoaderProvider.tsx

@@ -186,6 +186,8 @@ const DataLoaderProvider = ({
       setTimeout(() => {
         Object.keys(requestsRef.current).forEach(key => {
           if (requestsRef.current[key].getObserversCount() === 0) {
+            // Worst case there is a memleak
+            // eslint-disable-next-line @typescript-eslint/no-floating-promises
             requestsRef.current[key].destroy()
             delete requestsRef.current[key]
           }

packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx

@@ -52,6 +52,8 @@ describe('DataLoaderProvider', () => {
     expect(testRequest).toBeDefined()
     expect(testRequest?.status).toBe(StatusEnum.IDLE)
     act(() => {
+      // launch should never throw
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       testRequest?.launch()
     })
     expect(method).toBeCalledTimes(1)
@@ -88,6 +90,8 @@ describe('DataLoaderProvider', () => {
     expect(testRequest).toBeDefined()
     expect(testRequest?.status).toBe(StatusEnum.IDLE)
     act(() => {
+      // launch should never throw
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       testRequest?.launch()
     })
     expect(method).toBeCalledTimes(1)

packages/use-dataloader/src/__tests__/dataloader.test.ts

@@ -33,7 +33,7 @@ describe('Dataloader class', () => {
     expect(method).toBeCalledTimes(0)
     await instance.load()
     expect(method).toBeCalledTimes(1)
-    instance.destroy()
+    await instance.destroy()
     instance.clearData()
   })
 
@@ -207,7 +207,7 @@ describe('Dataloader class', () => {
     await new Promise(resolve => { setTimeout(resolve) })
     expect(method).toBeCalledTimes(6)
     instance.setPollingInterval(PROMISE_TIMEOUT * 4)
-    instance.destroy()
+    await instance.destroy()
   })
 
   test('should update outdated data', async () => {

packages/use-dataloader/src/dataloader.ts

@@ -216,8 +216,8 @@ class DataLoader<T = unknown> {
     this.notifyChanges()
   }
 
-  public destroy(): void {
-    this.cancel?.()
+  public async destroy(): Promise<void> {
+    await this.cancel?.()
     if (this.timeout) {
       clearTimeout(this.timeout)
     }

packages/use-dataloader/src/useDataLoader.ts

@@ -106,6 +106,8 @@ const useDataLoader = <T>(
 
   useEffect(() => {
     if (enabled && isIdle) {
+      // launch should never throw
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       request.launch?.()
     }
   }, [request, enabled, isIdle])