Skip to content

Commit ac4d14c

Browse files
committed
fix(eslint): confict rules
Signed-off-by: Alexandre Philibeaux <[email protected]>
1 parent 162f0ab commit ac4d14c

File tree

5 files changed

+100
-10
lines changed

5 files changed

+100
-10
lines changed

.changeset/strange-pears-tell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@scaleway/eslint-config-react": minor
3+
---
4+
5+
fix conflict rules apply by formatter like prettier / biome

packages/eslint-config-react/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"@typescript-eslint/parser": "8.16.0",
4343
"eslint-config-airbnb": "19.0.4",
4444
"eslint-config-prettier": "9.1.0",
45+
"eslint-import-resolver-typescript": "3.7.0",
4546
"eslint-plugin-deprecation": "3.0.0",
4647
"eslint-plugin-eslint-comments": "3.2.0",
4748
"eslint-plugin-import": "2.31.0",

packages/eslint-config-react/stylistic.mjs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const config = compat.extends('airbnb-base')
1515

1616
const defaultAirBnbRules = [...fixupPluginRules(config)].reduce(
1717
(acc, currentConfig) => ({
18+
// biome-ignore lint/performance/noAccumulatingSpread: <explanation>
1819
...acc,
1920
...currentConfig.rules,
2021
}),
@@ -31,12 +32,16 @@ export default [
3132
stylisticPlugin.configs['recommended-flat'],
3233
{
3334
rules: {
35+
// --- Should be done when using biome/prettier formatter --- //
3436
'@stylistic/quotes': 'off',
3537
'@stylistic/operator-linebreak': 'off',
3638
'@stylistic/indent': 'off',
3739
'@stylistic/quote-props': 'off',
3840
'@stylistic/indent-binary-ops': 'off',
3941
'@stylistic/arrow-parens': 'off',
42+
'@stylistic/multiline-ternary': 'off',
43+
'@stylistic/no-trailing-spaces': 'off',
44+
// -------------------------------------- ///
4045

4146
'@stylistic/brace-style': defaultAirBnbRules['brace-style'],
4247
'@stylistic/comma-dangle': [

packages/eslint-config-react/typescript.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export default [
1919
'airbnb-base',
2020
'plugin:@typescript-eslint/recommended',
2121
'plugin:@typescript-eslint/recommended-requiring-type-checking',
22+
'plugin:import/typescript',
2223
),
2324
),
2425
...airbnbTypescript,

pnpm-lock.yaml

Lines changed: 88 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)