fix(analytics): remove essentials destinations (#2677)

Signed-off-by: protobuf-ci-cd <[email protected]>

Author: philibea

.changeset/eleven-cloths-wish.md

@@ -0,0 +1,5 @@
+---
+"@scaleway/use-analytics": patch
+---
+
+fix useless props: essentialDestinations, better typing

packages/use-analytics/src/analytics/constants.ts

@@ -52,6 +52,7 @@ export const defaultLoadOptions: LoadOptions = {
   anonymousIdOptions: {
     autoCapture: {
       enabled: true,
+      source: 'segment',
     },
   },
   sessions: {

packages/use-analytics/src/analytics/useAnalytics.tsx

@@ -18,7 +18,7 @@ export type { Analytics }
 
 export type OnEventError = (error: Error) => Promise<void> | void
 
-type EventFunction = (...args: never[]) => Promise<void>
+type EventFunction = (...args: never[]) => Promise<void> | void
 type Events = Record<
   string,
   (analytics?: Analytics, onEventError?: OnEventError) => EventFunction

packages/use-analytics/src/cookies-consent/CookieConsentProvider.tsx

@@ -22,13 +22,7 @@ import { uniq } from '../helpers/array'
 import { IS_CLIENT } from '../helpers/isClient'
 import { stringToHash } from '../helpers/misc'
 import { isCategoryKind } from '../types'
-import type {
-  Config,
-  Consent,
-  Destination,
-  Destinations,
-  EssentialDestination,
-} from '../types'
+import type { Config, Consent, Destination, Destinations } from '../types'
 
 type Context = {
   destinations: Destinations
@@ -55,7 +49,6 @@ export const useCookieConsent = (): Context => {
 export const CookieConsentProvider = ({
   children,
   isConsentRequired,
-  essentialDestinations,
   manualDestinations,
   config,
   cookiePrefix = COOKIE_PREFIX,
@@ -64,7 +57,6 @@ export const CookieConsentProvider = ({
   cookiesOptions = COOKIES_OPTIONS,
 }: PropsWithChildren<{
   isConsentRequired: boolean
-  essentialDestinations: EssentialDestination[]
   manualDestinations?: Destinations
   config: Config
   cookiePrefix?: string
@@ -93,17 +85,9 @@ export const CookieConsentProvider = ({
               category: dest.consents[0] ?? 'essential',
             }) satisfies Destination,
         ),
-        ...essentialDestinations.map(
-          dest =>
-            ({
-              name: dest.name,
-              displayName: dest.displayName,
-              category: 'essential',
-            }) satisfies Destination,
-        ),
         ...(manualDestinations ?? []),
       ]),
-    [analyticsDestinations, essentialDestinations, manualDestinations],
+    [analyticsDestinations, manualDestinations],
   )
 
   // We compute a hash with all the integrations that are enabled

packages/use-analytics/src/index.ts

@@ -1,4 +1,9 @@
-export { AnalyticsProvider, useAnalytics, useDestinations } from './analytics'
+export {
+  AnalyticsProvider,
+  useAnalytics,
+  useDestinations,
+  userMigrationsTraits,
+} from './analytics'
 export {
   defaultLoadOptions,
   defaultConsentOptions,
@@ -11,7 +16,6 @@ export type {
 } from './analytics/useAnalytics'
 export type {
   AnalyticsIntegration,
-  EssentialDestination,
   Destination,
   CategoryKind,
   Consents,

packages/use-analytics/src/types.ts

@@ -61,7 +61,6 @@ export type Destination = {
   name: string
   displayName: string
 }
-export type EssentialDestination = Pick<Destination, 'displayName' | 'name'>
 
 export type Destinations = Destination[]