Skip to content

Commit bb5a796

Browse files
authored
feat(eslint): disabled usage of export * (#1080)
* feat(eslint): disabled usage of export * * fix(export): correct type export
1 parent 0b0cbd3 commit bb5a796

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

packages/eslint-config-react/shared.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ module.exports = {
4747
'`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
4848
selector: 'WithStatement',
4949
},
50+
{
51+
message: '`export *` is forbidden.',
52+
selector: 'ExportAllDeclaration',
53+
},
5054
],
5155
// This is to have a more breathable codebase
5256
'padding-line-between-statements': [

packages/use-i18n/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import I18nContextProvider from './usei18n'
22

3-
export * from './usei18n'
4-
export * from './types'
3+
export { useI18n, useTranslation } from './usei18n'
4+
export type { TranslateFn, ScopedTranslateFn, ReactParamsObject } from './types'
55

66
export default I18nContextProvider

packages/use-segment/src/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
import SegmentProvider from './useSegment'
22

3-
export * from './useSegment'
3+
export { useSegment } from './useSegment'
4+
export type {
5+
Analytics,
6+
OnEventError,
7+
SegmentProviderProps,
8+
} from './useSegment'
49

510
export default SegmentProvider

packages/use-segment/src/useSegment.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export type SegmentProviderProps<T> = {
4949
children: ReactNode
5050
}
5151

52-
export { Analytics }
52+
export type { Analytics }
5353

5454
function SegmentProvider<T extends Events>({
5555
children,

0 commit comments

Comments
 (0)