Skip to content

Commit e8aecf6

Browse files
authored
fix: correct some eslint errors (#490)
1 parent 12b1bdd commit e8aecf6

File tree

5 files changed

+30
-27
lines changed

5 files changed

+30
-27
lines changed

packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import { KEY_IS_NOT_STRING_ERROR, StatusEnum } from '../constants'
77
const TEST_KEY = 'test'
88
const PROMISE_TIMEOUT = 5
99
const fakePromise = () =>
10-
new Promise(resolve => setTimeout(() => resolve(true), PROMISE_TIMEOUT))
10+
new Promise(resolve => { setTimeout(() => resolve(true), PROMISE_TIMEOUT) })
1111

1212
const fakeNullPromise = () =>
13-
new Promise(resolve => setTimeout(() => resolve(null), PROMISE_TIMEOUT))
13+
new Promise(resolve => { setTimeout(() => resolve(null), PROMISE_TIMEOUT) })
1414

1515
const wrapper = ({ children }: { children: ReactNode }) => (
1616
<DataLoaderProvider>{children}</DataLoaderProvider>
@@ -180,7 +180,7 @@ describe('DataLoaderProvider', () => {
180180

181181
test('should delay max concurrent request', async () => {
182182
const method = jest.fn(
183-
() => new Promise(resolve => setTimeout(() => resolve(true), 100)),
183+
() => new Promise(resolve => { setTimeout(() => resolve(true), 100) }),
184184
)
185185
const { result, waitFor } = renderHook(useDataLoaderContext, {
186186
wrapper: wrapperWith2ConcurrentRequests,

packages/use-dataloader/src/__tests__/dataloader.test.ts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ describe('Dataloader class', () => {
5151
expect(notify).toBeCalledTimes(0)
5252
expect(method).toBeCalledTimes(1)
5353
await instance.cancel()
54-
await new Promise(resolve =>
54+
await new Promise(resolve => {
5555
setTimeout(() => {
5656
expect(notify).toBeCalledTimes(1)
5757
resolve(true)
58-
}, PROMISE_TIMEOUT),
59-
)
58+
}, PROMISE_TIMEOUT)
59+
})
6060
expect(instance.getData()).toBe(undefined)
6161
instance.clearData()
6262
})
@@ -73,12 +73,12 @@ describe('Dataloader class', () => {
7373
expect(instance.status).toBe(StatusEnum.LOADING)
7474
expect(notify).toBeCalledTimes(0)
7575
expect(method).toBeCalledTimes(1)
76-
await new Promise(resolve =>
76+
await new Promise(resolve => {
7777
setTimeout(() => {
7878
expect(notify).toBeCalledTimes(1)
7979
resolve(true)
80-
}, PROMISE_TIMEOUT),
81-
)
80+
}, PROMISE_TIMEOUT)
81+
})
8282
expect(instance.getData()).toBe(true)
8383
instance.getObserversCount()
8484
instance.removeObserver(notify)
@@ -95,11 +95,11 @@ describe('Dataloader class', () => {
9595
})
9696
expect(instance.status).toBe(StatusEnum.LOADING)
9797
expect(method).toBeCalledTimes(1)
98-
await new Promise(resolve =>
98+
await new Promise(resolve => {
9999
setTimeout(() => {
100100
resolve(true)
101-
}, PROMISE_TIMEOUT),
102-
)
101+
}, PROMISE_TIMEOUT)
102+
})
103103
expect(instance.getData()).toBe(undefined)
104104
})
105105
test('should create instance enabled with undefined data', async () => {
@@ -111,11 +111,11 @@ describe('Dataloader class', () => {
111111
})
112112
expect(instance.status).toBe(StatusEnum.LOADING)
113113
expect(method).toBeCalledTimes(1)
114-
await new Promise(resolve =>
114+
await new Promise(resolve => {
115115
setTimeout(() => {
116116
resolve(true)
117-
}, PROMISE_TIMEOUT),
118-
)
117+
}, PROMISE_TIMEOUT)
118+
})
119119
expect(instance.getData()).toBe(undefined)
120120
})
121121

@@ -193,18 +193,18 @@ describe('Dataloader class', () => {
193193
})
194194
await instance.load()
195195
expect(method).toBeCalledTimes(1)
196-
await new Promise(resolve => setTimeout(resolve, PROMISE_TIMEOUT * 3))
196+
await new Promise(resolve => { setTimeout(resolve, PROMISE_TIMEOUT * 3) })
197197
expect(method).toBeCalledTimes(2)
198-
await new Promise(resolve => setTimeout(resolve, PROMISE_TIMEOUT * 3))
198+
await new Promise(resolve => { setTimeout(resolve, PROMISE_TIMEOUT * 3) })
199199
expect(method).toBeCalledTimes(3)
200200
await instance.load()
201201
await instance.load()
202-
await new Promise(resolve => setTimeout(resolve))
202+
await new Promise(resolve => { setTimeout(resolve) })
203203
expect(method).toBeCalledTimes(4)
204204
await instance.load()
205205
await instance.load()
206206
await instance.load(true)
207-
await new Promise(resolve => setTimeout(resolve))
207+
await new Promise(resolve => { setTimeout(resolve) })
208208
expect(method).toBeCalledTimes(6)
209209
instance.setPollingInterval(PROMISE_TIMEOUT * 4)
210210
instance.destroy()
@@ -222,12 +222,12 @@ describe('Dataloader class', () => {
222222
instance.addOnSuccessListener(onSuccess)
223223
expect(instance.status).toBe(StatusEnum.LOADING)
224224
expect(method).toBeCalledTimes(1)
225-
await new Promise(resolve => setTimeout(resolve, PROMISE_TIMEOUT))
225+
await new Promise(resolve => { setTimeout(resolve, PROMISE_TIMEOUT) })
226226
expect(onSuccess).toBeCalledTimes(1)
227227
await instance.load()
228228
expect(method).toBeCalledTimes(1)
229229
expect(onSuccess).toBeCalledTimes(1)
230-
await new Promise(resolve => setTimeout(resolve, PROMISE_TIMEOUT * 2))
230+
await new Promise(resolve => { setTimeout(resolve, PROMISE_TIMEOUT * 2) })
231231
await instance.load()
232232
expect(method).toBeCalledTimes(2)
233233
expect(onSuccess).toBeCalledTimes(2)
@@ -245,7 +245,7 @@ describe('Dataloader class', () => {
245245
expect(instance.status).toBe(StatusEnum.LOADING)
246246
}
247247
// Because wait for setTimeout tryLaunch in dataloader.ts
248-
await new Promise(resolve => setTimeout(resolve))
248+
await new Promise(resolve => { setTimeout(resolve) })
249249
expect(method).toBeCalledTimes(2)
250250
})
251251
})

packages/use-dataloader/src/__tests__/useDataLoader.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ describe('useDataLoader', () => {
148148
...initialProps,
149149
key: 'test-3',
150150
method: () =>
151-
new Promise(resolve =>
152-
setTimeout(() => resolve(null), PROMISE_TIMEOUT),
153-
),
151+
new Promise(resolve => {
152+
setTimeout(() => resolve(null), PROMISE_TIMEOUT)
153+
})
154154
},
155155
wrapper,
156156
})

packages/use-i18n/src/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1-
export { default } from './usei18n'
1+
import usei18n from './usei18n'
2+
23
export * from './usei18n'
4+
5+
export default usei18n

packages/use-i18n/src/usei18n.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export const useI18n = (): Context => {
9393
return context
9494
}
9595

96-
export const useTranslation = (namespaces: string[] = [], load?: LoadTranslationsFn): Context & { isLoaded: boolean } => {
96+
export const useTranslation = (namespaces: string[] = [], load: LoadTranslationsFn | undefined = undefined): Context & { isLoaded: boolean } => {
9797
const context = useContext(I18nContext)
9898
if (context === undefined) {
9999
throw new Error('useTranslation must be used within a I18nProvider')

0 commit comments

Comments
 (0)