fix(core): nested logger transport when creating multiple clients (#1485)

Author: Codelax

scw/client.go

@@ -530,5 +530,11 @@ func setRequestLogging(c httpClient) {
 		logger.Warningf("client: cannot use request logger with HTTP client of type %T", c)
 		return
 	}
-	standardHTTPClient.Transport = &requestLoggerTransport{rt: standardHTTPClient.Transport}
+	// Do not wrap transport if it is already a logger
+	// As client is a pointer, changing transport will change given client
+	// If the same httpClient is used in multiple scwClient, it would add multiple logger transports
+	_, isLogger := standardHTTPClient.Transport.(*requestLoggerTransport)
+	if !isLogger {
+		standardHTTPClient.Transport = &requestLoggerTransport{rt: standardHTTPClient.Transport}
+	}
 }

scw/client_test.go

@@ -40,6 +40,27 @@ func TestNewClientWithNoAuth(t *testing.T) {
 	})
 }
 
+func TestNewClientMultipleClients(t *testing.T) {
+	t.Run("Basic", func(t *testing.T) {
+		logger.EnableDebugMode()
+		httpClient := &http.Client{}
+		_, err := NewClient(WithHTTPClient(httpClient))
+		testhelpers.AssertNoError(t, err)
+
+		_, isLogger := httpClient.Transport.(*requestLoggerTransport)
+		testhelpers.Assert(t, isLogger, "transport should be a request logger")
+
+		_, err = NewClient(WithHTTPClient(httpClient))
+		testhelpers.AssertNoError(t, err)
+
+		transport, isLogger := httpClient.Transport.(*requestLoggerTransport)
+		testhelpers.Assert(t, isLogger, "transport should be a request logger")
+		_, isLogger = transport.rt.(*requestLoggerTransport)
+		testhelpers.Assert(t, !isLogger, "nested transport should not be a request logger")
+
+	})
+}
+
 func TestNewClientWithDefaults(t *testing.T) {
 	options := []ClientOption{
 		WithInsecure(),