fix(cockpit): remove WaitForAlert and keep only WaitForPreconfiguredAlerts

Author: jremy42

api/cockpit/v1/cockpit_utils.go

@@ -13,60 +13,6 @@ const (
 	defaultTimeout       = 5 * time.Minute
 )
 
-// WaitForAlertRequest is used by WaitForAlert method.
-type WaitForAlertRequest struct {
-	Region        scw.Region
-	AlertID       string
-	Timeout       *time.Duration
-	RetryInterval *time.Duration
-}
-
-// WaitForAlert waits for the alert to be in a "terminal state" before returning.
-// This function can be used to wait for an alert to be enabled or disabled.
-func (s *RegionalAPI) WaitForAlert(req *WaitForAlertRequest, opts ...scw.RequestOption) (*Alert, error) {
-	timeout := defaultTimeout
-	if req.Timeout != nil {
-		timeout = *req.Timeout
-	}
-	retryInterval := defaultRetryInterval
-	if req.RetryInterval != nil {
-		retryInterval = *req.RetryInterval
-	}
-
-	terminalStatus := map[AlertStatus]struct{}{
-		AlertStatusEnabled:  {},
-		AlertStatusDisabled: {},
-	}
-
-	alert, err := async.WaitSync(&async.WaitSyncConfig{
-		Get: func() (any, bool, error) {
-			// List all alerts and find the one with matching ID
-			res, err := s.ListAlerts(&RegionalAPIListAlertsRequest{
-				Region: req.Region,
-			}, opts...)
-			if err != nil {
-				return nil, false, err
-			}
-
-			// Find the alert by ID
-			for _, alert := range res.Alerts {
-				if alert.ID == req.AlertID {
-					_, isTerminal := terminalStatus[alert.RuleStatus]
-					return alert, isTerminal, nil
-				}
-			}
-
-			return nil, false, errors.New("alert not found")
-		},
-		Timeout:          timeout,
-		IntervalStrategy: async.LinearIntervalStrategy(retryInterval),
-	})
-	if err != nil {
-		return nil, errors.Wrap(err, "waiting for alert failed")
-	}
-	return alert.(*Alert), nil
-}
-
 // WaitForPreconfiguredAlertsRequest is used by WaitForPreconfiguredAlerts method.
 type WaitForPreconfiguredAlertsRequest struct {
 	Region             scw.Region
@@ -159,4 +105,3 @@ func (s *RegionalAPI) WaitForPreconfiguredAlerts(req *WaitForPreconfiguredAlerts
 	}
 	return result.([]*Alert), nil
 }
-

api/cockpit/v1/sweepers/sweepers.go

@@ -57,6 +57,7 @@ func SweepGrafanaUser(scwClient *scw.Client) error {
 			continue
 		}
 
+		//nolint:staticcheck // Deprecated functions are still functional and needed for sweepers
 		listGrafanaUsers, err := cockpitAPI.ListGrafanaUsers(&cockpit.GlobalAPIListGrafanaUsersRequest{
 			ProjectID: project.ID,
 		}, scw.WithAllPages())
@@ -65,6 +66,7 @@ func SweepGrafanaUser(scwClient *scw.Client) error {
 		}
 
 		for _, grafanaUser := range listGrafanaUsers.GrafanaUsers {
+			//nolint:staticcheck // Deprecated functions are still functional and needed for sweepers
 			err = cockpitAPI.DeleteGrafanaUser(&cockpit.GlobalAPIDeleteGrafanaUserRequest{
 				ProjectID:     project.ID,
 				GrafanaUserID: grafanaUser.ID,