feat(marketplace): uppercase commercial type in GetLocalImageIDByLabel (#205)

Author: QuentinBrosse

api/marketplace/v1/marketplace_utils.go

@@ -68,6 +68,7 @@ func (s *API) GetLocalImageIDByLabel(req *GetLocalImageIDByLabelRequest) (string
 
 	images := listImageResponse.Images
 	label := strings.Replace(req.ImageLabel, "-", "_", -1)
+	commercialType := strings.ToUpper(req.CommercialType)
 
 	for _, image := range images {
 
@@ -79,7 +80,7 @@ func (s *API) GetLocalImageIDByLabel(req *GetLocalImageIDByLabelRequest) (string
 				return "", errors.Wrap(err, "couldn't find a matching image for the given label (%s), zone (%s) and commercial type (%s)", req.ImageLabel, req.Zone, req.CommercialType)
 			}
 
-			localImage, err := latestVersion.getLocalImage(req.Zone, req.CommercialType)
+			localImage, err := latestVersion.getLocalImage(req.Zone, commercialType)
 			if err != nil {
 				return "", errors.Wrap(err, "couldn't find a matching image for the given label (%s), zone (%s) and commercial type (%s)", req.ImageLabel, req.Zone, req.CommercialType)
 			}

api/marketplace/v1/marketplace_utils_test.go

@@ -33,6 +33,23 @@ func TestGetImageByLabel(t *testing.T) {
 
 	})
 
+	t.Run("matching input for GetLocalImageIDByLabel with lowercase image label", func(t *testing.T) {
+
+		// Create SDK objects for Scaleway Instance product
+		marketplaceAPI := NewAPI(client)
+
+		imageID, err := marketplaceAPI.GetLocalImageIDByLabel(&GetLocalImageIDByLabelRequest{
+			Zone:           scw.ZoneFrPar1,
+			CommercialType: "dev1-s",
+			ImageLabel:     "ubuntu-bionic",
+		})
+		testhelpers.AssertNoError(t, err)
+
+		// ubuntu-bionic DEV1-S at par1: f974feac-abae-4365-b988-8ec7d1cec10d
+		testhelpers.Equals(t, "f974feac-abae-4365-b988-8ec7d1cec10d", imageID)
+
+	})
+
 	t.Run("non-matching label for GetLocalImageIDByLabel", func(t *testing.T) {
 
 		// Create SDK objects for Scaleway Instance product