-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Labels
documentationinstanceInstance issues, bugs and feature requestsInstance issues, bugs and feature requestspriority:lowLow priority such as UX improvements and estheticsLow priority such as UX improvements and esthetics
Description
I was going to update the use of this SDK in Prometheus, but saw deprecation warnings and got confused. I've never seen a conditional deprecation:
// Deprecated: IPv6: instance IPv6 address (deprecated when `routed_ip_enabled` is `True`).
IPv6 *ServerIPv6 `json:"ipv6"`
I would argue that if the field is not removed eventually (i.e. kept for the case when router_ip_enabled is False) then this is no deprecation at all and the comment should just say , "always nil when routed_ip_enabled is True".
WDYT?
Metadata
Metadata
Assignees
Labels
documentationinstanceInstance issues, bugs and feature requestsInstance issues, bugs and feature requestspriority:lowLow priority such as UX improvements and estheticsLow priority such as UX improvements and esthetics