fix: resolve all non-breaking lint errors in handwritten code

Author: jremy42

biome.json

@@ -112,6 +112,58 @@
     }
   },
   "overrides": [
+    {
+      "includes": ["**/dist/**"],
+      "linter": {
+        "enabled": false
+      }
+    },
+    {
+      "includes": ["coverage/**"],
+      "linter": {
+        "enabled": false
+      }
+    },
+    {
+      "includes": ["**/vite.config.ts", "**/vitest.config.ts"],
+      "linter": {
+        "rules": {
+          "style": {
+            "noDefaultExport": "off"
+          }
+        }
+      }
+    },
+    {
+      "includes": ["packages/client/src/internal/logger/level-resolver.ts"],
+      "linter": {
+        "rules": {
+          "style": {
+            "useNamingConvention": "off"
+          }
+        }
+      }
+    },
+    {
+      "includes": ["scripts/**/*.ts"],
+      "linter": {
+        "rules": {
+          "style": {
+            "useNamingConvention": "off"
+          }
+        }
+      }
+    },
+    {
+      "includes": ["packages/sdk/src/index.gen.ts"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noShadowRestrictedNames": "off"
+          }
+        }
+      }
+    },
     {
       "includes": [
         "packages/client/src/internal/interceptors/types.ts"
@@ -131,6 +183,9 @@
         "rules": {
           "correctness": {
             "noUnusedVariables": "off"
+          },
+          "style": {
+            "useNamingConvention": "off"
           }
         }
       }

examples/nodejs-minimal/src/index.ts

@@ -3,7 +3,7 @@
 import { loadProfileFromConfigurationFile } from '@scaleway/configuration-loader'
 import { Registry } from '@scaleway/sdk'
 import { createClient } from '@scaleway/sdk-client'
-import * as http from 'http'
+import * as http from 'node:http'
 
 const hostname = '127.0.0.1'
 const port = 3000

examples/serverless-function-minimal/src/index.ts

@@ -18,7 +18,11 @@ const buildErrorRes = (error?: unknown) => ({
   statusCode: error instanceof Errors.ScalewayError ? error.status : 500,
 })
 
-export const list = async (event: any, context: any, callback: any) => {
+export const list = async (
+  _event: unknown,
+  _context: unknown,
+  _callback: unknown,
+) => {
   try {
     return buildJsonRes(await api.listNamespaces().all())
   } catch (error) {

package.json

@@ -26,7 +26,7 @@
     "format": "biome check --linter-enabled=false --write .",
     "format:check": "biome check --linter-enabled=false .",
     "prettier": "prettier --write '**/*.{md,mdx,yml,yaml}'",
-    "lint": "biome lint packages/*/src scripts/**/*.ts",
+    "lint": "biome lint .",
     "lint:fix": "biome check --write .",
     "prepare": "husky",
     "test": "vitest run",
@@ -35,17 +35,10 @@
     "test:ui": "vitest --ui"
   },
   "lint-staged": {
-    "globOptions": {
-      "ignore": [
-        "**/*.gen.ts",
-        "packages_generated/**",
-        "**/dist/**",
-        "**/build/**",
-        "**/coverage/**",
-        "**/examples/**"
-      ]
-    },
-    "*.{ts,tsx,js,jsx}": [
+    "packages/*/src/**/*.{ts,tsx,js,jsx}": [
+      "biome check --write --no-errors-on-unmatched --files-ignore-unknown=true"
+    ],
+    "scripts/**/*.ts": [
       "biome check --write --no-errors-on-unmatched --files-ignore-unknown=true"
     ],
     "*.json": [

packages/client/src/helpers/__tests__/json.test.ts

@@ -9,12 +9,15 @@ describe('isJSON', () => {
     },
   )
 
-  test.each([undefined, () => {}, Symbol(42)])(
-    `rejects %s as a valid JSON value`,
-    obj => {
-      expect(isJSON(obj)).toBeFalsy()
+  test.each([
+    undefined,
+    () => {
+      /* noop */
     },
-  )
+    Symbol(42),
+  ])(`rejects %s as a valid JSON value`, obj => {
+    expect(isJSON(obj)).toBeFalsy()
+  })
 })
 
 describe('isJSONObject', () => {
@@ -32,7 +35,9 @@ describe('isJSONObject', () => {
     null,
     [true, 'two', 3],
     undefined,
-    () => {},
+    () => {
+      /* noop */
+    },
     Symbol(42),
   ])(`rejects %s as a valid JSONObject value`, obj => {
     expect(isJSONObject(obj)).toBeFalsy()

packages/client/src/helpers/__tests__/marshalling.test.ts

@@ -94,6 +94,7 @@ describe('resolveOneOf', () => {
         [{ default: undefined, param: 'my_key', value: '42' }],
         true,
       ),
+      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key: '42' })
   })
 
@@ -106,6 +107,7 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
+      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_2: '42' })
   })
 
@@ -118,6 +120,7 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
+      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: '42' })
 
     expect(
@@ -128,6 +131,7 @@ describe('resolveOneOf', () => {
         ],
         true,
       ),
+      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: '42' })
   })
 
@@ -168,6 +172,7 @@ describe('resolveOneOf', () => {
         ],
         false,
       ),
+      /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
     ).toStrictEqual({ my_key_1: false })
   })
 })
@@ -201,6 +206,7 @@ describe('unmarshalArrayOfObject', () => {
   it('unmarshals valid array of object', () => {
     expect(
       unmarshalArrayOfObject(
+        /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
         [{ my_number: 42 }, { my_number: 94 }],
         unmarshaller,
       ),
@@ -229,6 +235,7 @@ describe('unmarshalMapOfObject', () => {
   it('unmarshals valid array of object', () => {
     expect(
       unmarshalMapOfObject(
+        /* biome-ignore lint/style/useNamingConvention: test data uses snake_case intentionally */
         { 'first-key': { my_number: 42 }, 'second-key': { my_number: 94 } },
         unmarshaller,
       ),

packages/client/src/helpers/json.ts

@@ -95,15 +95,14 @@ export const camelizeKeys = <T>(
   }
 
   if (obj && typeof obj === 'object' && !(obj instanceof Date)) {
-    return Object.entries(obj).reduce(
-      (acc, [key, value]) => ({
-        ...acc,
-        [camelize(key)]: ignoreKeys.includes(key)
-          ? (value as unknown)
-          : camelizeKeys(value, ignoreKeys),
-      }),
-      {},
-    ) as T
+    const result: Record<string, unknown> = {}
+    for (const [key, value] of Object.entries(obj)) {
+      const outKey = camelize(key)
+      result[outKey] = ignoreKeys.includes(key)
+        ? (value as unknown)
+        : camelizeKeys(value, ignoreKeys)
+    }
+    return result as T
   }
 
   return obj as T

packages/client/src/helpers/marshalling.ts

@@ -67,34 +67,30 @@ type URLParameterValue = string | number | boolean | Date | null
  *
  * @internal
  */
+const toParamString = (v: URLParameterValue): string | null => {
+  if (v === null) return null
+  if (v instanceof Date) return v.toISOString()
+  return v.toString()
+}
+
 export const urlParams = (
   ...paramTuples: Readonly<
     [string, URLParameterValue | URLParameterValue[] | undefined]
   >[]
 ) => {
   const params = new URLSearchParams()
   for (const [key, value] of paramTuples) {
-    if (typeof key === 'string' && value != null) {
-      if (Array.isArray(value)) {
-        for (const innerValue of value) {
-          if (innerValue !== null) {
-            params.append(
-              key,
-              innerValue instanceof Date
-                ? innerValue.toISOString()
-                : innerValue.toString(),
-            )
-          }
-        }
-      } else {
-        params.append(
-          key,
-          value instanceof Date ? value.toISOString() : value.toString(),
-        )
+    if (typeof key !== 'string' || value == null) continue
+    if (Array.isArray(value)) {
+      for (const inner of value) {
+        const s = toParamString(inner)
+        if (s !== null) params.append(key, s)
       }
+      continue
     }
+    const s = toParamString(value)
+    if (s !== null) params.append(key, s)
   }
-
   return params
 }
 
@@ -155,11 +151,9 @@ export const unmarshalMapOfObject = <T, B extends boolean>(
       : Record<string, T>
   }
 
-  return Object.entries(data).reduce(
-    (acc, [key, value]) => ({
-      ...acc,
-      [key]: unmarshaller(value),
-    }),
-    {},
-  )
+  const out: Record<string, T> = {}
+  for (const [key, value] of Object.entries(data)) {
+    out[key] = unmarshaller(value)
+  }
+  return out
 }

packages/client/src/internal/async/__tests__/interval-retrier.test.ts

@@ -97,7 +97,7 @@ const mockLogic = (iterations: number, workingTime: number) => {
       done: counter >= iterations,
       value: {
         doneIterations: counter,
-        totalDuration: new Date().getTime() - startDate.getTime(),
+        totalDuration: Date.now() - startDate.getTime(),
       },
     }
   }

packages/client/src/internal/async/__tests__/sleep.test.ts

@@ -13,7 +13,9 @@ afterAll(() => {
 describe('sleep', () => {
   it('delays the proper amount of time', () => {
     const delay = 50 // 0.05s
-    sleep(delay).catch(() => {})
+    sleep(delay).catch(() => {
+      /* noop */
+    })
     expect(setTimeout).toHaveBeenCalledTimes(1)
     expect(setTimeout).toHaveBeenLastCalledWith(expect.any(Function), delay)
   })