test: adjust window coverage (#471)

Author: Vinzius

packages/clients/src/helpers/__tests__/is-browser.browser.ts

@@ -0,0 +1,9 @@
+/* @jest-environment jsdom */
+import { describe, expect, it } from '@jest/globals'
+import { isBrowser } from '../is-browser'
+
+describe('isBrowser', () => {
+  it('returns true by default', () => {
+    expect(isBrowser()).toBe(true)
+  })
+})

packages/clients/src/helpers/__tests__/is-browser.node.ts

@@ -0,0 +1,9 @@
+/* @jest-environment node */
+import { describe, expect, it } from '@jest/globals'
+import { isBrowser } from '../is-browser'
+
+describe('isBrowser', () => {
+  it('returns false by default', () => {
+    expect(isBrowser()).toBe(false)
+  })
+})

packages/clients/src/helpers/__tests__/is-browser.ts

@@ -43,17 +43,6 @@ describe(`buildRequest`, () => {
     })
   }
 
-  it(`has NOT the header "User-Agent" when browser is detected`, () => {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error Fake window/document for the test
-    global.window = { document: 'not-undefined' }
-    const fReq = buildRequest(SCW_POST_REQUEST, DEFAULT_SETTINGS)
-    expect(fReq.headers.get('User-Agent')).toBeNull()
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error Reset the global variable
-    delete global.window
-  })
-
   it(`has the custom headers`, () => {
     const mReq: ScwRequest = {
       ...SCW_POST_REQUEST,

packages/clients/src/scw/fetch/__tests__/build-fetcher.ts

@@ -32,7 +32,9 @@ export const buildRequest = (
     body: request.body,
     headers: {
       Accept: 'application/json',
-      ...(!isBrowser() ? { 'User-Agent': settings.userAgent } : {}),
+      .../* istanbul ignore next */ (!isBrowser()
+        ? { 'User-Agent': settings.userAgent }
+        : {}),
       ...request.headers,
     },
     method: request.method,