chore: align pre-commit with ESLint behavior and fix non-breaking lints

Author: jremy42

package.json

@@ -23,8 +23,8 @@
     "build:profile": "cross-env PROFILE=true pnpm run build",
     "commit": "npx git-cz -a",
     "doc": "typedoc",
-    "format": "biome check --write .",
-    "format:check": "biome check .",
+    "format": "biome check --linter-enabled=false --write .",
+    "format:check": "biome check --linter-enabled=false .",
     "prettier": "prettier --write '**/*.{md,mdx,yml,yaml}'",
     "lint": "biome lint .",
     "lint:fix": "biome check --write .",
@@ -35,6 +35,16 @@
     "test:ui": "vitest --ui"
   },
   "lint-staged": {
+    "globOptions": {
+      "ignore": [
+        "**/*.gen.ts",
+        "packages_generated/**",
+        "**/dist/**",
+        "**/build/**",
+        "**/coverage/**",
+        "**/examples/**"
+      ]
+    },
     "*.{ts,tsx,js,jsx}": [
       "biome check --write --no-errors-on-unmatched --files-ignore-unknown=true"
     ],

packages/client/src/helpers/json.ts

@@ -1,3 +1,4 @@
+/* biome-ignore lint/style/useNamingConvention: public alias intended as JSON shape */
 export type JSON =
   | string
   | number

packages/client/src/internal/async/interval-retrier.ts

@@ -111,7 +111,8 @@ export const tryAtIntervals = async <T>(
   const timeoutTimestamp = Date.now() + timeout * 1000
   let retryCount = 0
   while (Date.now() <= timeoutTimestamp) {
-    const delay = strategy.next((retryCount += 1)).value * 1000
+    retryCount += 1
+    const delay = strategy.next(retryCount).value * 1000
     // Break if timeout has been reached
     if (timeoutTimestamp <= Date.now() + delay) break
     // Wait before the next retry

packages/client/src/internal/validations/__tests__/string-validation.test.ts

@@ -78,14 +78,14 @@ const validators = [
 for (const component of validators) {
   describe(component.validator.name, () => {
     it(`validates correct ${component.name} format`, () => {
-      component.valids.forEach(str =>
-        expect(component.validator(str)).toStrictEqual(true),
-      )
+      for (const str of component.valids) {
+        expect(component.validator(str)).toStrictEqual(true)
+      }
     })
     it(`doesn't validate incorrect ${component.name} format`, () => {
-      component.invalids.forEach(str =>
-        expect(component.validator(str)).toStrictEqual(false),
-      )
+      for (const str of component.invalids) {
+        expect(component.validator(str)).toStrictEqual(false)
+      }
     })
   })
 }

packages/client/src/scw/fetch/http-interceptors.ts

@@ -10,7 +10,7 @@ import {
 import { dumpRequest, dumpResponse } from './http-dumper.js'
 
 /**
- * Mapper d'une entrée d'en-tête.
+ * Mapper of a header entry.
  *
  * @internal
  */

packages_generated/account/src/v3/api.gen.ts

@@ -1,8 +1,8 @@
 // This file was automatically generated. DO NOT EDIT.
 // If you have any remark or suggestion do not hesitate to open an issue.
 import {
-  enrichForPagination,
   API as ParentAPI,
+  enrichForPagination,
   urlParams,
   validatePathParam,
 } from '@scaleway/sdk-client'

packages_generated/account/src/v3/marshalling.gen.ts

@@ -1,13 +1,13 @@
 // This file was automatically generated. DO NOT EDIT.
 // If you have any remark or suggestion do not hesitate to open an issue.
 import randomName from '@scaleway/random-name'
-import type { DefaultValues } from '@scaleway/sdk-client'
 import {
   isJSONObject,
   resolveOneOf,
   unmarshalArrayOfObject,
   unmarshalDate,
 } from '@scaleway/sdk-client'
+import type { DefaultValues } from '@scaleway/sdk-client'
 import type {
   CheckContractSignatureResponse,
   Contract,

packages_generated/account/src/v3/validation-rules.gen.ts

@@ -30,15 +30,15 @@ export const ProjectApiCreateProjectRequest = {
   name: {
     maxLength: 64,
     minLength: 1,
-    pattern: /^[a-zA-Z0-9._\- ]+$/,
+    pattern: /^[a-zA-Z0-9\._\- ]+$/,
   },
 }
 
 export const ProjectApiListProjectsRequest = {
   name: {
     maxLength: 64,
     minLength: 1,
-    pattern: /^[a-zA-Z0-9._\- ]+$/,
+    pattern: /^[a-zA-Z0-9\._\- ]+$/,
   },
   page: {
     greaterThan: 0,
@@ -56,6 +56,6 @@ export const ProjectApiUpdateProjectRequest = {
   name: {
     maxLength: 64,
     minLength: 1,
-    pattern: /^[a-zA-Z0-9._\- ]+$/,
+    pattern: /^[a-zA-Z0-9\._\- ]+$/,
   },
 }

packages_generated/applesilicon/src/v1alpha1/api.gen.ts

@@ -1,15 +1,14 @@
 // This file was automatically generated. DO NOT EDIT.
 // If you have any remark or suggestion do not hesitate to open an issue.
-
-import type { ApiLocality, WaitForOptions } from '@scaleway/sdk-client'
 import {
-  enrichForPagination,
   API as ParentAPI,
+  enrichForPagination,
   toApiLocality,
   urlParams,
   validatePathParam,
   waitForResource,
 } from '@scaleway/sdk-client'
+import type { ApiLocality, WaitForOptions } from '@scaleway/sdk-client'
 import {
   SERVER_PRIVATE_NETWORK_SERVER_TRANSIENT_STATUSES as SERVER_PRIVATE_NETWORK_SERVER_TRANSIENT_STATUSES_APPLESILICON,
   SERVER_TRANSIENT_STATUSES as SERVER_TRANSIENT_STATUSES_APPLESILICON,
@@ -26,8 +25,8 @@ import {
   unmarshalConnectivityDiagnostic,
   unmarshalListOSResponse,
   unmarshalListServerPrivateNetworksResponse,
-  unmarshalListServersResponse,
   unmarshalListServerTypesResponse,
+  unmarshalListServersResponse,
   unmarshalOS,
   unmarshalServer,
   unmarshalServerPrivateNetwork,
@@ -48,10 +47,10 @@ import type {
   ListOSRequest,
   ListOSResponse,
   ListServerPrivateNetworksResponse,
-  ListServersRequest,
-  ListServersResponse,
   ListServerTypesRequest,
   ListServerTypesResponse,
+  ListServersRequest,
+  ListServersResponse,
   OS,
   PrivateNetworkApiAddServerPrivateNetworkRequest,
   PrivateNetworkApiDeleteServerPrivateNetworkRequest,

packages_generated/applesilicon/src/v1alpha1/index.gen.ts

@@ -27,11 +27,11 @@ export type {
   ListOSResponse,
   ListServerPrivateNetworksRequestOrderBy,
   ListServerPrivateNetworksResponse,
+  ListServerTypesRequest,
+  ListServerTypesResponse,
   ListServersRequest,
   ListServersRequestOrderBy,
   ListServersResponse,
-  ListServerTypesRequest,
-  ListServerTypesResponse,
   OS,
   OSSupportedServerType,
   PrivateNetworkApiAddServerPrivateNetworkRequest,
@@ -53,8 +53,8 @@ export type {
   ServerTypeDisk,
   ServerTypeGPU,
   ServerTypeMemory,
-  ServerTypeNetwork,
   ServerTypeNPU,
+  ServerTypeNetwork,
   ServerTypeStock,
   SetServerPrivateNetworksResponse,
   StartConnectivityDiagnosticRequest,