Skip to content

Commit 6451017

Browse files
committed
test: remove node 18
1 parent f20efdf commit 6451017

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/run-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ jobs:
4343
- node
4444
- jsdom
4545
node:
46-
- '18'
4746
- '20'
4847
- '22'
4948
- '24'

eslint.config.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ export default [
1111
ignores: [
1212
'**/node_modules/',
1313
'**/dist/',
14+
'**/build/',
15+
'**/coverage/',
1416
'**/examples/',
1517
'**/vite.config.ts',
1618
'packages/clients/.eslintrc.cjs',
@@ -22,6 +24,7 @@ export default [
2224
'scripts/generatePackages.ts',
2325
'scripts/*.ts',
2426
'formatting/**',
27+
'*.min.js',
2528
],
2629
},
2730
{

packages/client/src/internal/interceptors/__tests__/helpers.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@ describe('addHeaderInterceptor', () => {
2020
expect(updatedReq.headers.get('my-key')).toBe('my-value')
2121
})
2222

23-
it(`desn't modify the input request`, async () => {
23+
it(`doesn't modify the input request`, async () => {
2424
const request = new Request('https://api.scaleway.com/my/path')
25+
const originalHeaders = request.headers
2526
const updatedReq = await addHeaderInterceptor(
2627
'my-key',
2728
'my-value',
2829
)({ request })
29-
expect(request).not.toStrictEqual(updatedReq)
30+
expect(request.headers).toBe(originalHeaders)
31+
expect(updatedReq.headers.get('my-key')).toBe('my-value')
3032
})
3133
})
3234

0 commit comments

Comments
 (0)