chore: remove linter warnings, and move jsdom to devDep (#1154)

Author: Vinzius

.eslintrc

@@ -2,7 +2,7 @@
   "root": true,
   "plugins": ["eslint-plugin-tsdoc"],
   "parserOptions": {
-    "project": ["tsconfig.json"],
+    "project": ["tsconfig.json"]
   },
   "extends": ["@scaleway/react/typescript"],
   "rules": {
@@ -17,23 +17,23 @@
     "import/prefer-default-export": "off",
     "import/no-default-export": "error",
     "no-await-in-loop": "off",
-    "@typescript-eslint/no-namespace": "off",
+    "@typescript-eslint/no-namespace": "off"
   },
   "overrides": [
     {
       "files": [
         "./packages/clients/src/scw/**/*.ts",
-        "./packages/clients/src/internal/**/*.ts",
+        "./packages/clients/src/internal/**/*.ts"
       ],
       "rules": {
-        "@typescript-eslint/consistent-type-definitions": "off",
+        "@typescript-eslint/consistent-type-definitions": "off"
       }
     },
     {
       "files": ["**/*.test.ts", "__tests__/**/*.ts", "vite.config.ts"],
       "rules": {
         "eslint-disable import/no-extraneous-dependencies": "off"
-      },
-    },
-  ],
+      }
+    }
+  ]
 }

package.json

@@ -64,6 +64,7 @@
     "eslint": "8.56.0",
     "eslint-plugin-tsdoc": "0.2.17",
     "husky": "9.0.11",
+    "jsdom": "24.0.0",
     "lerna": "7.4.2",
     "lint-staged": "15.2.2",
     "prettier": "3.2.5",
@@ -76,8 +77,5 @@
     "vite": "5.1.2",
     "vitest": "1.2.2"
   },
-  "packageManager": "[email protected]",
-  "dependencies": {
-    "jsdom": "24.0.0"
-  }
+  "packageManager": "[email protected]"
 }

packages/clients/src/internal/async/interval-retrier.ts

@@ -20,7 +20,7 @@ type Retry<T> = () => Promise<IteratorResult<T, T>>
  *
  * @internal
  */
-type IntervalStrategy = Generator<number, never | number, number>
+type IntervalStrategy = Generator<number, number, number>
 
 /**
  * Creates a fixed interval strategy.

packages/clients/src/internal/interceptors/types.ts

@@ -68,13 +68,7 @@ export interface ResponseInterceptor {
  * @public
  */
 export interface ResponseErrorInterceptor {
-  ({
-    request,
-    error,
-  }: {
-    request: Request
-    error: unknown
-  }): unknown | Promise<unknown>
+  ({ request, error }: { request: Request; error: unknown }): unknown
 }
 
 /**

packages/configuration-loader/src/types.d.ts

@@ -46,10 +46,7 @@ export type Profile = {
 }
 
 /** Configuration type. */
-export type ConfigurationType = Record<
-  'default' | string,
-  Record<string, string>
->
+export type ConfigurationType = Record<string, Record<string, string>>
 /** Parameters to load the all the profiles from the configuration file */
 export type AllProfilesFromFileParams = {
   /**
@@ -68,5 +65,5 @@ export type ProfileFromFileParams = AllProfilesFromFileParams & {
    *
    * @defaultValue `default`
    * */
-  profileName?: 'default' | string
+  profileName?: string
 }