Skip to content

Commit 750a7c0

Browse files
authored
fix(secret_manager): break change due to scheduled deletion (#1874)
1 parent aa60254 commit 750a7c0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/clients/src/api/secret/v1beta1/api.gen.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export class API extends ParentAPI {
143143
path: `/secret-manager/v1beta1/regions/${validatePathParam('region', request.region ?? this.client.settings.defaultRegion)}/secrets/${validatePathParam('secretId', request.secretId)}`,
144144
})
145145

146-
protected pageOfListSecrets = (request: Readonly<ListSecretsRequest> = {}) =>
146+
protected pageOfListSecrets = (request: Readonly<ListSecretsRequest>) =>
147147
this.client.fetch<ListSecretsResponse>(
148148
{
149149
method: 'GET',
@@ -176,7 +176,7 @@ export class API extends ParentAPI {
176176
* @param request - The request {@link ListSecretsRequest}
177177
* @returns A Promise of ListSecretsResponse
178178
*/
179-
listSecrets = (request: Readonly<ListSecretsRequest> = {}) =>
179+
listSecrets = (request: Readonly<ListSecretsRequest>) =>
180180
enrichForPagination('secrets', this.pageOfListSecrets, request)
181181

182182
/**

packages/clients/src/api/secret/v1beta1/types.gen.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -508,9 +508,10 @@ export type ListSecretsRequest = {
508508
type?: SecretType
509509
/**
510510
* Filter by whether the secret was scheduled for deletion / not scheduled for
511-
* deletion (optional).
511+
* deletion. By default, it will display only not scheduled for deletion
512+
* secrets.
512513
*/
513-
scheduledForDeletion?: boolean
514+
scheduledForDeletion: boolean
514515
}
515516

516517
export interface ListSecretsResponse {

0 commit comments

Comments
 (0)