chore(linter): disable deprecation warnings for APIs (#214)

Vinzius · web-flow · commit 7acdc5a512ae · 2022-11-07T15:11:53.000+01:00
diff --git a/packages/clients/src/api/.eslintrc b/packages/clients/src/api/.eslintrc
@@ -5,6 +5,7 @@
     "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "defaults|request" }],
     "max-classes-per-file": "off",
     "tsdoc/syntax": "off",
-    "no-underscore-dangle": ["error", { "allowAfterThis": true }]
+    "no-underscore-dangle": ["error", { "allowAfterThis": true }],
+    "deprecation/deprecation": "off"
   }
 }
diff --git a/packages/clients/src/scw/client-settings.ts b/packages/clients/src/scw/client-settings.ts
@@ -101,7 +101,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {
   // API URL.
   if (!isURL(obj.apiURL)) throw new Error(`Invalid URL ${obj.apiURL}`)
 
-  if (obj.apiURL.substr(-1) === '/')
+  if (obj.apiURL.slice(-1) === '/')
     throw new Error(
       `Invalid URL ${obj.apiURL}: it should not have a trailing slash`,
     )

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`"@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "defaults\|request" }],`
`6`	`6`	`"max-classes-per-file": "off",`
`7`	`7`	`"tsdoc/syntax": "off",`
`8`		`- "no-underscore-dangle": ["error", { "allowAfterThis": true }]`
	`8`	`+ "no-underscore-dangle": ["error", { "allowAfterThis": true }],`
	`9`	`+ "deprecation/deprecation": "off"`
`9`	`10`	`}`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {`
`101`	`101`	`// API URL.`
`102`	`102`	if (!isURL(obj.apiURL)) throw new Error(`Invalid URL ${obj.apiURL}`)
`103`	`103`
`104`		`- if (obj.apiURL.substr(-1) === '/')`
	`104`	`+ if (obj.apiURL.slice(-1) === '/')`
`105`	`105`	`throw new Error(`
`106`	`106`	`Invalid URL ${obj.apiURL}: it should not have a trailing slash`,
`107`	`107`	`)`