chore(minor-deps): update dependency @scaleway/eslint-config-react to ^3.14.1 (#378)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vincent Germain <[email protected]>

Author: renovate[bot]

package.json

@@ -78,7 +78,7 @@
     "@rollup/plugin-commonjs": "^24.0.1",
     "@rollup/plugin-inject": "^5.0.3",
     "@rollup/plugin-node-resolve": "^15.0.1",
-    "@scaleway/eslint-config-react": "^3.13.7",
+    "@scaleway/eslint-config-react": "^3.14.1",
     "@types/jest": "^29.2.6",
     "babel-plugin-annotate-pure-calls": "^0.4.0",
     "cross-env": "^7.0.3",

packages/clients/src/api/baremetal/v1/api.utils.ts

@@ -31,12 +31,6 @@ export class BaremetalV1UtilsAPI extends API {
           return server.install
         })
 
-        if (!value) {
-          throw new Error(
-            `Server creation has not begun for server ${request.serverId}`,
-          )
-        }
-
         return {
           done: !SERVER_INSTALL_TRANSIENT_STATUSES.includes(value.status),
           value,

packages/clients/src/api/instance/v1/api.utils.ts

@@ -504,7 +504,7 @@ export class InstanceV1UtilsAPI extends API {
             method: 'PUT',
             path: `/instance/v1/zones/${validatePathParam(
               'zone',
-              imageReq.zone ?? this.client.settings.defaultZone,
+              imageReq.zone,
             )}/images/${validatePathParam('id', imageReq.id)}`,
           },
           unmarshalSetImageResponse,

packages/clients/src/helpers/__tests__/is-browser.ts

@@ -7,12 +7,10 @@ describe('isBrowser', () => {
   })
 
   it('returns true after defining a window', () => {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore Fake window/document for the test
+    // @ts-expect-error Fake window/document for the test
     global.window = { document: 'not-undefined' }
     expect(isBrowser()).toBe(true)
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore Reset the global variable
+    // @ts-expect-error Reset the global variable
     delete global.window
   })
 })

packages/clients/src/helpers/json.ts

@@ -36,7 +36,7 @@ export const isJSONObject = (obj: unknown): obj is JSONObject => {
     objT !== 'string' &&
     objT !== 'number' &&
     objT !== 'boolean' &&
-    Array.isArray(obj) === false &&
+    !Array.isArray(obj) &&
     objT === 'object'
   )
 }

packages/clients/src/internal/async/interval-retrier.ts

@@ -34,6 +34,7 @@ type IntervalStrategy = Generator<number, never | number, number>
 export function* createFixedIntervalStrategy(
   interval: number,
 ): IntervalStrategy {
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   while (true) yield interval
 }
 
@@ -51,6 +52,7 @@ export function* createFibonacciIntervalStrategy(
   factor = 1,
 ): IntervalStrategy {
   let [prev, current] = [0, 1]
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   while (true) {
     yield current * base
     ;[prev, current] = [current, prev + current * factor]
@@ -79,6 +81,7 @@ export function* createExponentialBackoffStrategy(
   const ceiling = Math.log(maxDelay / minDelay) / Math.log(2) + 1
   const randomInRange = (min: number, max: number) =>
     min + Math.random() * (max - min)
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   while (true) {
     if (attempt > ceiling) {
       yield maxDelay

packages/clients/src/internal/interceptors/interceptor.ts

@@ -15,5 +15,7 @@ export const composeInterceptors =
   async (instance: T): Promise<T> =>
     interceptors.reduce(
       async (asyncResult, interceptor) => interceptor(await asyncResult),
-      Promise.resolve(instance) as Promise<T>,
+      new Promise<T>(resolve => {
+        resolve(instance)
+      }),
     )

packages/clients/src/scw/__tests__/client-settings.ts

@@ -19,23 +19,20 @@ const VALID_SETTINGS: Settings = {
 const INVALID_SETTINGS_LIST: Partial<Settings>[] = [
   { apiURL: 'https://api.scaleway.com/' },
   { apiURL: 'ftp://api.scaleway.com' },
-  // @ts-ignore Unknown zone
   { defaultZone: 'fr-par-0' },
-  // @ts-ignore Unknown zone
   { defaultZone: 'fr-par' },
-  // @ts-ignore Unknown region
   { defaultRegion: 'fr-par-1' },
-  // @ts-ignore Unknown client type
+  // @ts-expect-error Unknown client type
   { httpClient: 'str-client' },
   { defaultOrganizationId: '' },
   { defaultOrganizationId: 'not-a-uuid-v4' },
   { defaultProjectId: '' },
   { defaultProjectId: 'not-a-uuid-v4' },
   { defaultPageSize: 0 },
   { defaultPageSize: -1 },
-  // @ts-ignore
+  // @ts-expect-error Wrong type
   { defaultPageSize: '42' },
-  // @ts-ignore Unknown user agent type
+  // @ts-expect-error Unknown user agent type
   { userAgent: null },
 ]
 /* eslint-enable @typescript-eslint/ban-ts-comment */

packages/clients/src/scw/client-settings.ts

@@ -68,7 +68,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {
     ) {
       throw new Error('Default organization ID cannot be empty')
     }
-    if (isOrganizationId(obj.defaultOrganizationId) !== true) {
+    if (!isOrganizationId(obj.defaultOrganizationId)) {
       throw new Error(
         `Invalid organization ID format '${obj.defaultOrganizationId}', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx`,
       )
@@ -83,7 +83,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {
     ) {
       throw new Error('Default project ID cannot be empty')
     }
-    if (isProjectId(obj.defaultProjectId) !== true) {
+    if (!isProjectId(obj.defaultProjectId)) {
       throw new Error(
         `Invalid project ID format '${obj.defaultProjectId}', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx`,
       )
@@ -105,7 +105,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {
     throw new Error(`Invalid URL ${obj.apiURL}`)
   }
 
-  if (obj.apiURL.slice(-1) === '/') {
+  if (obj.apiURL.endsWith('/')) {
     throw new Error(
       `Invalid URL ${obj.apiURL}: it should not have a trailing slash`,
     )

packages/clients/src/scw/errors/scw-error.ts

@@ -66,4 +66,8 @@ export class ScalewayError extends Error {
   ): ScalewayError | null {
     return new ScalewayError(status, obj)
   }
+
+  toString(): string {
+    return `${this.name}: ${this.message}`
+  }
 }