From f20efdf2b6e02dd09f8bfe7e2a11fa77ac487e04 Mon Sep 17 00:00:00 2001 From: Jonathan Remy Date: Fri, 1 Aug 2025 10:52:19 +0200 Subject: [PATCH 1/2] test: add node 22 and 24 in test --- .github/workflows/run-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index cda60e638..2a0a554d2 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -45,6 +45,8 @@ jobs: node: - '18' - '20' + - '22' + - '24' steps: - uses: actions/checkout@v4.2.2 - uses: pnpm/action-setup@v4.1.0 From 64510170b0d64b19bf3c17967aaced029a967310 Mon Sep 17 00:00:00 2001 From: Jonathan Remy Date: Fri, 1 Aug 2025 10:57:46 +0200 Subject: [PATCH 2/2] test: remove node 18 --- .github/workflows/run-tests.yml | 1 - eslint.config.mjs | 3 +++ .../src/internal/interceptors/__tests__/helpers.test.ts | 6 ++++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 2a0a554d2..0321d145a 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -43,7 +43,6 @@ jobs: - node - jsdom node: - - '18' - '20' - '22' - '24' diff --git a/eslint.config.mjs b/eslint.config.mjs index e6534178c..0da282efc 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -11,6 +11,8 @@ export default [ ignores: [ '**/node_modules/', '**/dist/', + '**/build/', + '**/coverage/', '**/examples/', '**/vite.config.ts', 'packages/clients/.eslintrc.cjs', @@ -22,6 +24,7 @@ export default [ 'scripts/generatePackages.ts', 'scripts/*.ts', 'formatting/**', + '*.min.js', ], }, { diff --git a/packages/client/src/internal/interceptors/__tests__/helpers.test.ts b/packages/client/src/internal/interceptors/__tests__/helpers.test.ts index de6a705e0..31d6e4510 100644 --- a/packages/client/src/internal/interceptors/__tests__/helpers.test.ts +++ b/packages/client/src/internal/interceptors/__tests__/helpers.test.ts @@ -20,13 +20,15 @@ describe('addHeaderInterceptor', () => { expect(updatedReq.headers.get('my-key')).toBe('my-value') }) - it(`desn't modify the input request`, async () => { + it(`doesn't modify the input request`, async () => { const request = new Request('https://api.scaleway.com/my/path') + const originalHeaders = request.headers const updatedReq = await addHeaderInterceptor( 'my-key', 'my-value', )({ request }) - expect(request).not.toStrictEqual(updatedReq) + expect(request.headers).toBe(originalHeaders) + expect(updatedReq.headers.get('my-key')).toBe('my-value') }) })