fix(webhosting): require domain_name on RemoveCustomDomainRequest (#1224)

Co-authored-by: Mia-Cross <[email protected]>

Author: scaleway-bot

scaleway-async/scaleway_async/webhosting/v1/api.py

@@ -49,6 +49,7 @@
     Hosting,
     HostingApiAddCustomDomainRequest,
     HostingApiCreateHostingRequest,
+    HostingApiRemoveCustomDomainRequest,
     HostingApiUpdateHostingRequest,
     HostingSummary,
     ListBackupItemsResponse,
@@ -124,6 +125,7 @@
     marshal_FtpAccountApiCreateFtpAccountRequest,
     marshal_HostingApiAddCustomDomainRequest,
     marshal_HostingApiCreateHostingRequest,
+    marshal_HostingApiRemoveCustomDomainRequest,
     marshal_HostingApiUpdateHostingRequest,
     marshal_MailAccountApiChangeMailAccountPasswordRequest,
     marshal_MailAccountApiCreateMailAccountRequest,
@@ -1913,11 +1915,13 @@ async def remove_custom_domain(
         self,
         *,
         hosting_id: str,
+        domain_name: str,
         region: Optional[ScwRegion] = None,
     ) -> HostingSummary:
         """
         Detach a custom domain from a webhosting.
         :param hosting_id: Hosting ID to which the custom domain is detached from.
+        :param domain_name: The custom domain name to detach from the hosting.
         :param region: Region to target. If none is passed will use default region from the config.
         :return: :class:`HostingSummary <HostingSummary>`
 
@@ -1926,6 +1930,7 @@ async def remove_custom_domain(
 
             result = await api.remove_custom_domain(
                 hosting_id="example",
+                domain_name="example",
             )
         """
 
@@ -1937,7 +1942,14 @@ async def remove_custom_domain(
         res = self._request(
             "POST",
             f"/webhosting/v1/regions/{param_region}/hostings/{param_hosting_id}/remove-custom-domain",
-            body={},
+            body=marshal_HostingApiRemoveCustomDomainRequest(
+                HostingApiRemoveCustomDomainRequest(
+                    hosting_id=hosting_id,
+                    domain_name=domain_name,
+                    region=region,
+                ),
+                self.client,
+            ),
         )
 
         self._throw_on_error(res)

scaleway-async/scaleway_async/webhosting/v1/marshalling.py

@@ -92,6 +92,7 @@
     CreateHostingRequestDomainConfiguration,
     OfferOptionRequest,
     HostingApiCreateHostingRequest,
+    HostingApiRemoveCustomDomainRequest,
     HostingApiUpdateHostingRequest,
     MailAccountApiChangeMailAccountPasswordRequest,
     MailAccountApiCreateMailAccountRequest,
@@ -1951,6 +1952,18 @@ def marshal_HostingApiCreateHostingRequest(
     return output
 
 
+def marshal_HostingApiRemoveCustomDomainRequest(
+    request: HostingApiRemoveCustomDomainRequest,
+    defaults: ProfileDefaults,
+) -> Dict[str, Any]:
+    output: Dict[str, Any] = {}
+
+    if request.domain_name is not None:
+        output["domain_name"] = request.domain_name
+
+    return output
+
+
 def marshal_HostingApiUpdateHostingRequest(
     request: HostingApiUpdateHostingRequest,
     defaults: ProfileDefaults,

scaleway-async/scaleway_async/webhosting/v1/types.py

@@ -1885,6 +1885,11 @@ class HostingApiRemoveCustomDomainRequest:
     Hosting ID to which the custom domain is detached from.
     """
 
+    domain_name: str
+    """
+    The custom domain name to detach from the hosting.
+    """
+
     region: Optional[ScwRegion] = None
     """
     Region to target. If none is passed will use default region from the config.

scaleway/scaleway/webhosting/v1/api.py

@@ -49,6 +49,7 @@
     Hosting,
     HostingApiAddCustomDomainRequest,
     HostingApiCreateHostingRequest,
+    HostingApiRemoveCustomDomainRequest,
     HostingApiUpdateHostingRequest,
     HostingSummary,
     ListBackupItemsResponse,
@@ -124,6 +125,7 @@
     marshal_FtpAccountApiCreateFtpAccountRequest,
     marshal_HostingApiAddCustomDomainRequest,
     marshal_HostingApiCreateHostingRequest,
+    marshal_HostingApiRemoveCustomDomainRequest,
     marshal_HostingApiUpdateHostingRequest,
     marshal_MailAccountApiChangeMailAccountPasswordRequest,
     marshal_MailAccountApiCreateMailAccountRequest,
@@ -1913,11 +1915,13 @@ def remove_custom_domain(
         self,
         *,
         hosting_id: str,
+        domain_name: str,
         region: Optional[ScwRegion] = None,
     ) -> HostingSummary:
         """
         Detach a custom domain from a webhosting.
         :param hosting_id: Hosting ID to which the custom domain is detached from.
+        :param domain_name: The custom domain name to detach from the hosting.
         :param region: Region to target. If none is passed will use default region from the config.
         :return: :class:`HostingSummary <HostingSummary>`
 
@@ -1926,6 +1930,7 @@ def remove_custom_domain(
 
             result = api.remove_custom_domain(
                 hosting_id="example",
+                domain_name="example",
             )
         """
 
@@ -1937,7 +1942,14 @@ def remove_custom_domain(
         res = self._request(
             "POST",
             f"/webhosting/v1/regions/{param_region}/hostings/{param_hosting_id}/remove-custom-domain",
-            body={},
+            body=marshal_HostingApiRemoveCustomDomainRequest(
+                HostingApiRemoveCustomDomainRequest(
+                    hosting_id=hosting_id,
+                    domain_name=domain_name,
+                    region=region,
+                ),
+                self.client,
+            ),
         )
 
         self._throw_on_error(res)

scaleway/scaleway/webhosting/v1/marshalling.py

@@ -92,6 +92,7 @@
     CreateHostingRequestDomainConfiguration,
     OfferOptionRequest,
     HostingApiCreateHostingRequest,
+    HostingApiRemoveCustomDomainRequest,
     HostingApiUpdateHostingRequest,
     MailAccountApiChangeMailAccountPasswordRequest,
     MailAccountApiCreateMailAccountRequest,
@@ -1951,6 +1952,18 @@ def marshal_HostingApiCreateHostingRequest(
     return output
 
 
+def marshal_HostingApiRemoveCustomDomainRequest(
+    request: HostingApiRemoveCustomDomainRequest,
+    defaults: ProfileDefaults,
+) -> Dict[str, Any]:
+    output: Dict[str, Any] = {}
+
+    if request.domain_name is not None:
+        output["domain_name"] = request.domain_name
+
+    return output
+
+
 def marshal_HostingApiUpdateHostingRequest(
     request: HostingApiUpdateHostingRequest,
     defaults: ProfileDefaults,

scaleway/scaleway/webhosting/v1/types.py

@@ -1885,6 +1885,11 @@ class HostingApiRemoveCustomDomainRequest:
     Hosting ID to which the custom domain is detached from.
     """
 
+    domain_name: str
+    """
+    The custom domain name to detach from the hosting.
+    """
+
     region: Optional[ScwRegion] = None
     """
     Region to target. If none is passed will use default region from the config.