test(mongodb): convert monkeypatch tests to VCR integration for snapshot creation

Author: jremy42

scaleway/scaleway/mongodb/v1/tests/test_custom_api.py

@@ -1,64 +1,32 @@
-from datetime import datetime, timezone
+import os
+from datetime import datetime, timedelta, timezone
 
 import pytest
 
-from scaleway.mongodb.v1.api import MongodbV1API
+from vcr_config import scw_vcr
+from tests.utils import initialize_client_test
 from scaleway.mongodb.v1.custom_api import MongodbUtilsV1API
 
-class _DummyClient:
-    pass
 
 # mypy: ignore-errors
 
 
-@pytest.mark.parametrize("method_name", ["create_snapshot", "update_snapshot"])
-def test_utils_api_coerces_naive_datetime_to_utc(
-    monkeypatch: pytest.MonkeyPatch, method_name: str
-) -> None:
-    captured = {}
+@scw_vcr.use_cassette
+def test_create_snapshot_with_naive_expires_at_vcr() -> None:
+    client = initialize_client_test()
+    api = MongodbUtilsV1API(client, bypass_validation=True)
 
-    def dummy(self, **kwargs):  # type: ignore[no-untyped-def]
-        captured.update(kwargs)
-        return kwargs
+    instance_id = os.environ.get("SCW_TEST_MONGODB_INSTANCE_ID")
+    if not instance_id:
+        pytest.skip("SCW_TEST_MONGODB_INSTANCE_ID not set for recording")
 
-    monkeypatch.setattr(MongodbV1API, method_name, dummy, raising=True)
+    # Naive datetime should be handled as UTC by the utils API
+    naive_dt = datetime.now().replace(tzinfo=None) + timedelta(days=1)
 
-    api = MongodbUtilsV1API(client=_DummyClient(), bypass_validation=True)
+    snapshot = api.create_snapshot(
+        instance_id=instance_id,
+        name="sdk-python-test-snapshot",
+        expires_at=naive_dt,
+    )
 
-    # Build naive datetime without triggering DTZ001 (construct aware then strip tz)
-    naive_dt = datetime(2030, 1, 1, 12, 0, 0, tzinfo=timezone.utc).replace(tzinfo=None)
-
-    if method_name == "create_snapshot":
-        api.create_snapshot(instance_id="iid", name="n", expires_at=naive_dt)
-    else:
-        api.update_snapshot(snapshot_id="sid", expires_at=naive_dt)
-
-    assert "expires_at" in captured
-    coerced = captured["expires_at"]
-    assert isinstance(coerced, datetime)
-    assert coerced.tzinfo is not None
-    assert coerced.utcoffset() == timezone.utc.utcoffset(coerced)
-
-
-@pytest.mark.parametrize("method_name", ["create_snapshot", "update_snapshot"])
-def test_utils_api_preserves_aware_datetime(
-    monkeypatch: pytest.MonkeyPatch, method_name: str
-) -> None:
-    captured = {}
-
-    def dummy(self, **kwargs):  # type: ignore[no-untyped-def]
-        captured.update(kwargs)
-        return kwargs
-
-    monkeypatch.setattr(MongodbV1API, method_name, dummy, raising=True)
-
-    api = MongodbUtilsV1API(client=_DummyClient(), bypass_validation=True)
-
-    aware_dt = datetime(2030, 1, 1, 12, 0, 0, tzinfo=timezone.utc)
-
-    if method_name == "create_snapshot":
-        api.create_snapshot(instance_id="iid", name="n", expires_at=aware_dt)
-    else:
-        api.update_snapshot(snapshot_id="sid", expires_at=aware_dt)
-
-    assert captured["expires_at"] is aware_dt
+    assert snapshot is not None