Skip to content

Commit a2714f2

Browse files
committed
tests: remove logs
1 parent d702461 commit a2714f2

File tree

2 files changed

+5
-39
lines changed

2 files changed

+5
-39
lines changed

scaleway/tests/test_instance.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import logging
2-
import sys
31
from typing import List
42
import unittest
53
import uuid
@@ -11,10 +9,6 @@
119
from scaleway.instance.v1.types import Server, VolumeServerTemplate
1210
from scaleway.block.v1alpha1.types import Volume, CreateVolumeRequestFromEmpty
1311

14-
logger = logging.getLogger()
15-
logger.level = logging.DEBUG
16-
stream_handler = logging.StreamHandler(sys.stdout)
17-
logger.addHandler(stream_handler)
1812

1913
server_name = f"test-sdk-python-{uuid.uuid4().hex[:6]}"
2014
max_retry = 10
@@ -39,14 +33,11 @@ def tearDown(self) -> None:
3933
self.instanceAPI.detach_server_volume(
4034
server_id=self._server.id, volume_id=volume.id
4135
)
42-
logger.info(f"✅ Volume {volume.id} has been detach")
4336

4437
self.blockAPI.delete_volume(volume_id=volume.id)
45-
logger.info(f"✅ Volume {volume.id} has been deleted")
4638

4739
if self._server:
4840
self.instanceAPI.delete_server(zone=self.zone, server_id=self._server.id)
49-
logger.info(f"🗑️ Deleted server: {self._server.id}")
5041

5142
def wait_test_instance_server(self, server_id):
5243
interval = interval
@@ -56,7 +47,6 @@ def wait_test_instance_server(self, server_id):
5647
s = self.instanceAPI.get_server(zone=self.zone, server_id=server_id)
5748

5849
if s.state == "running":
59-
logger.info(f"✅ Server {server_id} is running.")
6050
break
6151

6252
time.sleep(interval)
@@ -77,7 +67,6 @@ def create_test_instance_server(self) -> Server:
7767
dynamic_ip_required=True,
7868
volumes=volume,
7969
)
80-
logger.info(f"✅ Created server: {server.id}")
8170

8271
self._server = server.server
8372

@@ -92,7 +81,6 @@ def create_test_from_empty_volume(self, number) -> List[Volume]:
9281
volume = self.blockAPI.create_volume(
9382
from_empty=CreateVolumeRequestFromEmpty(size=10),
9483
)
95-
logger.info(f"✅ Created server: {volume.id}")
9684

9785
self.blockAPI.wait_for_volume(volume_id=volume.id, zone=self.zone)
9886

@@ -111,22 +99,16 @@ def test_attach_aditionnal_volume(self):
11199

112100
self.assertIsNotNone(additional_volume.id)
113101
self.assertEqual(additional_volume.size, 10)
114-
logger.info(f"✅ Volume created with ID: {additional_volume.id}")
115102

116103
self.instanceAPI.attach_server_volume(
117104
server_id=server.id, volume_id=additional_volume.id
118105
)
119106

120107
self.blockAPI.wait_for_volume(volume_id=additional_volume.id, zone=self.zone)
121108

122-
logger.info(f"🔗 Attached volume {additional_volume.id} to server {server.id}")
123-
124109
updated_server = self.instanceAPI.get_server(
125110
zone=self.zone, server_id=server.id
126111
)
127112
attached_volumes = updated_server.volumes or {}
128113
attached_volume_ids = [v.volume.id for v in attached_volumes.values()]
129114
self.assertIn(additional_volume.id, attached_volume_ids)
130-
logger.info(
131-
f"✅ Volume {additional_volume.id} is attached to server {server.id}"
132-
)

scaleway/tests/test_vpc.py

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
1-
import logging
2-
import sys
31
import unittest
42
from scaleway.vpc.v2 import VpcV2API
53
from scaleway_core.api import ScalewayException
64
from scaleway_core.client import Client
75
from scaleway_core.utils import random_name
86

9-
logger = logging.getLogger()
10-
logger.level = logging.DEBUG
11-
stream_handler = logging.StreamHandler(sys.stdout)
12-
logger.addHandler(stream_handler)
13-
147
region = "fr-par"
158
tags = ["sdk-python", "regression-test"]
169

@@ -31,17 +24,14 @@ def setUpClass(self):
3124
project_id=self.project_id,
3225
name=random_name("vpc-test-sdk-python"),
3326
)
34-
logger.info(f"✅ VPC {self._vpc.id} has been created")
3527

3628
@classmethod
3729
def tearDownClass(self):
3830
for pn in self._pns_to_cleanup:
3931
self.vpcAPI.delete_private_network(private_network_id=pn.id)
40-
logger.info(f"🧹 Deleted Private Network {pn.id}")
4132

4233
if self._vpc is not None:
4334
self.vpcAPI.delete_vpc(vpc_id=self._vpc.id, region=self.region)
44-
logger.info(f"🧹 Deleted VPC {self._vpc.id}")
4535

4636
def test_delete_vpc(self):
4737
vpc = self.vpcAPI.create_vpc(
@@ -50,20 +40,17 @@ def test_delete_vpc(self):
5040
project_id=self.project_id,
5141
name=random_name("vpc-test-sdk-python"),
5242
)
53-
logger.info(f"✅ VPC {vpc.id} has been created")
43+
5444
self.assertIsNotNone(vpc.id)
5545
self.assertEqual(vpc.region, self.region)
5646

5747
self.vpcAPI.delete_vpc(vpc_id=vpc.id)
58-
logger.info(f"🗑️ VPC {vpc.id} deletion requested")
5948

6049
with self.assertRaises(ScalewayException):
6150
self.vpcAPI.get_vpc(vpc_id=vpc.id)
62-
logger.info(f"✅ VPC {vpc.id} has been deleted successfully")
6351

6452
def test_list_vpcs(self):
6553
vpcs = self.vpcAPI.list_vp_cs(region=self.region).vpcs
66-
logger.info(f"🔎 Listed {len(vpcs)} VPC(s) in region: {self.region}")
6754
self.assertIsInstance(vpcs, list)
6855

6956
def test_create_private_network(self):
@@ -75,29 +62,26 @@ def test_create_private_network(self):
7562
name=random_name(f"pn-{i}"),
7663
)
7764
self._pns_to_cleanup.append(pn)
78-
logger.info(f"✅ PN {i + 1}/5: {pn.id} created in VPC {self._vpc.id}")
65+
7966
self.assertEqual(pn.vpc_id, self._vpc.id)
8067

8168
def test_list_private_network(self):
8269
networks = self.vpcAPI.list_private_networks(region=self.region)
83-
logger.info(
84-
f"🔎 Listed {networks.total_count} private network(s) in region: {self.region}"
85-
)
8670
self.assertIsInstance(networks.private_networks, list)
8771

8872
def test_get_vpc(self):
8973
vpc = self.vpcAPI.get_vpc(vpc_id=self._vpc.id, region=self.region)
90-
logger.info(f"📥 Retrieved VPC {vpc.id}")
74+
9175
self.assertIsNotNone(vpc)
9276
self.assertEqual(self._vpc.id, vpc.id)
9377

9478
def test_update_vpc(self):
9579
vpc = self.vpcAPI.update_vpc(vpc_id=self._vpc.id, tags=tags)
96-
logger.info(f"🛠️ Updated VPC {vpc.id} with tags: {tags}")
80+
9781
self.assertEqual(vpc.tags, tags)
9882
self.assertEqual(self._vpc.id, vpc.id)
9983

10084
def test_list_vpc_all(self):
10185
vpcs = self.vpcAPI.list_vp_cs_all()
102-
logger.info(f"📥 Retrieved total of {len(vpcs)} VPC(s) across all regions")
86+
10387
self.assertIsInstance(vpcs, list)

0 commit comments

Comments
 (0)