Skip to content

Commit c75cd1b

Browse files
committed
chore: activate tests in workflow
1 parent e8541fd commit c75cd1b

File tree

6 files changed

+44
-53
lines changed

6 files changed

+44
-53
lines changed

.github/workflows/checks.yml

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -88,34 +88,34 @@ jobs:
8888
- name: Check linting
8989
run: poetry run ruff check . --ignore E721 --ignore F541
9090

91-
# tests:
92-
# runs-on: ubuntu-latest
93-
# strategy:
94-
# matrix:
95-
# lib:
96-
# - scaleway-core
97-
# - scaleway
98-
# - scaleway-async
99-
# defaults:
100-
# run:
101-
# working-directory: ${{ matrix.lib }}
102-
# steps:
103-
# - uses: actions/checkout@v4
104-
# - name: Set up Python
105-
# uses: actions/setup-python@v5
106-
# with:
107-
# python-version: "3.10"
108-
# - name: Install poetry
109-
# run: |
110-
# pip install poetry
111-
# poetry --version
112-
# - name: Install dependencies and library
113-
# run: poetry install
114-
# - name: Run tests
115-
# run: poetry run python -m unittest discover -s tests -v
116-
# env:
117-
# SCW_ACCESS_KEY: ${{ secrets.SCW_ACCESS_KEY }}
118-
# SCW_SECRET_KEY: ${{ secrets.SCW_SECRET_KEY }}
119-
# SCW_DEFAULT_PROJECT_ID: ${{ secrets.SCW_DEFAULT_PROJECT_ID }}
120-
# SCW_DEFAULT_REGION: ${{ secrets.SCW_DEFAULT_REGION }}
121-
# SCW_DEFAULT_ZONE: ${{ secrets.SCW_DEFAULT_ZONE }}
91+
tests:
92+
runs-on: ubuntu-latest
93+
strategy:
94+
matrix:
95+
lib:
96+
- scaleway-core
97+
- scaleway
98+
- scaleway-async
99+
defaults:
100+
run:
101+
working-directory: ${{ matrix.lib }}
102+
steps:
103+
- uses: actions/checkout@v4
104+
- name: Set up Python
105+
uses: actions/setup-python@v5
106+
with:
107+
python-version: "3.10"
108+
- name: Install poetry
109+
run: |
110+
pip install poetry
111+
poetry --version
112+
- name: Install dependencies and library
113+
run: poetry install
114+
- name: Run tests
115+
run: poetry run python -m unittest discover -s tests -v
116+
env:
117+
SCW_ACCESS_KEY: ${{ secrets.SCW_ACCESS_KEY }}
118+
SCW_SECRET_KEY: ${{ secrets.SCW_SECRET_KEY }}
119+
SCW_DEFAULT_PROJECT_ID: ${{ secrets.SCW_DEFAULT_PROJECT_ID }}
120+
SCW_DEFAULT_REGION: ${{ secrets.SCW_DEFAULT_REGION }}
121+
SCW_DEFAULT_ZONE: ${{ secrets.SCW_DEFAULT_ZONE }}

scaleway-async/tests/test_test_v1.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from scaleway_async import Client, WaitForOptions
88
from scaleway_async.test.v1 import EyeColors, Human, HumanStatus, TestV1API
99

10+
1011
@unittest.skip("API test is not deployed")
1112
class TestTestV1(unittest.IsolatedAsyncioTestCase):
1213
async def asyncSetUp(self) -> None:

scaleway/tests/test_instance.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
commercial_type = "DEV1-S"
2424
zone = "fr-par-1"
2525

26+
2627
@unittest.skip("Skipping this test temporarily")
2728
class TestE2EServerCreation(unittest.TestCase):
2829
def setUp(self) -> None:

scaleway/tests/test_test_v1.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ def setUp(self) -> None:
1919
client.secret_key = res.secret_key
2020
client.default_project_id = "00000000-0000-0000-0000-000000000000"
2121

22-
2322
def test_create_human(self) -> None:
2423
name = utils.random_name()
2524

@@ -43,12 +42,10 @@ def test_list_humans(self) -> None:
4342
humans = self.api.list_humans()
4443
self.assertTrue(isinstance(humans.humans, list))
4544

46-
4745
def test_list_humans_all(self) -> None:
4846
humans = self.api.list_humans_all()
4947
self.assertTrue(isinstance(humans, list))
5048

51-
5249
def test_get_human(self) -> None:
5350
name = utils.random_name()
5451

@@ -123,7 +120,7 @@ def test_delete_human(self) -> None:
123120
except Exception as e:
124121
self.assertNotIsInstance(e, TimeoutError)
125122
pass
126-
123+
127124
def test_run_human(self) -> None:
128125
name = utils.random_name()
129126

scaleway/tests/test_test_v1_marshalling.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ def _assert_create_human_request_and_raw(
166166
self.assertEqual(request.name, raw["name"])
167167
self.assertEqual(request.shoe_size, raw["shoe_size"])
168168

169-
170169
@unittest.skip("API test is not deployed")
171170
def test_marshal_CreateHumanRequest(self) -> None:
172171
request = _mock_create_human_request()

scaleway/tests/test_vpc.py

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,22 @@
1414
region = "fr-par"
1515
tags = ["sdk-python", "regression-test"]
1616

17+
1718
class TestScalewayVPCV2(unittest.TestCase):
1819
@classmethod
1920
def setUpClass(self):
2021
self.client = Client.from_config_file_and_env()
2122
self.vpcAPI = VpcV2API(self.client)
2223
self.project_id = self.client.default_project_id
2324
self.region = region
24-
self._vpc= None
25+
self._vpc = None
2526
self._pns_to_cleanup = []
2627

2728
self._vpc = self.vpcAPI.create_vpc(
2829
enable_routing=True,
2930
region=self.region,
3031
project_id=self.project_id,
31-
name=random_name("vpc-test-sdk-python")
32+
name=random_name("vpc-test-sdk-python"),
3233
)
3334
logger.info(f"✅ VPC {self._vpc.id} has been created")
3435

@@ -47,7 +48,7 @@ def test_delete_vpc(self):
4748
enable_routing=True,
4849
region=self.region,
4950
project_id=self.project_id,
50-
name=random_name("vpc-test-sdk-python")
51+
name=random_name("vpc-test-sdk-python"),
5152
)
5253
logger.info(f"✅ VPC {vpc.id} has been created")
5354
self.assertIsNotNone(vpc.id)
@@ -71,15 +72,17 @@ def test_create_private_network(self):
7172
vpc_id=self._vpc.id,
7273
default_route_propagation_enabled=True,
7374
project_id=self.project_id,
74-
name=random_name(f"pn-{i}")
75+
name=random_name(f"pn-{i}"),
7576
)
7677
self._pns_to_cleanup.append(pn)
77-
logger.info(f"✅ PN {i+1}/5: {pn.id} created in VPC {self._vpc.id}")
78+
logger.info(f"✅ PN {i + 1}/5: {pn.id} created in VPC {self._vpc.id}")
7879
self.assertEqual(pn.vpc_id, self._vpc.id)
7980

8081
def test_list_private_network(self):
8182
networks = self.vpcAPI.list_private_networks(region=self.region)
82-
logger.info(f"🔎 Listed {networks.total_count} private network(s) in region: {self.region}")
83+
logger.info(
84+
f"🔎 Listed {networks.total_count} private network(s) in region: {self.region}"
85+
)
8386
self.assertIsInstance(networks.private_networks, list)
8487

8588
def test_get_vpc(self):
@@ -93,18 +96,8 @@ def test_update_vpc(self):
9396
logger.info(f"🛠️ Updated VPC {vpc.id} with tags: {tags}")
9497
self.assertEqual(vpc.tags, tags)
9598
self.assertEqual(self._vpc.id, vpc.id)
96-
99+
97100
def test_list_vpc_all(self):
98101
vpcs = self.vpcAPI.list_vp_cs_all()
99102
logger.info(f"📥 Retrieved total of {len(vpcs)} VPC(s) across all regions")
100103
self.assertIsInstance(vpcs, list)
101-
102-
103-
104-
105-
106-
107-
108-
109-
110-

0 commit comments

Comments
 (0)