add test

Author: jremy42

internal/services/tem/blockedlist.go

@@ -61,7 +61,7 @@ func ResourceBlockedListCreate(ctx context.Context, d *schema.ResourceData, m in
 		return diag.FromErr(err)
 	}
 
-	region, domainID, err := regional.ParseID(d.Get("domain_id").(string))
+	_, domainID, err := regional.ParseID(d.Get("domain_id").(string))
 	if err != nil {
 		return diag.FromErr(err)
 	}
@@ -70,7 +70,7 @@ func ResourceBlockedListCreate(ctx context.Context, d *schema.ResourceData, m in
 	reason := d.Get("reason").(string)
 	typeBlockedList := d.Get("type").(string)
 
-	_, err = api.BulkCreateBlocklists(&tem.BulkCreateBlocklistsRequest{
+	resp, err := api.BulkCreateBlocklists(&tem.BulkCreateBlocklistsRequest{
 		Emails:   emails,
 		Region:   region,
 		DomainID: domainID,
@@ -81,39 +81,43 @@ func ResourceBlockedListCreate(ctx context.Context, d *schema.ResourceData, m in
 		return diag.FromErr(err)
 	}
 
-	d.SetId(fmt.Sprintf("%s-%s", region, domainID))
+	d.SetId(fmt.Sprintf("%s/%s", region, resp.Blocklists[0].ID))
 
 	return ResourceBlockedListRead(ctx, d, m)
 }
 
 func ResourceBlockedListRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
-	api, region, _, err := NewAPIWithRegionAndID(m, d.Id())
+	api, region, domainID, err := NewAPIWithRegionAndID(m, d.Get("domain_id").(string))
 	if err != nil {
 		return diag.FromErr(err)
 	}
 
 	blocklists, err := api.ListBlocklists(&tem.ListBlocklistsRequest{
 		Region:   region,
 		Email:    scw.StringPtr(d.Get("email").(string)),
-		DomainID: d.Get("domain_id").(string),
+		DomainID: domainID,
 	}, scw.WithContext(ctx))
 	if err != nil {
 		if httperrors.Is404(err) {
 			d.SetId("")
+
 			return nil
 		}
+
 		return diag.FromErr(err)
 	}
 
 	if len(blocklists.Blocklists) == 0 {
 		d.SetId("")
+
 		return nil
 	}
 
 	_ = d.Set("email", blocklists.Blocklists[0].Email)
 	_ = d.Set("reason", blocklists.Blocklists[0].Reason)
-	_ = d.Set("domain_id", blocklists.Blocklists[0].DomainID)
+	_ = d.Set("domain_id", fmt.Sprintf("%s/%s", region, blocklists.Blocklists[0].DomainID))
 	_ = d.Set("type", blocklists.Blocklists[0].Type)
+
 	return nil
 }
 
@@ -130,6 +134,8 @@ func ResourceBlockedListDelete(ctx context.Context, d *schema.ResourceData, m in
 	if err != nil && !httperrors.Is404(err) {
 		return diag.FromErr(err)
 	}
+
 	d.SetId("")
+
 	return nil
 }

internal/services/tem/blockedlist_test.go

@@ -69,7 +69,6 @@ func TestAccBlockedList_Basic(t *testing.T) {
 	})
 }
 
-// Checks if the blocked email is present in Scaleway TEM API
 func isBlockedEmailPresent(tt *acctest.TestTools, n string) resource.TestCheckFunc {
 	return func(state *terraform.State) error {
 		rs, ok := state.RootModule().Resources[n]
@@ -85,11 +84,10 @@ func isBlockedEmailPresent(tt *acctest.TestTools, n string) resource.TestCheckFu
 		blockedEmail := rs.Primary.Attributes["email"]
 
 		blocklists, err := api.ListBlocklists(&temSDK.ListBlocklistsRequest{
-			Region:   scw.Region(region),
+			Region:   region,
 			DomainID: domainID,
 			Email:    scw.StringPtr(blockedEmail),
 		}, scw.WithContext(context.Background()))
-
 		if err != nil {
 			return err
 		}
@@ -102,7 +100,6 @@ func isBlockedEmailPresent(tt *acctest.TestTools, n string) resource.TestCheckFu
 	}
 }
 
-// Checks if the blocked email is properly destroyed
 func isBlockedEmailDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 	return func(state *terraform.State) error {
 		for _, rs := range state.RootModule().Resources {
@@ -118,11 +115,10 @@ func isBlockedEmailDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 			blockedEmail := rs.Primary.Attributes["email"]
 
 			blocklists, err := api.ListBlocklists(&temSDK.ListBlocklistsRequest{
-				Region:   scw.Region(region),
+				Region:   region,
 				DomainID: domainID,
 				Email:    scw.StringPtr(blockedEmail),
 			}, scw.WithContext(context.Background()))
-
 			if err != nil {
 				return err
 			}