ok except for pn detach

Author: Mia-Cross

internal/services/container/container_test.go

@@ -680,28 +680,28 @@ func TestAccContainer_PrivateNetwork(t *testing.T) {
 					resource.TestCheckResourceAttrPair("scaleway_container.c00", "private_network_id", "scaleway_vpc_private_network.pn00", "id"),
 				),
 			},
-			//{
-			//	Config: `
-			//		resource scaleway_vpc_private_network pn00 {}
-			//		resource scaleway_vpc_private_network pn01 {}
-			//
-			//		resource scaleway_container_namespace main {
-			//			activate_vpc_integration = true
-			//		}
-			//
-			//		resource scaleway_container c00 {
-			//			namespace_id = scaleway_container_namespace.main.id
-			//			private_network_id = scaleway_vpc_private_network.pn01.id
-			//			sandbox = "v1"
-			//		}
-			//	`,
-			//	Check: resource.ComposeTestCheckFunc(
-			//		isContainerPresent(tt, "scaleway_container.c00"),
-			//		resource.TestCheckResourceAttr("scaleway_container.c00", "sandbox", "v1"),
-			//		resource.TestCheckResourceAttrPair("scaleway_container.c00", "private_network_id", "scaleway_vpc_private_network.pn01", "id"),
-			//	),
-			//},
-			//{
+			{
+				Config: `
+					resource scaleway_vpc_private_network pn00 {}
+					resource scaleway_vpc_private_network pn01 {}
+			
+					resource scaleway_container_namespace main {
+						activate_vpc_integration = true
+					}
+			
+					resource scaleway_container c00 {
+						namespace_id = scaleway_container_namespace.main.id
+						private_network_id = scaleway_vpc_private_network.pn01.id
+						sandbox = "v1"
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isContainerPresent(tt, "scaleway_container.c00"),
+					resource.TestCheckResourceAttr("scaleway_container.c00", "sandbox", "v1"),
+					resource.TestCheckResourceAttrPair("scaleway_container.c00", "private_network_id", "scaleway_vpc_private_network.pn01", "id"),
+				),
+			},
+			// {
 			//	Config: `
 			//		resource scaleway_vpc_private_network pn00 {}
 			//		resource scaleway_vpc_private_network pn01 {}
@@ -712,14 +712,15 @@ func TestAccContainer_PrivateNetwork(t *testing.T) {
 			//
 			//		resource scaleway_container c00 {
 			//			namespace_id = scaleway_container_namespace.main.id
+			//			private_network_id = "00000000-0000-0000-0000-000000000000"
 			//			sandbox = "v1"
 			//		}
 			//	`,
 			//	Check: resource.ComposeTestCheckFunc(
 			//		isContainerPresent(tt, "scaleway_container.c00"),
 			//		resource.TestCheckResourceAttr("scaleway_container.c00", "private_network_id", ""),
 			//	),
-			//},
+			// },
 		},
 	})
 }

internal/services/container/helpers_container.go

@@ -275,7 +275,7 @@ func setUpdateContainerRequest(d *schema.ResourceData, region scw.Region, contai
 	}
 
 	if d.HasChanges("private_network_id") {
-		if _, newPNID := d.GetChange("private_network_id"); newPNID != nil && newPNID.(string) != "" {
+		if newPNID, ok := d.GetOk("private_network_id"); ok && newPNID.(string) != "" {
 			req.PrivateNetworkID = types.ExpandUpdatedStringPtr(locality.ExpandID(newPNID.(string)))
 		} else {
 			req.PrivateNetworkID = nil

internal/services/container/namespace_test.go

@@ -266,6 +266,7 @@ func TestAccNamespace_DestroyRegistry(t *testing.T) {
 		},
 	})
 }
+
 func TestAccNamespace_VPCIntegration(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()