fix: resolve loopvar experiment issues by capturing loop variables

Author: jremy42

internal/services/applesilicon/server.go

@@ -309,6 +309,7 @@ func ResourceAppleSiliconServerRead(ctx context.Context, d *schema.ResourceData,
 	authorized := true
 
 	for _, privateNetworkID := range privateNetworkIDs {
+		privateNetworkID := privateNetworkID // capture loop variable
 		resourceType := ipamAPI.ResourceTypeAppleSiliconPrivateNic
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType:     &resourceType,

internal/services/baremetal/server.go

@@ -551,6 +551,7 @@ func ResourceServerRead(ctx context.Context, d *schema.ResourceData, m any) diag
 	diags := diag.Diagnostics{}
 
 	for _, privateNetworkID := range privateNetworkIDs {
+		privateNetworkID := privateNetworkID // capture loop variable
 		resourceType := ipamAPI.ResourceTypeBaremetalPrivateNic
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType:     &resourceType,

internal/services/container/helpers_container.go

@@ -499,6 +499,7 @@ func filterSecretEnvsToPatch(oldEnv []*container.Secret, newEnv []*container.Sec
 
 	// delete
 	for _, env := range oldEnv {
+		env := env // capture loop variable
 		if !slices.ContainsFunc(newEnv, func(s *container.Secret) bool {
 			return s.Key == env.Key
 		}) {

internal/services/function/helpers_function.go

@@ -202,6 +202,7 @@ func filterSecretEnvsToPatch(oldEnv []*function.Secret, newEnv []*function.Secre
 
 	// delete
 	for _, env := range oldEnv {
+		env := env // capture loop variable
 		if !slices.ContainsFunc(newEnv, func(s *function.Secret) bool {
 			return s.Key == env.Key
 		}) {

internal/services/instance/server.go

@@ -897,6 +897,7 @@ You can check the full list of compatible server types:
 	}
 
 	for _, nicID := range privateNICIDs {
+		nicID := nicID // capture loop variable
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType: &resourceType,
 			ResourceID:   &nicID,

internal/services/instance/servers_data_source.go

@@ -297,6 +297,7 @@ func DataSourceInstanceServersRead(ctx context.Context, d *schema.ResourceData,
 		}
 
 		for _, nicID := range privateNICIDs {
+			nicID := nicID // capture loop variable
 			opts := &ipam.GetResourcePrivateIPsOptions{
 				ResourceType: &resourceType,
 				ResourceID:   &nicID,

internal/services/jobs/helpers.go

@@ -163,6 +163,7 @@ func CreateJobDefinitionSecret(ctx context.Context, api *jobs.API, jobSecrets []
 	secretConfigs := []*jobs.CreateJobDefinitionSecretsRequestSecretConfig{}
 
 	for _, parsedSecretRef := range jobSecrets {
+		parsedSecretRef := parsedSecretRef // capture loop variable
 		secretConfig := &jobs.CreateJobDefinitionSecretsRequestSecretConfig{}
 
 		secretConfigs = append(secretConfigs, secretConfig)
@@ -220,12 +221,14 @@ func DiffJobDefinitionSecrets(oldSecretRefs, newSecretRefs []JobDefinitionSecret
 	// hash the new and old secret sets
 	oldSecretRefsMap := make(map[int]JobDefinitionSecret, len(oldSecretRefs))
 	for _, secret := range oldSecretRefs {
+		secret := secret // capture loop variable
 		oldSecretRefsMap[hashJobDefinitionSecret(&secret)] = secret
 	}
 
 	newSecretRefsMap := make(map[int]JobDefinitionSecret, len(newSecretRefs))
 
 	for _, secret := range newSecretRefs {
+		secret := secret // capture loop variable
 		if err := validateJobDefinitionSecret(&secret); err != nil {
 			return toCreate, toDelete, err
 		}

internal/services/lb/lb.go

@@ -363,6 +363,7 @@ func resourceLbRead(ctx context.Context, d *schema.ResourceData, m any) diag.Dia
 	resourceType := ipamAPI.ResourceTypeLBServer
 
 	for _, privateNetworkID := range privateNetworkIDs {
+		privateNetworkID := privateNetworkID // capture loop variable
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType:     &resourceType,
 			PrivateNetworkID: &privateNetworkID,

internal/services/mnq/sns_topic.go

@@ -206,6 +206,8 @@ func ResourceMNQSNSTopicUpdate(ctx context.Context, d *schema.ResourceData, m an
 
 	if len(updatedAttributes) > 0 {
 		for attributeName, attributeValue := range updatedAttributes {
+			attributeName := attributeName   // capture loop variable
+			attributeValue := attributeValue // capture loop variable
 			_, err := snsClient.SetTopicAttributes(ctx, &sns.SetTopicAttributesInput{
 				AttributeName:  scw.StringPtr(attributeName),
 				AttributeValue: &attributeValue,

internal/services/object/helpers_object.go

@@ -495,6 +495,7 @@ func deleteMarkerBucket(ctx context.Context, conn *s3.Client, bucketName string,
 	var nObject int64
 
 	for _, deleteMarkerEntry := range page.DeleteMarkers {
+		deleteMarkerEntry := deleteMarkerEntry // capture loop variable
 		pool.AddTask(func() error {
 			deleteMarkerKey := aws.ToString(deleteMarkerEntry.Key)
 			deleteMarkerVersionsID := aws.ToString(deleteMarkerEntry.VersionId)
@@ -517,6 +518,7 @@ func deleteVersionBucket(ctx context.Context, conn *s3.Client, bucketName string
 	var nObject int64
 
 	for _, objectVersion := range page.Versions {
+		objectVersion := objectVersion // capture loop variable
 		pool.AddTask(func() error {
 			objectKey := aws.ToString(objectVersion.Key)
 			objectVersionID := aws.ToString(objectVersion.VersionId)