fix linting issues

Author: Gnoale

internal/services/iam/user.go

@@ -2,7 +2,7 @@ package iam
 
 import (
 	"context"
-	"fmt"
+	"errors"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -13,6 +13,8 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
 )
 
+var descParameterIgnoredForGuest = " (this parameter is ignored in case of guest users)"
+
 func ResourceUser() *schema.Resource {
 	return &schema.Resource{
 		CreateContext: resourceIamUserCreate,
@@ -40,44 +42,44 @@ func ResourceUser() *schema.Resource {
 			"send_password_email": {
 				Type:        schema.TypeBool,
 				Optional:    true,
-				Description: "Whether or not to send an email containing the member's password",
+				Description: "Whether or not to send an email containing the member's password" + descParameterIgnoredForGuest,
 			},
 			"send_welcome_email": {
 				Type:        schema.TypeBool,
 				Optional:    true,
-				Description: "Whether or not to send a welcome email that includes onboarding information",
+				Description: "Whether or not to send a welcome email that includes onboarding information" + descParameterIgnoredForGuest,
 			},
 			"username": {
 				Type:        schema.TypeString,
 				Optional:    true,
 				Computed:    true,
-				Description: "The member's username",
+				Description: "The member's username" + descParameterIgnoredForGuest,
 			},
 			"password": {
 				Type:        schema.TypeString,
 				Optional:    true,
-				Description: "The member's password for first access",
+				Description: "The member's password for first access" + descParameterIgnoredForGuest,
 			},
 			"first_name": {
 				Type:        schema.TypeString,
 				Optional:    true,
-				Description: "The member's first name",
+				Description: "The member's first name" + descParameterIgnoredForGuest,
 			},
 			"last_name": {
 				Type:        schema.TypeString,
 				Optional:    true,
-				Description: "The member's last name",
+				Description: "The member's last name" + descParameterIgnoredForGuest,
 			},
 			"phone_number": {
 				Type:        schema.TypeString,
 				Optional:    true,
-				Description: "The member's phone number",
+				Description: "The member's phone number" + descParameterIgnoredForGuest,
 			},
 			"locale": {
 				Type:        schema.TypeString,
 				Optional:    true,
 				Computed:    true,
-				Description: "The member's locale",
+				Description: "The member's locale" + descParameterIgnoredForGuest,
 			},
 			// Computed data
 			"created_at": {
@@ -161,6 +163,7 @@ func resourceIamUserCreate(ctx context.Context, d *schema.ResourceData, m interf
 	api := NewAPI(m)
 
 	var user *iam.User
+
 	var err error
 
 	if d.Get("username").(string) != "" {
@@ -186,7 +189,6 @@ func resourceIamUserRead(ctx context.Context, d *schema.ResourceData, m interfac
 	user, err := api.GetUser(&iam.GetUserRequest{
 		UserID: d.Id(),
 	}, scw.WithContext(ctx))
-
 	if err != nil {
 		if httperrors.Is404(err) {
 			d.SetId("")
@@ -241,23 +243,28 @@ func resourceIamUserUpdate(ctx context.Context, d *schema.ResourceData, m interf
 				return diag.FromErr(err)
 			}
 		}
+
 		if d.HasChange("email") {
-			return diag.FromErr(fmt.Errorf("the email of a guest user cannot be updated, you need to create a new user"))
+			return diag.FromErr(errors.New("the email of a guest user cannot be updated, you need to create a new user"))
 		}
 	} else {
-		if d.HasChanges("tags", "email", "first_name", "last_name", "phone_number", "locale") {
-			_, err = api.UpdateUser(&iam.UpdateUserRequest{
-				UserID:      user.ID,
-				Tags:        types.ExpandUpdatedStringsPtr(d.Get("tags")),
-				Email:       scw.StringPtr(d.Get("email").(string)),
-				FirstName:   scw.StringPtr(d.Get("first_name").(string)),
-				LastName:    scw.StringPtr(d.Get("last_name").(string)),
-				PhoneNumber: scw.StringPtr(d.Get("phone_number").(string)),
-				Locale:      scw.StringPtr(d.Get("locale").(string)),
-			}, scw.WithContext(ctx))
-			if err != nil {
-				return diag.FromErr(err)
-			}
+		req := &iam.UpdateUserRequest{UserID: user.ID}
+
+		if d.HasChanges("tags", "email", "first_name") {
+			req.Tags = types.ExpandUpdatedStringsPtr(d.Get("tags"))
+			req.Email = scw.StringPtr(d.Get("email").(string))
+			req.FirstName = scw.StringPtr(d.Get("first_name").(string))
+		}
+
+		if d.HasChanges("last_name", "phone_number", "locale") {
+			req.LastName = scw.StringPtr(d.Get("last_name").(string))
+			req.PhoneNumber = scw.StringPtr(d.Get("phone_number").(string))
+			req.Locale = scw.StringPtr(d.Get("locale").(string))
+		}
+
+		_, err = api.UpdateUser(req, scw.WithContext(ctx))
+		if err != nil {
+			return diag.FromErr(err)
 		}
 		// The update of the 'username' field is made through a different endpoint and payload.
 		if d.HasChange("username") {
@@ -270,6 +277,7 @@ func resourceIamUserUpdate(ctx context.Context, d *schema.ResourceData, m interf
 			}
 		}
 	}
+
 	return resourceIamUserRead(ctx, d, m)
 }