feat(function_cron): add name attribute (#2365)

Author: jremy42

docs/resources/function_cron.md

@@ -29,6 +29,7 @@ resource scaleway_function main {
 }
 
 resource scaleway_function_cron main {
+    name = "test-cron"
     function_id = scaleway_function.main.id
     schedule = "0 0 * * *"
     args = jsonencode({test = "scw"})
@@ -50,6 +51,7 @@ The following arguments are required:
 - `function_id` - (Required) The function ID to link with your cron.
 - `args`   - (Required) The key-value mapping to define arguments that will be passed to your function’s event object
   during
+- `name` - (Optional) The name of the cron. If not provided, the name is generated.
 
 ## Attributes Reference
 

scaleway/resource_function_cron.go

@@ -43,6 +43,12 @@ func resourceScalewayFunctionCron() *schema.Resource {
 				Required:    true,
 				Description: "Functions arguments as json object to pass through during execution.",
 			},
+			"name": {
+				Type:        schema.TypeString,
+				Optional:    true,
+				Computed:    true,
+				Description: "The name of the cron job.",
+			},
 			"status": {
 				Type:        schema.TypeString,
 				Computed:    true,
@@ -70,6 +76,7 @@ func resourceScalewayFunctionCronCreate(ctx context.Context, d *schema.ResourceD
 		FunctionID: f.ID,
 		Schedule:   d.Get("schedule").(string),
 		Region:     region,
+		Name:       expandStringPtr(d.Get("name")),
 	}
 
 	if args, ok := d.GetOk("args"); ok {
@@ -112,7 +119,7 @@ func resourceScalewayFunctionCronRead(ctx context.Context, d *schema.ResourceDat
 
 	_ = d.Set("function_id", newRegionalID(region, cron.FunctionID).String())
 	_ = d.Set("schedule", cron.Schedule)
-
+	_ = d.Set("name", cron.Name)
 	args, err := scw.EncodeJSONObject(*cron.Args, scw.NoEscape)
 	if err != nil {
 		return diag.FromErr(err)
@@ -139,8 +146,11 @@ func resourceScalewayFunctionCronUpdate(ctx context.Context, d *schema.ResourceD
 		Region: region,
 		CronID: cron.ID,
 	}
-
 	shouldUpdate := false
+	if d.HasChange("name") {
+		req.Name = expandStringPtr(d.Get("name").(string))
+		shouldUpdate = true
+	}
 	if d.HasChange("schedule") {
 		req.Schedule = expandStringPtr(d.Get("schedule").(string))
 		shouldUpdate = true

scaleway/resource_function_cron_test.go

@@ -69,6 +69,7 @@ func TestAccScalewayFunctionCron_Basic(t *testing.T) {
 					}
 
 					resource scaleway_function_cron main {
+						name = "tf-tests-cron-basic"
 						function_id = scaleway_function.main.id
 						schedule = "0 0 * * *"
 						args = jsonencode({})
@@ -77,6 +78,73 @@ func TestAccScalewayFunctionCron_Basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckScalewayFunctionCronExists(tt, "scaleway_function_cron.main"),
 					resource.TestCheckResourceAttr("scaleway_function_cron.main", "schedule", "0 0 * * *"),
+					resource.TestCheckResourceAttr("scaleway_function_cron.main", "name", "tf-tests-cron-basic"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccScalewayFunctionCron_NameUpdate(t *testing.T) {
+	tt := NewTestTools(t)
+	defer tt.Cleanup()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      testAccCheckScalewayFunctionCronDestroy(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource scaleway_function_namespace main {
+						name = "tf-tests-function-cron-name-update"
+					}
+
+					resource scaleway_function main {
+						name = "tf-tests-function-cron-name-update"
+						namespace_id = scaleway_function_namespace.main.id
+						runtime = "node14"
+						privacy = "private"
+						handler = "handler.handle"
+					}
+
+					resource scaleway_function_cron main {
+						name = "tf-tests-function-cron-name-update"
+						function_id = scaleway_function.main.id
+						schedule = "0 0 * * *"
+						args = jsonencode({})
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayFunctionCronExists(tt, "scaleway_function_cron.main"),
+					resource.TestCheckResourceAttr("scaleway_function_cron.main", "schedule", "0 0 * * *"),
+					resource.TestCheckResourceAttr("scaleway_function_cron.main", "name", "tf-tests-function-cron-name-update"),
+				),
+			},
+			{
+				Config: `
+					resource scaleway_function_namespace main {
+						name = "tf-tests-function-cron-name-update"
+					}
+
+					resource scaleway_function main {
+						name = "tf-tests-function-cron-name-update"
+						namespace_id = scaleway_function_namespace.main.id
+						runtime = "node14"
+						privacy = "private"
+						handler = "handler.handle"
+					}
+
+					resource scaleway_function_cron main {
+						name = "name-changed"
+						function_id = scaleway_function.main.id
+						schedule = "0 0 * * *"
+						args = jsonencode({test = "scw"})
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayFunctionCronExists(tt, "scaleway_function_cron.main"),
+					resource.TestCheckResourceAttr("scaleway_function_cron.main", "name", "name-changed"),
 				),
 			},
 		},
@@ -107,6 +175,7 @@ func TestAccScalewayFunctionCron_WithArgs(t *testing.T) {
 					}
 
 					resource scaleway_function_cron main {
+						name = "tf-tests-cron-with-args"
 						function_id = scaleway_function.main.id
 						schedule = "0 0 * * *"
 						args = jsonencode({test = "scw"})
@@ -116,6 +185,7 @@ func TestAccScalewayFunctionCron_WithArgs(t *testing.T) {
 					testAccCheckScalewayFunctionCronExists(tt, "scaleway_function_cron.main"),
 					resource.TestCheckResourceAttr("scaleway_function_cron.main", "schedule", "0 0 * * *"),
 					resource.TestCheckResourceAttr("scaleway_function_cron.main", "args", "{\"test\":\"scw\"}"),
+					resource.TestCheckResourceAttr("scaleway_function_cron.main", "name", "tf-tests-cron-with-args"),
 				),
 			},
 		},