fix(tem): resolve golangci-lint issues in tests

Author: jremy42

internal/services/tem/blockedlist_test.go

@@ -44,35 +44,3 @@ func isBlockedEmailPresent(tt *acctest.TestTools, n string) resource.TestCheckFu
 		return nil
 	}
 }
-
-func isBlockedEmailDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
-	return func(state *terraform.State) error {
-		for _, rs := range state.RootModule().Resources {
-			if rs.Type != "scaleway_tem_blocked_list" {
-				continue
-			}
-
-			api, region, domainID, err := tem.NewAPIWithRegionAndID(tt.Meta, rs.Primary.Attributes["domain_id"])
-			if err != nil {
-				return err
-			}
-
-			blockedEmail := rs.Primary.Attributes["email"]
-
-			blocklists, err := api.ListBlocklists(&temSDK.ListBlocklistsRequest{
-				Region:   region,
-				DomainID: domainID,
-				Email:    scw.StringPtr(blockedEmail),
-			}, scw.WithContext(context.Background()))
-			if err != nil {
-				return err
-			}
-
-			if len(blocklists.Blocklists) > 0 {
-				return fmt.Errorf("blocked email %s still present after deletion", blockedEmail)
-			}
-		}
-
-		return nil
-	}
-}

internal/services/tem/domain_validation.go

@@ -85,6 +85,7 @@ func ResourceDomainValidationCreate(ctx context.Context, d *schema.ResourceData,
 		if domainCheck == nil || domainCheck.Status == "pending" || domainCheck.Status == "unchecked" || domainCheck.Status == "autoconfiguring" {
 			// Sleep to avoid busy-wait loop and reduce API load
 			time.Sleep(15 * time.Second)
+
 			return retry.RetryableError(errors.New("retry"))
 		}
 

internal/services/tem/webhook_test.go

@@ -38,31 +38,3 @@ func isWebhookPresent(tt *acctest.TestTools, n string) resource.TestCheckFunc {
 		return nil
 	}
 }
-
-func isWebhookDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
-	return func(state *terraform.State) error {
-		for _, rs := range state.RootModule().Resources {
-			if rs.Type != "scaleway_tem_webhook" {
-				continue
-			}
-
-			api, region, id, err := tem.NewAPIWithRegionAndID(tt.Meta, rs.Primary.ID)
-			if err != nil {
-				return err
-			}
-
-			_, err = api.GetWebhook(&temSDK.GetWebhookRequest{
-				WebhookID: id,
-				Region:    region,
-			}, scw.WithContext(context.Background()))
-			errorCode := httperrors.Is404(err)
-			_ = errorCode
-
-			if err != nil && !httperrors.Is404(err) {
-				return err
-			}
-		}
-
-		return nil
-	}
-}