feat(instance): server: remove deprecated IP fields

Mia-Cross · Mia-Cross · commit 2424b3a0ec8a · 2025-10-17T14:09:08.000+02:00
diff --git a/docs/resources/instance_server.md b/docs/resources/instance_server.md
@@ -227,9 +227,6 @@ attached to the server. Updates to this field will trigger a stop/start of the s
 
 ~> **Important:** If this field contains local volumes, you have to first detach them, in one apply, and then delete the volume in another apply.
 
-- `enable_ipv6` - (Defaults to `false`) Determines if IPv6 is enabled for the server.
-  Deprecated: Please use a scaleway_instance_ip with a `routed_ipv6` type.
-
 - `ip_id` - (Optional) The ID of the reserved IP that is attached to the server.
 
 - `ip_ids` - (Optional) List of ID of reserved IPs that are attached to the server. Cannot be used with `ip_id`.
@@ -302,12 +299,6 @@ In addition to all arguments above, the following attributes are exported:
     - `family` - The IP address' family.
     - `dynamic` - Whether the IP is dynamic.
     - `provisioning_mode` - The provisioning mode of the IP
-- `ipv6_address` - The default ipv6 address routed to the server. ( Only set when enable_ipv6 is set to true )
-  Deprecated: Please use a scaleway_instance_ip with a `routed_ipv6` type.
-- `ipv6_gateway` - The ipv6 gateway address. ( Only set when enable_ipv6 is set to true )
-  Deprecated: Please use a scaleway_instance_ip with a `routed_ipv6` type.
-- `ipv6_prefix_length` - The prefix length of the ipv6 subnet routed to the server. ( Only set when enable_ipv6 is set to true )
-  Deprecated: Please use a scaleway_instance_ip with a `routed_ipv6` type.
 - `boot_type` - The boot Type of the server. Possible values are: `local`, `bootscript` or `rescue`.
 - `organization_id` - The organization ID the server is associated with.
 
diff --git a/internal/services/instance/ip_test.go b/internal/services/instance/ip_test.go
@@ -134,8 +134,8 @@ func TestAccIP_RoutedIPV6_Attached(t *testing.T) {
 	defer tt.Cleanup()
 
 	resource.ParallelTest(t, resource.TestCase{
-		ProviderFactories: tt.ProviderFactories,
-		CheckDestroy:      instancechecks.IsIPDestroyed(tt),
+		ProtoV6ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:             instancechecks.IsIPDestroyed(tt),
 		Steps: []resource.TestStep{
 			{
 				Config: `
diff --git a/internal/services/instance/server.go b/internal/services/instance/server.go
@@ -192,25 +192,6 @@ func ResourceServer() *schema.Resource {
 				Optional:    true,
 				Description: "The additional volumes attached to the server",
 			},
-			"enable_ipv6": {
-				Type:        schema.TypeBool,
-				Optional:    true,
-				Default:     false,
-				Description: "Determines if IPv6 is enabled for the server",
-				Deprecated:  "Please use a scaleway_instance_ip with a `routed_ipv6` type",
-			},
-			"private_ip": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Description: "The Scaleway internal IP address of the server",
-				Deprecated:  "Use ipam_ip datasource instead to fetch your server's IP in your private network.",
-			},
-			"public_ip": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Description: "The public IPv4 address of the server",
-				Deprecated:  "Use public_ips instead",
-			},
 			"ip_id": {
 				Type:             schema.TypeString,
 				Optional:         true,
@@ -229,24 +210,6 @@ func ResourceServer() *schema.Resource {
 					DiffSuppressFunc: dsf.Locality,
 				},
 			},
-			"ipv6_address": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Description: "The default public IPv6 address routed to the server.",
-				Deprecated:  "Please use a scaleway_instance_ip with a `routed_ipv6` type",
-			},
-			"ipv6_gateway": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Description: "The IPv6 gateway address",
-				Deprecated:  "Please use a scaleway_instance_ip with a `routed_ipv6` type",
-			},
-			"ipv6_prefix_length": {
-				Type:        schema.TypeInt,
-				Computed:    true,
-				Deprecated:  "Please use a scaleway_instance_ip with a `routed_ipv6` type",
-				Description: "The IPv6 prefix length routed to the server.",
-			},
 			"enable_dynamic_ip": {
 				Type:        schema.TypeBool,
 				Optional:    true,
@@ -449,21 +412,14 @@ func ResourceInstanceServerCreate(ctx context.Context, d *schema.ResourceData, m
 		Protected:         d.Get("protected").(bool),
 	}
 
-	enableIPv6, ok := d.GetOk("enable_ipv6")
-	if ok {
-		req.EnableIPv6 = scw.BoolPtr(enableIPv6.(bool)) //nolint:staticcheck
-	}
-
 	if bootType, ok := d.GetOk("boot_type"); ok {
 		bootType := instanceSDK.BootType(bootType.(string))
 		req.BootType = &bootType
 	}
 
 	if ipID, ok := d.GetOk("ip_id"); ok {
-		req.PublicIP = types.ExpandStringPtr(zonal.ExpandID(ipID).ID) //nolint:staticcheck
-	}
-
-	if ipIDs, ok := d.GetOk("ip_ids"); ok {
+		req.PublicIPs = &[]string{zonal.ExpandID(ipID).ID}
+	} else if ipIDs, ok := d.GetOk("ip_ids"); ok {
 		req.PublicIPs = types.ExpandSliceIDsPtr(ipIDs)
 	}
 
@@ -680,8 +636,6 @@ func ResourceInstanceServerRead(ctx context.Context, d *schema.ResourceData, m a
 	}
 
 	_ = d.Set("security_group_id", zonal.NewID(zone, server.SecurityGroup.ID).String())
-	// EnableIPv6 is deprecated
-	_ = d.Set("enable_ipv6", server.EnableIPv6) //nolint:staticcheck
 	_ = d.Set("enable_dynamic_ip", server.DynamicIPRequired)
 	_ = d.Set("organization_id", server.Organization)
 	_ = d.Set("project_id", server.Project)
@@ -698,35 +652,26 @@ func ResourceInstanceServerRead(ctx context.Context, d *schema.ResourceData, m a
 		_ = d.Set("placement_group_policy_respected", server.PlacementGroup.PolicyRespected)
 	}
 
-	if server.PrivateIP != nil {
-		_ = d.Set("private_ip", types.FlattenStringPtr(server.PrivateIP))
-	}
-
-	if _, hasIPID := d.GetOk("ip_id"); server.PublicIP != nil && hasIPID { //nolint:staticcheck
-		if !server.PublicIP.Dynamic { //nolint:staticcheck
-			_ = d.Set("ip_id", zonal.NewID(zone, server.PublicIP.ID).String()) //nolint:staticcheck
+	if ipID, hasIPID := d.GetOk("ip_id"); hasIPID {
+		publicIP := FindIPInList(ipID.(string), server.PublicIPs)
+		if publicIP != nil && !publicIP.Dynamic {
+			_ = d.Set("ip_id", zonal.NewID(zone, publicIP.ID).String())
 		} else {
 			_ = d.Set("ip_id", "")
 		}
 	} else {
 		_ = d.Set("ip_id", "")
 	}
 
-	if server.PublicIP != nil { //nolint:staticcheck
-		_ = d.Set("public_ip", server.PublicIP.Address.String()) //nolint:staticcheck
+	if len(server.PublicIPs) > 0 {
+		_ = d.Set("public_ips", flattenServerPublicIPs(server.Zone, server.PublicIPs))
 		d.SetConnInfo(map[string]string{
 			"type": "ssh",
-			"host": server.PublicIP.Address.String(), //nolint:staticcheck
+			"host": server.PublicIPs[0].Address.String(),
 		})
-	} else {
-		_ = d.Set("public_ip", "")
-		d.SetConnInfo(nil)
-	}
-
-	if len(server.PublicIPs) > 0 {
-		_ = d.Set("public_ips", flattenServerPublicIPs(server.Zone, server.PublicIPs))
 	} else {
 		_ = d.Set("public_ips", []any{})
+		d.SetConnInfo(nil)
 	}
 
 	if _, hasIPIDs := d.GetOk("ip_ids"); hasIPIDs {
@@ -735,22 +680,6 @@ func ResourceInstanceServerRead(ctx context.Context, d *schema.ResourceData, m a
 		_ = d.Set("ip_ids", []any{})
 	}
 
-	if server.IPv6 != nil { //nolint:staticcheck
-		_ = d.Set("ipv6_address", server.IPv6.Address.String()) //nolint:staticcheck
-		_ = d.Set("ipv6_gateway", server.IPv6.Gateway.String()) //nolint:staticcheck
-
-		prefixLength, err := strconv.Atoi(server.IPv6.Netmask) //nolint:staticcheck
-		if err != nil {
-			return diag.FromErr(err)
-		}
-
-		_ = d.Set("ipv6_prefix_length", prefixLength)
-	} else {
-		_ = d.Set("ipv6_address", nil)
-		_ = d.Set("ipv6_gateway", nil)
-		_ = d.Set("ipv6_prefix_length", nil)
-	}
-
 	if server.AdminPasswordEncryptionSSHKeyID != nil {
 		_ = d.Set("admin_password_encryption_ssh_key_id", server.AdminPasswordEncryptionSSHKeyID)
 	}
@@ -973,11 +902,6 @@ func ResourceInstanceServerUpdate(ctx context.Context, d *schema.ResourceData, m
 		}
 	}
 
-	if d.HasChange("enable_ipv6") {
-		serverShouldUpdate = true
-		updateRequest.EnableIPv6 = scw.BoolPtr(d.Get("enable_ipv6").(bool))
-	}
-
 	if d.HasChange("enable_dynamic_ip") {
 		serverShouldUpdate = true
 		updateRequest.DynamicIPRequired = scw.BoolPtr(d.Get("enable_dynamic_ip").(bool))
@@ -1022,53 +946,21 @@ func ResourceInstanceServerUpdate(ctx context.Context, d *schema.ResourceData, m
 	// Update reserved IP
 	////
 	if d.HasChange("ip_id") && !instanceIPHasMigrated(d) {
-		server, err := waitForServer(ctx, api.API, zone, id, d.Timeout(schema.TimeoutUpdate))
-		if err != nil {
-			return diag.FromErr(err)
-		}
-
 		ipID := zonal.ExpandID(d.Get("ip_id")).ID
-		// If an IP is already attached, and it's not a dynamic IP we detach it.
-		if server.PublicIP != nil && !server.PublicIP.Dynamic { //nolint:staticcheck
-			_, err = api.UpdateIP(&instanceSDK.UpdateIPRequest{
-				Zone:   zone,
-				IP:     server.PublicIP.ID, //nolint:staticcheck
-				Server: &instanceSDK.NullableStringValue{Null: true},
-			})
-			if err != nil {
-				return diag.FromErr(err)
-			}
-			// we wait to ensure to not detach the new ip.
-			_, err := waitForServer(ctx, api.API, zone, id, d.Timeout(schema.TimeoutUpdate))
-			if err != nil {
-				return diag.FromErr(err)
-			}
-		}
-		// If a new IP is provided, we attach it to the server
-		if ipID != "" {
-			_, err := waitForServer(ctx, api.API, zone, id, d.Timeout(schema.TimeoutUpdate))
-			if err != nil {
-				return diag.FromErr(err)
-			}
-
-			_, err = api.UpdateIP(&instanceSDK.UpdateIPRequest{
-				Zone:   zone,
-				IP:     ipID,
-				Server: &instanceSDK.NullableStringValue{Value: id},
-			}, scw.WithContext(ctx))
-			if err != nil {
-				return diag.FromErr(err)
-			}
-
-			_, err = waitForServer(ctx, api.API, zone, id, d.Timeout(schema.TimeoutUpdate))
+		if ipID == "" {
+			emptyIPList := make([]string, 0)
+			updateRequest.PublicIPs = &emptyIPList
+			serverShouldUpdate = true
+		} else {
+			err := ResourceInstanceServerUpdateIPs(ctx, d, api.API, zone, id, "ip_id")
 			if err != nil {
 				return diag.FromErr(err)
 			}
 		}
 	}
 
 	if d.HasChange("ip_ids") {
-		err := ResourceInstanceServerUpdateIPs(ctx, d, api.API, zone, id)
+		err := ResourceInstanceServerUpdateIPs(ctx, d, api.API, zone, id, "ip_ids")
 		if err != nil {
 			return diag.FromErr(err)
 		}
@@ -1535,13 +1427,22 @@ func ResourceInstanceServerMigrate(ctx context.Context, d *schema.ResourceData,
 	return nil
 }
 
-func ResourceInstanceServerUpdateIPs(ctx context.Context, d *schema.ResourceData, instanceAPI *instanceSDK.API, zone scw.Zone, id string) error {
+func ResourceInstanceServerUpdateIPs(ctx context.Context, d *schema.ResourceData, instanceAPI *instanceSDK.API, zone scw.Zone, id string, attribute string) error {
 	server, err := waitForServer(ctx, instanceAPI, zone, id, d.Timeout(schema.TimeoutUpdate))
 	if err != nil {
 		return err
 	}
 
-	schemaIPs := d.Get("ip_ids").([]any)
+	var schemaIPs []any
+
+	switch attribute {
+	case "ip_id":
+		schemaIP := d.Get(attribute).(string)
+		schemaIPs = append(schemaIPs, schemaIP)
+	case "ip_ids":
+		schemaIPs = d.Get(attribute).([]any)
+	}
+
 	requestedIPs := make(map[string]bool, len(schemaIPs))
 
 	// Gather request IPs in a map
diff --git a/internal/services/instance/server_test.go b/internal/services/instance/server_test.go
@@ -786,9 +786,6 @@ func TestAccServer_Ipv6(t *testing.T) {
 				`,
 				Check: resource.ComposeTestCheckFunc(
 					isServerPresent(tt, "scaleway_instance_server.server01"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.server01", "ipv6_address", ""),
-					resource.TestCheckResourceAttr("scaleway_instance_server.server01", "ipv6_gateway", ""),
-					resource.TestCheckResourceAttr("scaleway_instance_server.server01", "ipv6_prefix_length", "0"),
 					resource.TestCheckResourceAttr("scaleway_instance_server.server01", "public_ips.#", "0"),
 				),
 			},
@@ -848,7 +845,7 @@ func TestAccServer_WithReservedIP(t *testing.T) {
 				`,
 				Check: resource.ComposeTestCheckFunc(
 					isServerPresent(tt, "scaleway_instance_server.base"),
-					resource.TestCheckResourceAttrPair("scaleway_instance_ip.first", "address", "scaleway_instance_server.base", "public_ip"), // public_ip is deprecated
+					resource.TestCheckResourceAttrPair("scaleway_instance_ip.first", "address", "scaleway_instance_server.base", "public_ips.0.address"),
 					resource.TestCheckResourceAttrPair("scaleway_instance_ip.first", "id", "scaleway_instance_server.base", "ip_id"),
 				),
 			},
@@ -866,7 +863,7 @@ func TestAccServer_WithReservedIP(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					isServerPresent(tt, "scaleway_instance_server.base"),
 					isIPAttachedToServer(tt, "scaleway_instance_ip.second", "scaleway_instance_server.base"),
-					resource.TestCheckResourceAttrPair("scaleway_instance_ip.second", "address", "scaleway_instance_server.base", "public_ip"),
+					resource.TestCheckResourceAttrPair("scaleway_instance_ip.second", "address", "scaleway_instance_server.base", "public_ips.0.address"),
 					resource.TestCheckResourceAttrPair("scaleway_instance_ip.second", "id", "scaleway_instance_server.base", "ip_id"),
 				),
 			},
@@ -883,7 +880,7 @@ func TestAccServer_WithReservedIP(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					isServerPresent(tt, "scaleway_instance_server.base"),
 					serverHasNoIPAssigned(tt, "scaleway_instance_server.base"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base", "public_ip", ""),
+					resource.TestCheckResourceAttr("scaleway_instance_server.base", "public_ips.#", "0"),
 					resource.TestCheckResourceAttr("scaleway_instance_server.base", "ip_id", ""),
 				),
 			},
@@ -901,7 +898,7 @@ func TestAccServer_WithReservedIP(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					isServerPresent(tt, "scaleway_instance_server.base"),
 					serverHasNoIPAssigned(tt, "scaleway_instance_server.base"),
-					acctest.CheckResourceAttrIPv4("scaleway_instance_server.base", "public_ip"),
+					acctest.CheckResourceAttrIPv4("scaleway_instance_server.base", "public_ips.0.address"),
 					resource.TestCheckResourceAttr("scaleway_instance_server.base", "ip_id", ""),
 				),
 			},
@@ -983,7 +980,7 @@ func serverHasNewVolume(_ *acctest.TestTools, n string) resource.TestCheckFunc {
 
 		rootVolumeName, ok := rs.Primary.Attributes["root_volume.0.name"]
 		if !ok {
-			return errors.New("instanceSDK root_volume has no name")
+			return errors.New("instance root_volume has no name")
 		}
 
 		if strings.HasPrefix(rootVolumeName, "tf") {
@@ -1638,7 +1635,6 @@ func TestAccServer_IPRemoved(t *testing.T) {
 					arePrivateNICsPresent(tt, "scaleway_instance_server.main"),
 					resource.TestCheckResourceAttr("scaleway_instance_server.main", "public_ips.#", "1"),
 					resource.TestCheckResourceAttrPair("scaleway_instance_server.main", "public_ips.0.id", "scaleway_instance_ip.main", "id"),
-					resource.TestCheckResourceAttrPair("scaleway_instance_server.main", "public_ips.0.address", "scaleway_instance_server.main", "public_ip"),
 				),
 			},
 			{
diff --git a/internal/services/instance/servers_data_source.go b/internal/services/instance/servers_data_source.go
diff --git a/templates/resources/instance_server.md.tmpl b/templates/resources/instance_server.md.tmpl
