fix(file): rename attribut size to size_in_gb

Author: Laure-di

docs/resources/file_filesystem.md

@@ -16,14 +16,14 @@ This resource allows you to define and manage the size, tags, and region of a fi
 ```terraform
 resource scaleway_file_filesystem file {
   name = "my-nfs-filesystem"
-  size = 100000000000 # 100 GB
+  size_in_gb = 100000000000 # 100 GB
 }
 ```
 
 ## Argument Reference
 
 - `name` - (Optional) The name of the filesystem. If not provided, a random name will be generated.
-- `size` - (Required) The size of the filesystem in bytes, with a granularity of 100 GB (10¹¹ bytes).
+- `size_in_gb` - (Required) The size of the filesystem in bytes, with a granularity of 100 GB (10¹¹ bytes).
       - Minimum: 100 GB (100000000000 bytes)
       - Maximum: 10 TB (10000000000000 bytes)
 - `tags` - (Optional) A list of tags associated with the filesystem.

docs/resources/instance_server.md

@@ -55,7 +55,7 @@ resource scaleway_block_volume volume {
 
 resource scaleway_file_filesystem terraform_instance_filesystem {
   name = "filesystem-instance-terraform"
-  size = 100000000000
+  size_in_gb = 100000000000
 }
 
 resource scaleway_instance_server base {

internal/services/file/filesystem.go

@@ -37,10 +37,10 @@ func ResourceFileSystem() *schema.Resource {
 				Optional:    true,
 				Description: "The name of the filesystem",
 			},
-			"size": {
+			"size_in_gb": {
 				Type:        schema.TypeInt,
 				Required:    true,
-				Description: "The Filesystem size in bytes, with a granularity of 100 GB (10^11 bytes). Must be compliant with the minimum (100 GB) and maximum (10 TB) allowed size.",
+				Description: "The Filesystem size_in_gb in bytes, with a granularity of 100 GB (10^11 bytes). Must be compliant with the minimum (100 GB) and maximum (10 TB) allowed size_in_gb.",
 			},
 			"tags": {
 				Type: schema.TypeList,
@@ -87,7 +87,7 @@ func ResourceFileSystemCreate(ctx context.Context, d *schema.ResourceData, m any
 		Region:    region,
 		Name:      types.ExpandOrGenerateString(d.Get("name").(string), "file"),
 		ProjectID: d.Get("project_id").(string),
-		Size:      *types.ExpandUint64Ptr(d.Get("size")),
+		Size:      *types.ExpandUint64Ptr(d.Get("size_in_gb")),
 		Tags:      types.ExpandStrings(d.Get("tags")),
 	}
 
@@ -128,7 +128,7 @@ func ResourceFileSystemRead(ctx context.Context, d *schema.ResourceData, m any)
 	_ = d.Set("region", fileSystem.Region)
 	_ = d.Set("organization_id", fileSystem.OrganizationID)
 	_ = d.Set("status", fileSystem.Status)
-	_ = d.Set("size", int64(fileSystem.Size))
+	_ = d.Set("size_in_gb", int64(fileSystem.Size))
 	_ = d.Set("tags", fileSystem.Tags)
 	_ = d.Set("created_at", fileSystem.CreatedAt.Format(time.RFC3339))
 	_ = d.Set("updated_at", fileSystem.UpdatedAt.Format(time.RFC3339))
@@ -163,8 +163,8 @@ func ResourceFileSystemUpdate(ctx context.Context, d *schema.ResourceData, m any
 		req.Name = types.ExpandUpdatedStringPtr(d.Get("name"))
 	}
 
-	if d.HasChange("size") {
-		req.Size = types.ExpandUint64Ptr(d.Get("size"))
+	if d.HasChange("size_in_gb_in_gb") {
+		req.Size = types.ExpandUint64Ptr(d.Get("size_in_gb"))
 	}
 
 	if d.HasChange("tags") {

internal/services/file/filesystem_test.go

@@ -20,7 +20,7 @@ func TestAccFileSystem_Basic(t *testing.T) {
 
 	fileSystemName := "TestAccFileSystem_Basic"
 	fileSystemNameUpdated := "TestAccFileSystem_BasicUpdate"
-	size := int64(100_000_000_000)
+	sizeInGB := int64(100_000_000_000)
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
@@ -31,25 +31,25 @@ func TestAccFileSystem_Basic(t *testing.T) {
 				Config: fmt.Sprintf(`
 					resource "scaleway_file_filesystem" "fs" {
 						name = "%s"
-						size = %d
+						size_in_gb = %d
 					}
-				`, fileSystemName, size),
+				`, fileSystemName, sizeInGB),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckFileSystemExists(tt, "scaleway_file_filesystem.fs"),
 					resource.TestCheckResourceAttr("scaleway_file_filesystem.fs", "name", fileSystemName),
-					resource.TestCheckResourceAttr("scaleway_file_filesystem.fs", "size", strconv.FormatInt(size, 10)),
+					resource.TestCheckResourceAttr("scaleway_file_filesystem.fs", "size_in_gb", strconv.FormatInt(sizeInGB, 10)),
 				),
 			},
 			{
 				Config: fmt.Sprintf(`
 					resource "scaleway_file_filesystem" "fs" {
 						name = "%s"
-						size = %d
+						size_in_gb = %d
 					}
-				`, fileSystemNameUpdated, size),
+				`, fileSystemNameUpdated, sizeInGB),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckFileSystemExists(tt, "scaleway_file_filesystem.fs"),
-					resource.TestCheckResourceAttr("scaleway_file_filesystem.fs", "size", strconv.FormatInt(size, 10)),
+					resource.TestCheckResourceAttr("scaleway_file_filesystem.fs", "size_in_gb", strconv.FormatInt(sizeInGB, 10)),
 				),
 			},
 		},
@@ -61,7 +61,7 @@ func TestAccFileSystem_SizeTooSmallFails(t *testing.T) {
 	defer tt.Cleanup()
 
 	fileSystemName := "TestAccFileSystem_SizeTooSmallFails"
-	size := int64(10_000_000_000)
+	sizeInGB := int64(10_000_000_000)
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
@@ -72,9 +72,9 @@ func TestAccFileSystem_SizeTooSmallFails(t *testing.T) {
 				Config: fmt.Sprintf(`
 					resource "scaleway_file_filesystem" "fs" {
 						name = "%s"
-						size = %d
+						size_in_gb = %d
 					}
-				`, fileSystemName, size),
+				`, fileSystemName, sizeInGB),
 				ExpectError: regexp.MustCompile("size must be greater or equal to 100000000000"),
 			},
 		},
@@ -86,7 +86,7 @@ func TestAccFileSystem_InvalidSizeGranularityFails(t *testing.T) {
 	defer tt.Cleanup()
 
 	fileSystemName := "TestAccFileSystem_InvalidSizeGranularityFails"
-	size := int64(25_000_000_000)
+	sizeInGB := int64(25_000_000_000)
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
@@ -97,10 +97,10 @@ func TestAccFileSystem_InvalidSizeGranularityFails(t *testing.T) {
 				Config: fmt.Sprintf(`
 					resource "scaleway_file_filesystem" "fs" {
 						name = "%s"
-						size = %d
+						size_in_gb = %d
 					}
-				`, fileSystemName, size),
-				ExpectError: regexp.MustCompile("size must be greater or equal to 100000000000"),
+				`, fileSystemName, sizeInGB),
+				ExpectError: regexp.MustCompile("size_in_gb must be greater or equal to 100000000000"),
 			},
 		},
 	})