test(mongodb): harden destroy checks with RetryContext

Author: yfodil

internal/services/mongodb/instance_test.go

@@ -1,10 +1,13 @@
 package mongodb_test
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"testing"
+	"time"
 
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	mongodbSDK "github.com/scaleway/scaleway-sdk-go/api/mongodb/v1"
@@ -497,30 +500,35 @@ func isMongoDBInstancePresent(tt *acctest.TestTools, n string) resource.TestChec
 
 func IsInstanceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 	return func(state *terraform.State) error {
-		for _, rs := range state.RootModule().Resources {
-			if rs.Type != "scaleway_mongodb_instance" {
-				continue
-			}
-
-			mongodbAPI, extractRegion, ID, err := mongodb.NewAPIWithRegionAndID(tt.Meta, rs.Primary.ID)
-			if err != nil {
-				return err
-			}
+		ctx := context.Background()
 
-			_, err = mongodbAPI.GetInstance(&mongodbSDK.GetInstanceRequest{
-				InstanceID: ID,
-				Region:     extractRegion,
-			})
+		return retry.RetryContext(ctx, 3*time.Minute, func() *retry.RetryError {
+			for _, rs := range state.RootModule().Resources {
+				if rs.Type != "scaleway_mongodb_instance" {
+					continue
+				}
 
-			if err == nil {
-				return fmt.Errorf("instance (%s) still exists", rs.Primary.ID)
-			}
+				api, region, id, err := mongodb.NewAPIWithRegionAndID(tt.Meta, rs.Primary.ID)
+				if err != nil {
+					return retry.NonRetryableError(err)
+				}
 
-			if !httperrors.Is404(err) {
-				return err
+				_, err = api.GetInstance(&mongodbSDK.GetInstanceRequest{
+					InstanceID: id,
+					Region:     region,
+				})
+
+				switch {
+				case err == nil:
+					return retry.RetryableError(fmt.Errorf("mongodb instance (%s) still exists", rs.Primary.ID))
+				case httperrors.Is404(err):
+					continue
+				default:
+					return retry.NonRetryableError(err)
+				}
 			}
-		}
 
-		return nil
+			return nil
+		})
 	}
 }