fix flaky test TestAccImage_ServerWithLocalVolume

Author: Mia-Cross

internal/services/instance/image_test.go

@@ -458,6 +458,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 			{
 				Config: `
 					resource "scaleway_instance_server" "server01" {
+						name    = "root-vol0"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
@@ -466,6 +467,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 						}
 					}
 					resource "scaleway_instance_server" "server02" {
+						name    = "add-vol1"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
@@ -474,10 +476,11 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 						}
 					}
 					resource "scaleway_instance_server" "server03" {
+						name    = "add-vol2"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
-							size_in_gb = 10
+							size_in_gb = 20
 							volume_type = "l_ssd"
 						}
 					}
@@ -504,6 +507,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 			{
 				Config: `
 					resource "scaleway_instance_server" "server01" {
+						name    = "root-vol0"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
@@ -512,6 +516,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 						}
 					}
 					resource "scaleway_instance_server" "server02" {
+						name    = "add-vol1"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
@@ -520,10 +525,11 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 						}
 					}
 					resource "scaleway_instance_server" "server03" {
+						name    = "add-vol2"
 						image	= "ubuntu_focal"
 						type 	= "DEV1-S"
 						root_volume {
-							size_in_gb = 10
+							size_in_gb = 20
 							volume_type = "l_ssd"
 						}
 					}
@@ -552,12 +558,12 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) {
 					isSnapshotPresent(tt, "scaleway_instance_snapshot.local03"),
 					instancechecks.DoesImageExists(tt, "scaleway_instance_image.main"),
 					resource.TestCheckResourceAttrPair("scaleway_instance_image.main", "root_volume_id", "scaleway_instance_snapshot.local01", "id"),
-					resource.TestCheckResourceAttrPair("scaleway_instance_image.main", "additional_volumes.1.id", "scaleway_instance_snapshot.local02", "id"),
-					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.1.volume_type", "l_ssd"),
-					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.1.size", "10000000000"),
-					resource.TestCheckResourceAttrPair("scaleway_instance_image.main", "additional_volumes.0.id", "scaleway_instance_snapshot.local03", "id"),
 					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.0.volume_type", "l_ssd"),
 					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.0.size", "10000000000"),
+					resource.TestCheckResourceAttrPair("scaleway_instance_image.main", "additional_volumes.0.id", "scaleway_instance_snapshot.local02", "id"),
+					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.1.volume_type", "l_ssd"),
+					resource.TestCheckResourceAttr("scaleway_instance_image.main", "additional_volumes.1.size", "20000000000"),
+					resource.TestCheckResourceAttrPair("scaleway_instance_image.main", "additional_volumes.1.id", "scaleway_instance_snapshot.local03", "id"),
 				),
 			},
 		},