remove comment

Author: Laure-di

docs/resources/inference_custom_model.md

@@ -51,6 +51,8 @@ resource "scaleway_inference_deployment" "main" {
 
 ## Attributes Reference
 
+In addition to all arguments above, the following attributes are exported:
+
 - `id` - The unique identifier of the custom model.
 - `tags` - Tags associated with the model.
 - `status` - The current status of the model (e.g., ready, error, etc.).

internal/services/inference/custom_model.go

@@ -3,6 +3,7 @@ package inference
 import (
 	"context"
 	"fmt"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/scaleway/scaleway-sdk-go/api/inference/v1"
@@ -169,6 +170,7 @@ func ResourceCustomModelCreate(ctx context.Context, d *schema.ResourceData, m in
 
 	if model.Status == inference.ModelStatusError {
 		errMsg := *model.ErrorMessage
+
 		return diag.FromErr(fmt.Errorf("model '%s' is in status '%s'", model.ID, errMsg))
 	}
 
@@ -177,7 +179,6 @@ func ResourceCustomModelCreate(ctx context.Context, d *schema.ResourceData, m in
 
 func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
 	api, region, id, err := NewAPIWithRegionAndID(m, d.Id())
-
 	if err != nil {
 		return diag.FromErr(err)
 	}
@@ -193,8 +194,8 @@ func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m inte
 		return diag.FromErr(err)
 	}
 
-	_ = d.Set("parameter_size_bits", model.ParameterSizeBits)
-	_ = d.Set("size_bits", model.SizeBytes)
+	_ = d.Set("parameter_size_bits", int32(model.ParameterSizeBits))
+	_ = d.Set("size_bits", int64(model.SizeBytes))
 	_ = d.Set("name", model.Name)
 	_ = d.Set("status", model.Status)
 	_ = d.Set("description", model.Description)

internal/services/inference/custom_model_test.go

@@ -2,14 +2,14 @@ package inference_test
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	inferenceSDK "github.com/scaleway/scaleway-sdk-go/api/inference/v1"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/acctest"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/inference"
 	inferencetestfuncs "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/inference/testfuncs"
-	"regexp"
-	"testing"
 )
 
 const (
@@ -44,29 +44,6 @@ func TestAccCustomModel_Basic(t *testing.T) {
 	})
 }
 
-func TestAccCustomModel_NotCompatible(t *testing.T) {
-	tt := acctest.NewTestTools(t)
-	defer tt.Cleanup()
-
-	modelName := "TestAccCustomModel_NotCompatible"
-
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:          func() { acctest.PreCheck(t) },
-		ProviderFactories: tt.ProviderFactories,
-		CheckDestroy:      inferencetestfuncs.IsCustomModelDestroyed(tt),
-		Steps: []resource.TestStep{
-			{
-				Config: fmt.Sprintf(`
-					resource "scaleway_inference_custom_model" "test" {
-						name = "%s"
-						url = "%s"
-					}`, modelName, modelURLNotCompatible),
-				ExpectError: regexp.MustCompile("scaleway-sdk-go: precondition failed: , the model with ID 'google/gemma-3-4b-it' is not supported. access to model google/gemma-3-4b-it is restricted. Check your permissions to access the repository at https://huggingface.co/google/gemma-3-4b-it and ensure your credentials are valid Please visit https://www.scaleway.com/en/docs/ai-data/managed-inference/reference-content/supported-models for more details about the supported models."),
-			},
-		},
-	})
-}
-
 func TestAccCustomModel_DeployModelOnServer(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
@@ -122,6 +99,7 @@ func testAccCheckCustomModelExists(tt *acctest.TestTools, n string) resource.Tes
 		if err != nil {
 			return err
 		}
+
 		return nil
 	}
 }

internal/services/inference/deployment.go

@@ -56,17 +56,17 @@ func ResourceDeployment() *schema.Resource {
 				Required:    true,
 				Description: "The model id used for the deployment",
 				ForceNew:    true,
-				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
-					if old == "" || new == "" {
+				DiffSuppressFunc: func(k, old, newValue string, d *schema.ResourceData) bool {
+					if old == "" || newValue == "" {
 						return false
 					}
-					if !scwvalidation.IsUUID(new) {
-						newID := regional.ExpandID(new).ID
+					if !scwvalidation.IsUUID(newValue) {
+						newID := regional.ExpandID(newValue).ID
 
 						return old == newID
 					}
 
-					return old == new
+					return old == newValue
 				},
 			},
 			"accept_eula": {

internal/services/inference/testdata/custom-model-deploy-model-on-server-update.cassette.yaml

@@ -66,7 +66,7 @@ func IsCustomModelDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 				return err
 			}
 		}
-		
+
 		return nil
 	}
 }

internal/services/inference/testdata/custom-model-not-compatible.cassette.yaml

@@ -31,7 +31,7 @@ func waitForModel(ctx context.Context, inferenceAPI *inference.API, region scw.R
 		retryInterval = *transport.DefaultWaitRetryInterval
 	}
 
-	model, err := inferenceAPI.WaitForCustomModel(inference.WaitForCustomModelRequest{ //TODO add pointer
+	model, err := inferenceAPI.WaitForCustomModel(inference.WaitForCustomModelRequest{
 		ModelID:       id,
 		Region:        region,
 		RetryInterval: &retryInterval,