lint: add support for errcheck (#2918)

* lint: add support for errcheck

* Fix

* Fix

Author: remyleone

.golangci.yml

@@ -18,7 +18,9 @@ linters:
     - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
     - errchkjson # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occasions, where the check for the returned error can be omitted. [fast: false, auto-fix: false]
     - errname # Checks that sentinel errors are prefixed with the `Err` and error types are suffixed with the `Error`. [fast: false, auto-fix: false]
+    - errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. [fast: false, auto-fix: false]
     - exptostd # Detects functions from golang.org/x/exp/ that can be replaced by std functions. [auto-fix]
+    - fatcontext # Detects nested contexts in loops and function literals. [auto-fix]
     - forbidigo # Forbids identifiers [fast: true, auto-fix: false]
     - gci # Gci controls golang package import order and makes it always deterministic. [fast: true, auto-fix: false]
     - gocheckcompilerdirectives # Checks that go compiler directive comments (//go:) are valid. [fast: true, auto-fix: false]
@@ -38,6 +40,7 @@ linters:
     - gosmopolitan # Report certain i18n/l10n anti-patterns in your Go codebase [fast: false, auto-fix: false]
     - govet #(vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: false, auto-fix: false]
     - grouper # An analyzer to analyze expression groups. [fast: true, auto-fix: false]
+    - iface # Detect the incorrect use of interfaces, helping developers avoid interface pollution. [auto-fix]
     - importas # Enforces consistent import aliases [fast: false, auto-fix: false]
     - ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
     - intrange # intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false]
@@ -86,7 +89,6 @@ linters:
     - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
     - dupl # Tool for code clone detection [fast: true, auto-fix: false]
     - err113 # Golang linter to check the errors handling expressions [fast: false, auto-fix: false]
-    - errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. [fast: false, auto-fix: false]
     - exhaustive # check exhaustiveness of enum switch statements [fast: false, auto-fix: false]
     - forcetypeassert # finds forced type assertions [fast: true, auto-fix: false]
     - funlen # Tool for detection of long functions [fast: true, auto-fix: false]

internal/acctest/checks.go

@@ -97,7 +97,7 @@ func CheckResourceAttrFunc(name string, key string, test func(string) error) res
 
 		err := test(value)
 		if err != nil {
-			return fmt.Errorf("test for %s %s did not pass test: %s", name, key, err)
+			return fmt.Errorf("test for %s %s did not pass test: %w", name, key, err)
 		}
 
 		return nil

internal/datasource/search.go

@@ -69,7 +69,7 @@ func (e *TooManyResultsError) Error() string {
 }
 
 func (e *TooManyResultsError) Is(err error) bool {
-	_, ok := err.(*TooManyResultsError) //nolint:errorlint // Explicitly does *not* match down the error tree
+	_, ok := err.(*TooManyResultsError)
 
 	return ok
 }

internal/meta/meta.go

@@ -2,6 +2,7 @@ package meta
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -162,7 +163,8 @@ func customizeUserAgent(providerVersion string, terraformVersion string) string
 func loadProfile(ctx context.Context, d *schema.ResourceData) (*scw.Profile, *CredentialsSource, error) {
 	config, err := scw.LoadConfig()
 	// If the config file do not exist, don't return an error as we may find config in ENV or flags.
-	if _, isNotFoundError := err.(*scw.ConfigFileNotFoundError); isNotFoundError {
+	var configFileNotFoundError *scw.ConfigFileNotFoundError
+	if errors.As(err, &configFileNotFoundError) {
 		config = &scw.Config{}
 	} else if err != nil {
 		return nil, nil, err

internal/services/applesilicon/testfuncs/sweep.go

@@ -25,7 +25,7 @@ func testSweepAppleSiliconServer(_ string) error {
 
 		listServers, err := asAPI.ListServers(&applesiliconSDK.ListServersRequest{Zone: zone}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing apple silicon servers in (%s) in sweeper: %s", zone, err)
+			return fmt.Errorf("error listing apple silicon servers in (%s) in sweeper: %w", zone, err)
 		}
 
 		for _, server := range listServers.Servers {
@@ -34,7 +34,7 @@ func testSweepAppleSiliconServer(_ string) error {
 				Zone:     zone,
 			})
 			if errDelete != nil {
-				return fmt.Errorf("error deleting apple silicon server in sweeper: %s", err)
+				return fmt.Errorf("error deleting apple silicon server in sweeper: %w", err)
 			}
 		}
 

internal/services/baremetal/testfuncs/sweep.go

@@ -36,7 +36,7 @@ func testSweepServer(_ string) error {
 				ServerID: server.ID,
 			})
 			if err != nil {
-				return fmt.Errorf("error deleting server in sweeper: %s", err)
+				return fmt.Errorf("error deleting server in sweeper: %w", err)
 			}
 		}
 

internal/services/block/testfuncs/sweep.go

@@ -32,7 +32,7 @@ func testSweepBlockVolume(_ string) error {
 				Zone: zone,
 			}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing volume in (%s) in sweeper: %s", zone, err)
+			return fmt.Errorf("error listing volume in (%s) in sweeper: %w", zone, err)
 		}
 
 		for _, volume := range listVolumes.Volumes {
@@ -43,7 +43,7 @@ func testSweepBlockVolume(_ string) error {
 			if err != nil {
 				logging.L.Debugf("sweeper: error (%s)", err)
 
-				return fmt.Errorf("error deleting volume in sweeper: %s", err)
+				return fmt.Errorf("error deleting volume in sweeper: %w", err)
 			}
 		}
 
@@ -62,7 +62,7 @@ func testSweepSnapshot(_ string) error {
 				Zone: zone,
 			}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing snapshot in (%s) in sweeper: %s", zone, err)
+			return fmt.Errorf("error listing snapshot in (%s) in sweeper: %w", zone, err)
 		}
 
 		for _, snapshot := range listSnapshots.Snapshots {
@@ -73,7 +73,7 @@ func testSweepSnapshot(_ string) error {
 			if err != nil {
 				logging.L.Debugf("sweeper: error (%s)", err)
 
-				return fmt.Errorf("error deleting snapshot in sweeper: %s", err)
+				return fmt.Errorf("error deleting snapshot in sweeper: %w", err)
 			}
 		}
 

internal/services/container/testfuncs/checks.go

@@ -44,7 +44,7 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 			Region:      region,
 		})
 		if err != nil {
-			return fmt.Errorf("error waiting namespace: %v", err)
+			return fmt.Errorf("error waiting namespace: %w", err)
 		}
 
 		meta := tt.Meta
@@ -61,20 +61,20 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 
 		cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation())
 		if err != nil {
-			return fmt.Errorf("could not connect to Docker: %v", err)
+			return fmt.Errorf("could not connect to Docker: %w", err)
 		}
 
 		encodedJSON, err := json.Marshal(authConfig)
 		if err != nil {
-			return fmt.Errorf("could not marshal auth config: %v", err)
+			return fmt.Errorf("could not marshal auth config: %w", err)
 		}
 
 		ctx := context.Background()
 		authStr := base64.URLEncoding.EncodeToString(encodedJSON)
 
 		out, err := cli.ImagePull(ctx, testDockerIMG, image.PullOptions{})
 		if err != nil {
-			return fmt.Errorf("could not pull image: %v", err)
+			return fmt.Errorf("could not pull image: %w", err)
 		}
 
 		defer out.Close()
@@ -89,7 +89,7 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 
 			err = json.Unmarshal(streamBytes, &errorMessage)
 			if err != nil {
-				return fmt.Errorf("could not unmarshal: %v", err)
+				return fmt.Errorf("could not unmarshal: %w", err)
 			}
 
 			if errorMessage.Error != "" {
@@ -102,12 +102,12 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 
 		err = cli.ImageTag(ctx, imageTag, scwTag)
 		if err != nil {
-			return fmt.Errorf("could not tag image: %v", err)
+			return fmt.Errorf("could not tag image: %w", err)
 		}
 
 		pusher, err := cli.ImagePush(ctx, scwTag, image.PushOptions{RegistryAuth: authStr})
 		if err != nil {
-			return fmt.Errorf("could not push image: %v", err)
+			return fmt.Errorf("could not push image: %w", err)
 		}
 
 		defer pusher.Close()
@@ -122,7 +122,7 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 
 			err = json.Unmarshal(streamBytes, &errorMessage)
 			if err != nil {
-				return fmt.Errorf("could not unmarshal: %v", err)
+				return fmt.Errorf("could not unmarshal: %w", err)
 			}
 
 			if errorMessage.Error != "" {
@@ -135,7 +135,7 @@ func TestConfigContainerNamespace(tt *acctest.TestTools, n string) resource.Test
 			Region:      region,
 		})
 		if err != nil {
-			return fmt.Errorf("error waiting namespace: %v", err)
+			return fmt.Errorf("error waiting namespace: %w", err)
 		}
 
 		return nil

internal/services/container/testfuncs/sweep.go

@@ -37,7 +37,7 @@ func testSweepTrigger(_ string) error {
 				Region: region,
 			}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing trigger in (%s) in sweeper: %s", region, err)
+			return fmt.Errorf("error listing trigger in (%s) in sweeper: %w", region, err)
 		}
 
 		for _, trigger := range listTriggers.Triggers {
@@ -48,7 +48,7 @@ func testSweepTrigger(_ string) error {
 			if err != nil {
 				logging.L.Debugf("sweeper: error (%s)", err)
 
-				return fmt.Errorf("error deleting trigger in sweeper: %s", err)
+				return fmt.Errorf("error deleting trigger in sweeper: %w", err)
 			}
 		}
 
@@ -67,7 +67,7 @@ func testSweepContainer(_ string) error {
 				Region: region,
 			}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing containers in (%s) in sweeper: %s", region, err)
+			return fmt.Errorf("error listing containers in (%s) in sweeper: %w", region, err)
 		}
 
 		for _, cont := range listNamespaces.Containers {
@@ -78,7 +78,7 @@ func testSweepContainer(_ string) error {
 			if err != nil {
 				logging.L.Debugf("sweeper: error (%s)", err)
 
-				return fmt.Errorf("error deleting container in sweeper: %s", err)
+				return fmt.Errorf("error deleting container in sweeper: %w", err)
 			}
 		}
 
@@ -97,7 +97,7 @@ func testSweepNamespace(_ string) error {
 				Region: region,
 			}, scw.WithAllPages())
 		if err != nil {
-			return fmt.Errorf("error listing namespaces in (%s) in sweeper: %s", region, err)
+			return fmt.Errorf("error listing namespaces in (%s) in sweeper: %w", region, err)
 		}
 
 		for _, ns := range listNamespaces.Namespaces {
@@ -108,7 +108,7 @@ func testSweepNamespace(_ string) error {
 			if err != nil {
 				logging.L.Debugf("sweeper: error (%s)", err)
 
-				return fmt.Errorf("error deleting namespace in sweeper: %s", err)
+				return fmt.Errorf("error deleting namespace in sweeper: %w", err)
 			}
 		}
 

internal/services/flexibleip/testfuncs/sweep.go

@@ -34,7 +34,7 @@ func testSweepFlexibleIP(_ string) error {
 				Zone:  zone,
 			})
 			if err != nil {
-				return fmt.Errorf("error deleting ip in sweeper: %s", err)
+				return fmt.Errorf("error deleting ip in sweeper: %w", err)
 			}
 		}