fix(cockpit): resolve linting errors and documentation format issues

jremy42 · jremy42 · commit 49a789633fd2 · 2025-11-06T05:57:39.000+01:00
diff --git a/docs/resources/cockpit_grafana_user.md b/docs/resources/cockpit_grafana_user.md
@@ -13,7 +13,9 @@ The `scaleway_cockpit_grafana_user` resource allows you to create and manage [Gr
 
 Refer to Cockpit's [product documentation](https://www.scaleway.com/en/docs/observability/cockpit/concepts/) and [API documentation](https://www.scaleway.com/en/developers/api/cockpit/regional-api) for more information.
 
-## Migration Example
+## Example Usage
+
+### Migration to IAM Authentication
 
 Instead of managing Grafana users, retrieve your Grafana URL using the data source:
 
@@ -36,9 +38,7 @@ output "grafana_url" {
 }
 ```
 
-## Example Usage (Deprecated)
-
-### Create a Grafana user
+### Create a Grafana user (Deprecated)
 
 The following command allows you to create a Grafana user within a specific Scaleway Project.
 
diff --git a/internal/services/cockpit/grafana_data_source.go b/internal/services/cockpit/grafana_data_source.go
@@ -43,6 +43,7 @@ func dataSourceCockpitGrafanaRead(ctx context.Context, d *schema.ResourceData, m
 		if err != nil {
 			return diag.FromErr(err)
 		}
+
 		projectID = defaultProjectID
 	}
 
@@ -53,6 +54,7 @@ func dataSourceCockpitGrafanaRead(ctx context.Context, d *schema.ResourceData, m
 		if httperrors.Is404(err) {
 			return diag.Errorf("Grafana instance not found for project %s. Ensure that Cockpit is activated for this project.", projectID)
 		}
+
 		return diag.FromErr(err)
 	}
 
diff --git a/internal/services/cockpit/grafana_data_source_test.go b/internal/services/cockpit/grafana_data_source_test.go
@@ -14,7 +14,7 @@ func TestAccDataSourceCockpitGrafana_Basic(t *testing.T) {
 
 	projectName := "tf_tests_cockpit_grafana_data_basic"
 
-	resource.ParallelTest(t, resource.TestCase{
+	resource.Test(t, resource.TestCase{
 		ProtoV6ProviderFactories: tt.ProviderFactories,
 		Steps: []resource.TestStep{
 			{
@@ -44,7 +44,7 @@ func TestAccDataSourceCockpitGrafana_DefaultProject(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
-	resource.ParallelTest(t, resource.TestCase{
+	resource.Test(t, resource.TestCase{
 		ProtoV6ProviderFactories: tt.ProviderFactories,
 		Steps: []resource.TestStep{
 			{
diff --git a/templates/resources/cockpit_grafana_user.md.tmpl b/templates/resources/cockpit_grafana_user.md.tmpl
@@ -14,7 +14,9 @@ The `scaleway_cockpit_grafana_user` resource allows you to create and manage [Gr
 
 Refer to Cockpit's [product documentation](https://www.scaleway.com/en/docs/observability/cockpit/concepts/) and [API documentation](https://www.scaleway.com/en/developers/api/cockpit/regional-api) for more information.
 
-## Migration Example
+## Example Usage
+
+### Migration to IAM Authentication
 
 Instead of managing Grafana users, retrieve your Grafana URL using the data source:
 
@@ -37,9 +39,7 @@ output "grafana_url" {
 }
 ```
 
-## Example Usage (Deprecated)
-
-### Create a Grafana user
+### Create a Grafana user (Deprecated)
 
 The following command allows you to create a Grafana user within a specific Scaleway Project.
 

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ func dataSourceCockpitGrafanaRead(ctx context.Context, d *schema.ResourceData, m`
`43`	`43`	`if err != nil {`
`44`	`44`	`return diag.FromErr(err)`
`45`	`45`	`}`
	`46`	`+`
`46`	`47`	`projectID = defaultProjectID`
`47`	`48`	`}`
`48`	`49`
`@@ -53,6 +54,7 @@ func dataSourceCockpitGrafanaRead(ctx context.Context, d *schema.ResourceData, m`
`53`	`54`	`if httperrors.Is404(err) {`
`54`	`55`	`return diag.Errorf("Grafana instance not found for project %s. Ensure that Cockpit is activated for this project.", projectID)`
`55`	`56`	`}`
	`57`	`+`
`56`	`58`	`return diag.FromErr(err)`
`57`	`59`	`}`
`58`	`60`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ func TestAccDataSourceCockpitGrafana_Basic(t *testing.T) {`
`14`	`14`
`15`	`15`	`projectName := "tf_tests_cockpit_grafana_data_basic"`
`16`	`16`
`17`		`- resource.ParallelTest(t, resource.TestCase{`
	`17`	`+ resource.Test(t, resource.TestCase{`
`18`	`18`	`ProtoV6ProviderFactories: tt.ProviderFactories,`
`19`	`19`	`Steps: []resource.TestStep{`
`20`	`20`	`{`
`@@ -44,7 +44,7 @@ func TestAccDataSourceCockpitGrafana_DefaultProject(t *testing.T) {`
`44`	`44`	`tt := acctest.NewTestTools(t)`
`45`	`45`	`defer tt.Cleanup()`
`46`	`46`
`47`		`- resource.ParallelTest(t, resource.TestCase{`
	`47`	`+ resource.Test(t, resource.TestCase{`
`48`	`48`	`ProtoV6ProviderFactories: tt.ProviderFactories,`
`49`	`49`	`Steps: []resource.TestStep{`
`50`	`50`	`{`