docs(iam): update user doc and remove deprecated field (#2161)

Author: Codelax

docs/resources/iam_user.md

@@ -14,7 +14,23 @@ For more information, see [the documentation](https://www.scaleway.com/en/develo
 
 ```hcl
 resource "scaleway_iam_user" "basic" {
-  email            = "[email protected]"
+  email = "[email protected]"
+}
+```
+
+### Multiple users
+
+```hcl
+locals {
+  users = toset([
+    "[email protected]",
+    "[email protected]"
+  ])
+}
+
+resource scaleway_iam_user user {
+  for_each = local.users
+  email = each.key
 }
 ```
 
@@ -35,11 +51,8 @@ In addition to all above arguments, the following attributes are exported:
 - `deletable` - Whether the iam user is deletable.
 - `organization_id` - The ID of the organization the user.
 - `last_login_at` - The date of the last login.
-- `type` - The type of user. Check the possible values on
-  our [sdk](https://github.com/scaleway/scaleway-sdk-go/blob/master/api/iam/v1alpha1/iam_sdk.go#L508-L515C2).
-- `two_factor_enabled` - Deprecated, use "mfa" instead.
-- `status` - The status of user invitation. Check the possible values on
-  our [sdk](https://github.com/scaleway/scaleway-sdk-go/blob/master/api/iam/v1alpha1/iam_sdk.go#L475-L480).
+- `type` - The type of user. Check the possible values in the [api doc](https://www.scaleway.com/en/developers/api/iam/#path-users-get-a-given-user).
+- `status` - The status of user invitation. Check the possible values in the [api doc](https://www.scaleway.com/en/developers/api/iam/#path-users-get-a-given-user).
 - `mfa` - Whether the MFA is enabled.
 - `account_root_user_id` - The ID of the account root user associated with the user.
 

scaleway/resource_iam_user.go

@@ -1,7 +1,5 @@
 package scaleway
 
-//#TODO see update empty
-
 import (
 	"context"
 
@@ -52,11 +50,6 @@ func resourceScalewayIamUser() *schema.Resource {
 				Computed:    true,
 				Description: "The type of the iam user",
 			},
-			"two_factor_enabled": {
-				Type:        schema.TypeBool,
-				Computed:    true,
-				Description: "Deprecated, use 'mfa' instead.",
-			},
 			"status": {
 				Type:        schema.TypeString,
 				Computed:    true,
@@ -112,7 +105,6 @@ func resourceScalewayIamUserRead(ctx context.Context, d *schema.ResourceData, me
 	_ = d.Set("deletable", user.Deletable)
 	_ = d.Set("last_login_at", flattenTime(user.LastLoginAt))
 	_ = d.Set("type", user.Type)
-	_ = d.Set("two_factor_enabled", user.TwoFactorEnabled)
 	_ = d.Set("status", user.Status)
 	_ = d.Set("mfa", user.Mfa)