Skip to content

Commit 4ad91b7

Browse files
committed
fix(inference): rename resource from custom_model to model
1 parent 4099af8 commit 4ad91b7

File tree

10 files changed

+1664
-39
lines changed

10 files changed

+1664
-39
lines changed

docs/resources/inference_custom_model.md renamed to docs/resources/inference_model.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
---
22
subcategory: "Inference"
3-
page_title: "Scaleway: scaleway_inference_custom_model"
3+
page_title: "Scaleway: scaleway_inference_model"
44
---
55

6-
# Resource: scaleway_inference_custom_model
6+
# Resource: scaleway_inference_model
77

8-
The scaleway_inference_custom_model resource allows you to upload and manage custom inference models in the Scaleway Inference ecosystem. Once registered, a custom model can be used in any scaleway_inference_deployment resource.
8+
The scaleway_inference_model resource allows you to upload and manage custom inference models in the Scaleway Inference ecosystem. Once registered, a custom model can be used in any scaleway_inference_deployment resource.
99

1010
## Example Usage
1111

1212
### Basic
1313

1414
```terraform
15-
resource "scaleway_inference_custom_model" "test" {
15+
resource "scaleway_inference_model" "test" {
1616
name = "my-awesome-model"
1717
url = "https://huggingface.co/my-awsome-model"
1818
secret = "my-secret-token"
@@ -22,7 +22,7 @@ resource "scaleway_inference_custom_model" "test" {
2222
### Deploy your own model on your managed inference
2323

2424
```terraform
25-
resource "scaleway_inference_custom_model" "my_model" {
25+
resource "scaleway_inference_model" "my_model" {
2626
name = "my-awesome-model"
2727
url = "https://huggingface.co/my-awsome-model"
2828
secret = "my-secret-token"
@@ -31,7 +31,7 @@ resource "scaleway_inference_custom_model" "my_model" {
3131
resource "scaleway_inference_deployment" "my_deployment" {
3232
name = "test-inference-deployment-basic"
3333
node_type = "A100-80GB" # replace with your node type
34-
model_id = scaleway_inference_custom_model.my_model.id
34+
model_id = scaleway_inference_model.my_model.id
3535
3636
public_endpoint {
3737
is_enabled = true
@@ -72,5 +72,5 @@ In addition to all arguments above, the following attributes are exported:
7272
Custom models can be imported using, `{region}/{id}`, as shown below:
7373

7474
```bash
75-
terraform import scaleway_inference_custom_model.my_model fr-par/11111111-1111-1111-1111-111111111111
75+
terraform import scaleway_inference_model.my_model fr-par/11111111-1111-1111-1111-111111111111
7676
```

internal/provider/provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func Provider(config *Config) plugin.ProviderFunc {
167167
"scaleway_iam_ssh_key": iam.ResourceSSKKey(),
168168
"scaleway_iam_user": iam.ResourceUser(),
169169
"scaleway_inference_deployment": inference.ResourceDeployment(),
170-
"scaleway_inference_custom_model": inference.ResourceCustomModel(),
170+
"scaleway_inference_model": inference.ResourceModel(),
171171
"scaleway_instance_image": instance.ResourceImage(),
172172
"scaleway_instance_ip": instance.ResourceIP(),
173173
"scaleway_instance_ip_reverse_dns": instance.ResourceIPReverseDNS(),

internal/services/inference/helpers_inference.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import (
1313
const (
1414
defaultInferenceDeploymentTimeout = 80 * time.Minute
1515
defaultDeploymentRetryInterval = 1 * time.Minute
16-
defaultCustomModelTimeout = 180 * time.Minute
17-
defaultCustomModelRetryInterval = 1 * time.Minute
16+
defaultModelTimeout = 180 * time.Minute
17+
defaultModelRetryInterval = 1 * time.Minute
1818
)
1919

2020
// NewAPIWithRegion returns a new inference API and the region for a Create request

internal/services/inference/custom_model.go renamed to internal/services/inference/model.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ import (
1414
"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
1515
)
1616

17-
func ResourceCustomModel() *schema.Resource {
17+
func ResourceModel() *schema.Resource {
1818
return &schema.Resource{
19-
CreateContext: ResourceCustomModelCreate,
20-
ReadContext: ResourceCustomModelRead,
21-
DeleteContext: ResourceCustomModelDelete,
19+
CreateContext: ResourceModelCreate,
20+
ReadContext: ResourceModelRead,
21+
DeleteContext: ResourceModelDelete,
2222
Importer: &schema.ResourceImporter{
2323
StateContext: schema.ImportStatePassthroughContext,
2424
},
2525
Timeouts: &schema.ResourceTimeout{
26-
Default: schema.DefaultTimeout(defaultCustomModelTimeout),
27-
Create: schema.DefaultTimeout(defaultCustomModelTimeout),
28-
Update: schema.DefaultTimeout(defaultCustomModelTimeout),
29-
Delete: schema.DefaultTimeout(defaultCustomModelTimeout),
26+
Default: schema.DefaultTimeout(defaultModelTimeout),
27+
Create: schema.DefaultTimeout(defaultModelTimeout),
28+
Update: schema.DefaultTimeout(defaultModelTimeout),
29+
Delete: schema.DefaultTimeout(defaultModelTimeout),
3030
},
3131
SchemaVersion: 0,
3232
Schema: map[string]*schema.Schema{
@@ -134,7 +134,7 @@ func ResourceCustomModel() *schema.Resource {
134134
}
135135
}
136136

137-
func ResourceCustomModelCreate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
137+
func ResourceModelCreate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
138138
api, region, err := NewAPIWithRegion(d, m)
139139
if err != nil {
140140
return diag.FromErr(err)
@@ -173,10 +173,10 @@ func ResourceCustomModelCreate(ctx context.Context, d *schema.ResourceData, m in
173173
return diag.FromErr(fmt.Errorf("model '%s' is in status '%s'", model.ID, errMsg))
174174
}
175175

176-
return ResourceCustomModelRead(ctx, d, m)
176+
return ResourceModelRead(ctx, d, m)
177177
}
178178

179-
func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
179+
func ResourceModelRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
180180
api, region, id, err := NewAPIWithRegionAndID(m, d.Id())
181181
if err != nil {
182182
return diag.FromErr(err)
@@ -207,7 +207,7 @@ func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m inte
207207
return nil
208208
}
209209

210-
func ResourceCustomModelDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
210+
func ResourceModelDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
211211
api, region, id, err := NewAPIWithRegionAndID(m, d.Id())
212212
if err != nil {
213213
return diag.FromErr(err)

internal/services/inference/custom_model_test.go renamed to internal/services/inference/model_test.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ const (
1717
nodeTypeH100 = "H100"
1818
)
1919

20-
func TestAccCustomModel_Basic(t *testing.T) {
20+
func TestAccModel_Basic(t *testing.T) {
2121
tt := acctest.NewTestTools(t)
2222
defer tt.Cleanup()
2323

24-
modelName := "TestAccCustomModel_Basic"
24+
modelName := "TestAccModel_Basic"
2525

2626
resource.ParallelTest(t, resource.TestCase{
2727
PreCheck: func() { acctest.PreCheck(t) },
@@ -30,24 +30,24 @@ func TestAccCustomModel_Basic(t *testing.T) {
3030
Steps: []resource.TestStep{
3131
{
3232
Config: fmt.Sprintf(`
33-
resource "scaleway_inference_custom_model" "test" {
33+
resource "scaleway_inference_model" "test" {
3434
name = "%s"
3535
url = "%s"
3636
}`, modelName, modelURLCompatible),
3737
Check: resource.ComposeTestCheckFunc(
38-
testAccCheckCustomModelExists(tt, "scaleway_inference_custom_model.test"),
39-
resource.TestCheckResourceAttr("scaleway_inference_custom_model.test", "name", modelName),
38+
testAccCheckModelExists(tt, "scaleway_inference_model.test"),
39+
resource.TestCheckResourceAttr("scaleway_inference_model.test", "name", modelName),
4040
),
4141
},
4242
},
4343
})
4444
}
4545

46-
func TestAccCustomModel_DeployModelOnServer(t *testing.T) {
46+
func TestAccModel_DeployModelOnServer(t *testing.T) {
4747
tt := acctest.NewTestTools(t)
4848
defer tt.Cleanup()
4949

50-
modelName := "TestAccCustomModel_DeployModelOnServer"
50+
modelName := "TestAccModel_DeployModelOnServer"
5151

5252
resource.ParallelTest(t, resource.TestCase{
5353
PreCheck: func() { acctest.PreCheck(t) },
@@ -56,14 +56,14 @@ func TestAccCustomModel_DeployModelOnServer(t *testing.T) {
5656
Steps: []resource.TestStep{
5757
{
5858
Config: fmt.Sprintf(`
59-
resource "scaleway_inference_custom_model" "test" {
59+
resource "scaleway_inference_model" "test" {
6060
name = "%s"
6161
url = "%s"
6262
}
6363
resource "scaleway_inference_deployment" "main" {
6464
name = "%s"
6565
node_type = "%s"
66-
model_id = scaleway_inference_custom_model.test.id
66+
model_id = scaleway_inference_model.test.id
6767
public_endpoint {
6868
is_enabled = true
6969
}
@@ -79,11 +79,11 @@ func TestAccCustomModel_DeployModelOnServer(t *testing.T) {
7979
})
8080
}
8181

82-
func testAccCheckCustomModelExists(tt *acctest.TestTools, n string) resource.TestCheckFunc {
82+
func testAccCheckModelExists(tt *acctest.TestTools, n string) resource.TestCheckFunc {
8383
return func(state *terraform.State) error {
8484
rs, ok := state.RootModule().Resources[n]
8585
if !ok {
86-
return fmt.Errorf("can't find custom model resource name: %s", n)
86+
return fmt.Errorf("can't find model resource name: %s", n)
8787
}
8888

8989
api, region, id, err := inference.NewAPIWithRegionAndID(tt.Meta, rs.Primary.ID)

0 commit comments

Comments
 (0)