feat(k8s): read pool's private ips

Co-authored-by: Yacine FODIL <[email protected]>

Author: Mia-Cross

docs/resources/k8s_pool.md

@@ -114,6 +114,9 @@ In addition to all arguments above, the following attributes are exported:
 - `updated_at` - The last update date of the pool.
 - `version` - The version of the pool.
 - `current_size` - The size of the pool at the time the terraform state was updated.
+- `private_ips` - The list of private IPv4 addresses associated with the resource.
+    - `id` - The ID of the IPv4 address resource.
+    - `address` - The private IPv4 address.
 
 ## Zone
 

internal/services/ipam/helpers.go

@@ -1,6 +1,8 @@
 package ipam
 
 import (
+	"context"
+	"fmt"
 	"net"
 	"time"
 
@@ -65,3 +67,63 @@ func diffSuppressFuncStandaloneIPandCIDR(_, oldValue, newValue string, _ *schema
 
 	return false
 }
+
+type GetResourcePrivateIPsOptions struct {
+	ResourceType     *ipam.ResourceType
+	ResourceID       *string
+	ResourceName     *string
+	PrivateNetworkID *string
+}
+
+// GetResourcePrivateIPs fetches the private IP addresses of a resource in a private network.
+func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region, opts *GetResourcePrivateIPsOptions) ([]map[string]interface{}, error) {
+	ipamAPI := ipam.NewAPI(meta.ExtractScwClient(m))
+
+	req := &ipam.ListIPsRequest{
+		Region: region,
+	}
+
+	if opts != nil {
+		if opts.PrivateNetworkID != nil {
+			req.PrivateNetworkID = opts.PrivateNetworkID
+		}
+
+		if opts.ResourceID != nil {
+			req.ResourceID = opts.ResourceID
+		}
+
+		if opts.ResourceName != nil {
+			req.ResourceName = opts.ResourceName
+		}
+
+		if opts.ResourceType != nil {
+			req.ResourceType = *opts.ResourceType
+		}
+	}
+
+	resp, err := ipamAPI.ListIPs(req, scw.WithContext(ctx))
+	if err != nil {
+		return nil, fmt.Errorf("error fetching IPs from IPAM: %w", err)
+	}
+
+	if len(resp.IPs) == 0 {
+		return nil, nil
+	}
+
+	ipList := make([]map[string]interface{}, 0, len(resp.IPs))
+
+	for _, ip := range resp.IPs {
+		ipNet := ip.Address
+		if ipNet.IP == nil {
+			continue
+		}
+
+		ipMap := map[string]interface{}{
+			"id":      regional.NewIDString(region, ip.ID),
+			"address": ipNet.IP.String(),
+		}
+		ipList = append(ipList, ipMap)
+	}
+
+	return ipList, nil
+}

internal/services/k8s/helpers_k8s.go

@@ -86,6 +86,7 @@ func convertNodes(res *k8s.ListNodesResponse) []map[string]interface{} {
 
 	for _, node := range res.Nodes {
 		n := make(map[string]interface{})
+		n["id"] = node.ID
 		n["name"] = node.Name
 		n["status"] = node.Status.String()
 

internal/services/k8s/pool.go

@@ -13,6 +13,7 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/ipam"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/verify"
 )
@@ -192,6 +193,11 @@ func ResourcePool() *schema.Resource {
 				Computed: true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
+						"id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The ID of the node",
+						},
 						"name": {
 							Type:        schema.TypeString,
 							Computed:    true,
@@ -222,6 +228,25 @@ func ResourcePool() *schema.Resource {
 				Computed:    true,
 				Description: "The status of the pool",
 			},
+			"private_ips": {
+				Type:        schema.TypeList,
+				Computed:    true,
+				Description: "List of private IPv4 addresses associated with the resource",
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The ID of the IPv4 address resource",
+						},
+						"address": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The private IPv4 address",
+						},
+					},
+				},
+			},
 		},
 	}
 }
@@ -401,6 +426,35 @@ func ResourceK8SPoolRead(ctx context.Context, d *schema.ResourceData, m interfac
 		_ = d.Set("placement_group_id", zonal.NewID(pool.Zone, *pool.PlacementGroupID).String())
 	}
 
+	var allPrivateIPs []map[string]interface{}
+
+	for _, nodeMap := range nodes {
+		nodeNameInterface, ok := nodeMap["name"]
+		if !ok {
+			continue
+		}
+
+		nodeName, ok := nodeNameInterface.(string)
+		if !ok {
+			continue
+		}
+
+		opts := &ipam.GetResourcePrivateIPsOptions{
+			ResourceName: &nodeName,
+		}
+
+		privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+		if err != nil {
+			return diag.FromErr(err)
+		}
+
+		if privateIPs != nil {
+			allPrivateIPs = append(allPrivateIPs, privateIPs...)
+		}
+	}
+
+	_ = d.Set("private_ips", allPrivateIPs)
+
 	return nil
 }
 

internal/services/k8s/pool_test.go

@@ -50,6 +50,8 @@ func TestAccPool_Basic(t *testing.T) {
 					resource.TestCheckResourceAttr("scaleway_k8s_pool.default", "tags.1", "scaleway_k8s_cluster"),
 					resource.TestCheckResourceAttr("scaleway_k8s_pool.default", "tags.2", "default"),
 					testAccCheckK8SPoolServersAreInPrivateNetwork(tt, "scaleway_k8s_cluster.minimal", "scaleway_k8s_pool.default", "scaleway_vpc_private_network.minimal"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.0.id"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.0.address"),
 				),
 			},
 			{
@@ -69,6 +71,10 @@ func TestAccPool_Basic(t *testing.T) {
 					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.minimal", "nodes.0.public_ip"), // Deprecated attributes
 					testAccCheckK8SPoolServersAreInPrivateNetwork(tt, "scaleway_k8s_cluster.minimal", "scaleway_k8s_pool.default", "scaleway_vpc_private_network.minimal"),
 					testAccCheckK8SPoolServersAreInPrivateNetwork(tt, "scaleway_k8s_cluster.minimal", "scaleway_k8s_pool.minimal", "scaleway_vpc_private_network.minimal"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.0.id"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.0.address"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.1.id"),
+					resource.TestCheckResourceAttrSet("scaleway_k8s_pool.default", "private_ips.1.address"),
 				),
 			},
 			{