fix golangci-lint

Author: Laure-di

internal/services/baremetal/server.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
@@ -336,6 +337,9 @@ func ResourceServerCreate(ctx context.Context, d *schema.ResourceData, m interfa
 		if file != "" {
 			todecode, _ := file.(string)
 			err = json.Unmarshal([]byte(todecode), &partitioningSchema)
+			if err != nil {
+				return diag.FromErr(err)
+			}
 		}
 		req.Install = &baremetal.CreateServerRequestInstall{
 			OsID:               zonal.ExpandID(d.Get("os")).ID,
@@ -487,63 +491,6 @@ func ResourceServerRead(ctx context.Context, d *schema.ResourceData, m interface
 	return nil
 }
 
-//func schemaToStringList(schema *baremetal.Schema) string {
-//	var result string
-//
-//	if schema.Disks != nil {
-//		for _, disk := range schema.Disks {
-//			if disk != nil {
-//				result += "Disk: " + disk.Device
-//				if disk.Partitions != nil {
-//					for _, partition := range disk.Partitions {
-//						if partition != nil {
-//							result += fmt.Sprintf("  Partition: %s Number: %d Size: %s", partition.Label, partition.Number, partition.Size.String())
-//						}
-//					}
-//				}
-//			}
-//		}
-//	}
-//
-//	if schema.Raids != nil {
-//		for _, raid := range schema.Raids {
-//			if raid != nil {
-//				result += fmt.Sprintf("RAID: %s Level: %s", raid.Name, raid.Level)
-//				for _, device := range raid.Devices {
-//					result += "  Device: " + device
-//				}
-//			}
-//		}
-//	}
-//
-//	if schema.Filesystems != nil {
-//		for _, fs := range schema.Filesystems {
-//			if fs != nil {
-//				result += fmt.Sprintf("Filesystem: %s Format: %s Mountpoint: %s", fs.Device, fs.Format, fs.Mountpoint)
-//			}
-//		}
-//	}
-//
-//	if schema.Zfs != nil {
-//		for _, pool := range schema.Zfs.Pools {
-//			if pool != nil {
-//				result += fmt.Sprintf("ZFS Pool: %s Type: %s", pool.Name, pool.Type)
-//				for _, device := range pool.Devices {
-//					result += "  Device: " + device
-//				}
-//				for _, option := range pool.Options {
-//					result += "  Option: " + option
-//				}
-//				for _, fsOption := range pool.FilesystemOptions {
-//					result += "  Filesystem Option: " + fsOption
-//				}
-//			}
-//		}
-//	}
-//
-//	return result
-//}
-
 //gocyclo:ignore
 func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
 	api, zonedID, err := NewAPIWithZoneAndID(m, d.Id())

internal/services/baremetal/server_test.go

@@ -185,7 +185,6 @@ func TestAccServer_CreateServerWithCustomInstallConfig(t *testing.T) {
 
 	SSHKeyName := "TestAccServer_CreateServerWithCustomInstallConfig"
 	name := "TestAccServer_CreateServerWithCustomInstallConfig"
-	//fileName := "partitioning.json"
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
@@ -1076,7 +1075,6 @@ func testAccChechPartitioning(tt *acctest.TestTools, n string, source string) re
 			return fmt.Errorf("server %s has no partitioning schema", n)
 		}
 		schema := baremetalSDK.Schema{}
-		//partitioning, _ := json.Marshal(source)
 		err = json.Unmarshal([]byte(source), &schema)
 		if err != nil {
 			return err