chore(container): simplify Container testing and remove image push (#3155)

* fix(tests): remove check / fixture test function causing side effects

* update IPAM cassettes

* record instance tests

---------

Co-authored-by: Yacine FODIL <[email protected]>
Co-authored-by: Leïla Marabese <[email protected]>
Co-authored-by: Rémy Léone <[email protected]>

Author: 4 people

internal/services/container/container_test.go

@@ -12,7 +12,6 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/acctest"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container"
-	containerchecks "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container/testfuncs"
 )
 
 func TestAccContainer_Basic(t *testing.T) {
@@ -226,25 +225,6 @@ func TestAccContainer_WithIMG(t *testing.T) {
 		ProviderFactories: tt.ProviderFactories,
 		CheckDestroy:      isContainerDestroyed(tt),
 		Steps: []resource.TestStep{
-			{
-				Config: fmt.Sprintf(`
-					resource scaleway_container_namespace main {
-						name = "%s"
-						description = "test container"
-					}
-				`, containerNamespace),
-			},
-			{
-				Config: fmt.Sprintf(`
-					resource scaleway_container_namespace main {
-						name = "%s"
-						description = "test container"
-					}
-				`, containerNamespace),
-				Check: resource.ComposeTestCheckFunc(
-					containerchecks.TestConfigContainerNamespace(tt, "scaleway_container_namespace.main"),
-				),
-			},
 			{
 				Config: fmt.Sprintf(`
 					resource scaleway_container_namespace main {
@@ -256,7 +236,7 @@ func TestAccContainer_WithIMG(t *testing.T) {
 						name = "my-container-02"
 						description = "environment variables test"
 						namespace_id = scaleway_container_namespace.main.id
-						registry_image = "${scaleway_container_namespace.main.registry_endpoint}/nginx:test"
+						registry_image = "nginx:latest"
 						port = 80
 						cpu_limit = 140
 						memory_limit = 256
@@ -501,7 +481,7 @@ func TestAccContainer_ScalingOption(t *testing.T) {
 			{
 				Config: `
 					resource scaleway_container_namespace main {}
-		
+
 					resource scaleway_container main {
 						namespace_id = scaleway_container_namespace.main.id
 						deploy = false
@@ -520,7 +500,7 @@ func TestAccContainer_ScalingOption(t *testing.T) {
 			{
 				Config: `
 					resource scaleway_container_namespace main {}
-		
+
 					resource scaleway_container main {
 						namespace_id = scaleway_container_namespace.main.id
 						deploy = false
@@ -542,7 +522,7 @@ func TestAccContainer_ScalingOption(t *testing.T) {
 			{
 				Config: `
 					resource scaleway_container_namespace main {}
-		
+
 					resource scaleway_container main {
 						namespace_id = scaleway_container_namespace.main.id
 						deploy = false

internal/services/container/domain_test.go

@@ -11,7 +11,6 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/logging"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container"
-	containerchecks "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container/testfuncs"
 )
 
 func TestAccDomain_Basic(t *testing.T) {
@@ -26,18 +25,12 @@ func TestAccDomain_Basic(t *testing.T) {
 		ProviderFactories: tt.ProviderFactories,
 		CheckDestroy:      isDomainDestroyed(tt),
 		Steps: []resource.TestStep{
-			{
-				Config: `
-				resource scaleway_container_namespace main {}
-				`,
-				Check: containerchecks.TestConfigContainerNamespace(tt, "scaleway_container_namespace.main"),
-			},
 			{
 				Config: fmt.Sprintf(`
 				resource scaleway_container_namespace main {}
 
 				resource scaleway_container app {
-					registry_image = "${scaleway_container_namespace.main.registry_endpoint}/nginx:test"
+					registry_image = "nginx:latest"
 					namespace_id = scaleway_container_namespace.main.id
 					port = 80
 					deploy = true

internal/services/container/testdata/container-basic.cassette.yaml

@@ -10,7 +10,6 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/acctest"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/logging"
-	containerchecks "github.com/scaleway/terraform-provider-scaleway/v2/internal/services/container/testfuncs"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/function"
 )
 
@@ -26,21 +25,6 @@ func TestAccFunctionDomain_Basic(t *testing.T) {
 		ProviderFactories: tt.ProviderFactories,
 		CheckDestroy:      testAccCheckFunctionDomainDestroy(tt),
 		Steps: []resource.TestStep{
-			{
-				Config: `
-				resource scaleway_function_namespace main {}
-
-				resource scaleway_function main {
-						namespace_id = scaleway_function_namespace.main.id
-						runtime = "go122"
-						privacy = "private"
-						handler = "Handle"
-						zip_file = "testfixture/gofunction.zip"
-						deploy = true
-				}
-				`,
-				Check: containerchecks.TestConfigContainerNamespace(tt, "scaleway_function_namespace.main"),
-			},
 			{
 				Config: fmt.Sprintf(`
 					resource scaleway_function_namespace main {}
@@ -56,7 +40,7 @@ func TestAccFunctionDomain_Basic(t *testing.T) {
 
 					resource scaleway_domain_record "function" {
 				  		dns_zone = "%s"
-				  		name     = "container"
+				  		name     = "function"
 				  		type     = "CNAME"
 				  		data     = "${scaleway_function.main.domain_name}."
 				  		ttl      = 60
@@ -69,6 +53,7 @@ func TestAccFunctionDomain_Basic(t *testing.T) {
 				`, testDNSZone),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckFunctionDomainExists(tt, "scaleway_function_domain.main"),
+					resource.TestCheckResourceAttr("scaleway_function_domain.main", "hostname", fmt.Sprintf("%s.%s", "function", testDNSZone)),
 				),
 			},
 		},