TestAccDataSourceServerType_CompareWithPCU light version

Author: Mia-Cross

internal/services/instance/server_type_data_source_test.go

@@ -121,60 +121,20 @@ func TestAccDataSourceServerType_CompareWithPCU(t *testing.T) {
 	pcuAPI := product_catalog.NewPublicCatalogAPI(client)
 	steps := []resource.TestStep(nil)
 
-	serversTypesToTestByZone := map[scw.Zone][]string{
-		scw.ZoneFrPar1: {
-			"COPARM1-2C-8G",
-			"DEV1-M",
-			"RENDER-S",
-			"STARDUST1-S",
-		},
-		scw.ZoneFrPar2: {
-			"COPARM1-32C-128G",
-			"DEV1-L",
-			"GP1-M",
-			"H100-SXM-2-80G",
-			"PLAY2-MICRO",
-		},
-		scw.ZoneFrPar3: {
-			"GP1-S",
-			"POP2-HM-16C-128G",
-			"PRO2-XXS",
-		},
-		scw.ZoneNlAms1: {
-			"COPARM1-8C-32G",
-			"GP1-XL",
-			"PRO2-XS",
-		},
-		scw.ZoneNlAms2: {
-			"DEV1-XL",
-			"POP2-HN-5",
-			"PRO2-S",
-		},
-		scw.ZoneNlAms3: {
-			"PLAY2-NANO",
-			"POP2-2C-8G",
-			"PRO2-L",
-		},
-		scw.ZonePlWaw1: {
-			"DEV1-S",
-			"GP1-L",
-			"POP2-64C-256G",
-		},
-		scw.ZonePlWaw2: {
-			"GP1-XS",
-			"H100-1-80G",
-			"L4-1-24G",
-			"L40S-4-48G",
-		},
-		scw.ZonePlWaw3: {
-			"PLAY2-PICO",
-			"POP2-HC-32C-64G",
-			"PRO2-M",
-		},
+	serverTypeToTestByZone := map[scw.Zone]string{
+		scw.ZoneFrPar1: "RENDER-S",
+		scw.ZoneFrPar2: "H100-SXM-2-80G",
+		scw.ZoneFrPar3: "POP2-HM-16C-128G",
+		scw.ZoneNlAms1: "COPARM1-8C-32G",
+		scw.ZoneNlAms2: "DEV1-XL",
+		scw.ZoneNlAms3: "PLAY2-NANO",
+		scw.ZonePlWaw1: "GP1-L",
+		scw.ZonePlWaw2: "L4-1-24G",
+		scw.ZonePlWaw3: "PRO2-M",
 	}
 
-	for zone, serverTypesToTest := range serversTypesToTestByZone {
-		// List all available server types in selected zone
+	for zone, serverTypeToTest := range serverTypeToTestByZone {
+		// List all available server types in the zone to test
 		pcuInstances, err := pcuAPI.ListPublicCatalogProducts(&product_catalog.PublicCatalogAPIListPublicCatalogProductsRequest{
 			ProductTypes: []product_catalog.ListPublicCatalogProductsRequestProductType{
 				product_catalog.ListPublicCatalogProductsRequestProductTypeInstance,
@@ -185,61 +145,59 @@ func TestAccDataSourceServerType_CompareWithPCU(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		// Look for each server type to be tested in the zone in the PCU
-		for _, serverTypeToTest := range serverTypesToTest {
-			for _, pcuInstance := range pcuInstances.Products {
-				if pcuInstance.Properties.Instance.OfferID != serverTypeToTest {
-					continue
-				}
+		// Look for the server type to test in the PCU
+		for _, pcuInstance := range pcuInstances.Products {
+			if pcuInstance.Properties.Instance.OfferID != serverTypeToTest {
+				continue
+			}
 
-				// Fetch expected values from the PCU to be compared with the data source's info
-				datasourceTFName := "data.scaleway_instance_server_type." + serverTypeToTest
-				hardwareSpecs := pcuInstance.Properties.Hardware
+			// Fetch expected values from the PCU to be compared with the data source's info
+			datasourceTFName := "data.scaleway_instance_server_type." + serverTypeToTest
+			hardwareSpecs := pcuInstance.Properties.Hardware
 
-				expectedArch := ""
+			expectedArch := ""
 
-				switch hardwareSpecs.CPU.Arch {
-				case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchX64:
-					expectedArch = instance.ArchX86_64.String()
-				case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchArm64:
-					expectedArch = instance.ArchArm64.String()
-				case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchUnknownArch:
-					expectedArch = instance.ArchUnknownArch.String()
-				}
+			switch hardwareSpecs.CPU.Arch {
+			case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchX64:
+				expectedArch = instance.ArchX86_64.String()
+			case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchArm64:
+				expectedArch = instance.ArchArm64.String()
+			case product_catalog.PublicCatalogProductPropertiesHardwareCPUArchUnknownArch:
+				expectedArch = instance.ArchUnknownArch.String()
+			}
 
-				expectedCPU := strconv.FormatUint(uint64(hardwareSpecs.CPU.Threads), 10)
-				expectedRAM := hardwareSpecs.RAM.Size.String()
+			expectedCPU := strconv.FormatUint(uint64(hardwareSpecs.CPU.Threads), 10)
+			expectedRAM := hardwareSpecs.RAM.Size.String()
 
-				expectedGPU := "0"
-				if hardwareSpecs.Gpu != nil {
-					expectedGPU = strconv.FormatUint(uint64(hardwareSpecs.Gpu.Count), 10)
-				}
+			expectedGPU := "0"
+			if hardwareSpecs.Gpu != nil {
+				expectedGPU = strconv.FormatUint(uint64(hardwareSpecs.Gpu.Count), 10)
+			}
 
-				expectedInternalBandwidth := strconv.FormatUint(hardwareSpecs.Network.InternalBandwidth, 10)
-				expectedPublicBandwidth := strconv.FormatUint(hardwareSpecs.Network.PublicBandwidth, 10)
+			expectedInternalBandwidth := strconv.FormatUint(hardwareSpecs.Network.InternalBandwidth, 10)
+			expectedPublicBandwidth := strconv.FormatUint(hardwareSpecs.Network.PublicBandwidth, 10)
 
-				expectedHourlyPrice := strings.TrimPrefix(pcuInstance.Price.RetailPrice.String(), "€ ")
+			expectedHourlyPrice := strings.TrimPrefix(pcuInstance.Price.RetailPrice.String(), "€ ")
 
-				// Create test step
-				steps = append(steps, resource.TestStep{
-					Config: fmt.Sprintf(`
+			// Create test step
+			steps = append(steps, resource.TestStep{
+				Config: fmt.Sprintf(`
 				data "scaleway_instance_server_type" "%[1]s" {
 					name = "%[1]s"
 					zone = "%[2]s"
 				}`, serverTypeToTest, zone),
-					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr(datasourceTFName, "name", serverTypeToTest),
-						resource.TestCheckResourceAttr(datasourceTFName, "zone", zone.String()),
-						resource.TestCheckResourceAttr(datasourceTFName, "arch", expectedArch),
-						resource.TestCheckResourceAttr(datasourceTFName, "cpu", expectedCPU),
-						resource.TestCheckResourceAttr(datasourceTFName, "ram", expectedRAM),
-						resource.TestCheckResourceAttr(datasourceTFName, "gpu", expectedGPU),
-						resource.TestCheckResourceAttr(datasourceTFName, "network.0.internal_bandwidth", expectedInternalBandwidth),
-						resource.TestCheckResourceAttr(datasourceTFName, "network.0.public_bandwidth", expectedPublicBandwidth),
-						resource.TestCheckResourceAttr(datasourceTFName, "hourly_price", expectedHourlyPrice),
-					),
-				})
-			}
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(datasourceTFName, "name", serverTypeToTest),
+					resource.TestCheckResourceAttr(datasourceTFName, "zone", zone.String()),
+					resource.TestCheckResourceAttr(datasourceTFName, "arch", expectedArch),
+					resource.TestCheckResourceAttr(datasourceTFName, "cpu", expectedCPU),
+					resource.TestCheckResourceAttr(datasourceTFName, "ram", expectedRAM),
+					resource.TestCheckResourceAttr(datasourceTFName, "gpu", expectedGPU),
+					resource.TestCheckResourceAttr(datasourceTFName, "network.0.internal_bandwidth", expectedInternalBandwidth),
+					resource.TestCheckResourceAttr(datasourceTFName, "network.0.public_bandwidth", expectedPublicBandwidth),
+					resource.TestCheckResourceAttr(datasourceTFName, "hourly_price", expectedHourlyPrice),
+				),
+			})
 		}
 	}