add flag to manage PN attachments externally

Author: yfodil

docs/resources/lb.md

@@ -109,6 +109,8 @@ The following arguments are supported:
     - `private_network_id` - (Required) The ID of the Private Network to attach to.
     - ~> **Important:** Updates to `private_network` will recreate the attachment.
     - `ipam_ids` - (Optional) IPAM ID of a pre-reserved IP address to assign to the Load Balancer on this Private Network.
+- `external_private_networks` - (Defaults to `false`) A boolean to specify whether to use [lb_private_network](../resources/lb_private_network.md).
+  If `external_private_networks` is set to `true`, `private_network` can not be set directly in the Load Balancer.
 - `ssl_compatibility_level` - (Optional) Enforces minimal SSL version (in SSL/TLS offloading context). Please check [possible values](https://www.scaleway.com/en/developers/api/load-balancer/zoned-api/#path-load-balancer-create-a-load-balancer).
 - `zone` - (Defaults to [provider](../index.md#zone) `zone`) The [zone](../guides/regions_and_zones.md#zones) of the Load Balancer.
 - `project_id` - (Defaults to [provider](../index.md#project_id) `project_id`) The ID of the Project the Load Balancer is associated with.

internal/services/lb/lb.go

@@ -107,12 +107,13 @@ func ResourceLb() *schema.Resource {
 				Deprecated:  "The resource ip will be destroyed by it's own resource. Please set this to `false`",
 			},
 			"private_network": {
-				Type:        schema.TypeSet,
-				Optional:    true,
-				Computed:    true,
-				MaxItems:    8,
-				Set:         lbPrivateNetworkSetHash,
-				Description: "List of private network to connect with your load balancer",
+				Type:          schema.TypeSet,
+				Optional:      true,
+				Computed:      true,
+				MaxItems:      8,
+				Set:           lbPrivateNetworkSetHash,
+				ConflictsWith: []string{"external_private_networks"},
+				Description:   "List of private network to connect with your load balancer",
 				DiffSuppressFunc: func(k, oldValue, newValue string, _ *schema.ResourceData) bool {
 					// Check if the key is for the 'private_network_id' attribute
 					if strings.HasSuffix(k, "private_network_id") {
@@ -169,6 +170,13 @@ func ResourceLb() *schema.Resource {
 					},
 				},
 			},
+			"external_private_networks": {
+				Type:          schema.TypeBool,
+				Optional:      true,
+				Default:       false,
+				Description:   "This boolean determines if private network attachments should be managed externally through the `scaleway_lb_private_network` resource. When set, `private_network` must not be configured in this resource",
+				ConflictsWith: []string{"private_network"},
+			},
 			"ssl_compatibility_level": {
 				Type:             schema.TypeString,
 				Optional:         true,
@@ -266,22 +274,24 @@ func resourceLbCreate(ctx context.Context, d *schema.ResourceData, m any) diag.D
 		return diag.FromErr(err)
 	}
 
-	// attach private network
-	pnConfigs, pnExist := d.GetOk("private_network")
-	if pnExist {
-		pnConfigs, err := expandPrivateNetworks(pnConfigs)
-		if err != nil {
-			return diag.FromErr(err)
-		}
+	if !d.Get("external_private_networks").(bool) {
+		// attach private network
+		pnConfigs, pnExist := d.GetOk("private_network")
+		if pnExist {
+			pnConfigs, err := expandPrivateNetworks(pnConfigs)
+			if err != nil {
+				return diag.FromErr(err)
+			}
 
-		_, err = attachLBPrivateNetworks(ctx, lbAPI, zone, pnConfigs, lb.ID, d.Timeout(schema.TimeoutCreate))
-		if err != nil {
-			return diag.FromErr(err)
-		}
+			_, err = attachLBPrivateNetworks(ctx, lbAPI, zone, pnConfigs, lb.ID, d.Timeout(schema.TimeoutCreate))
+			if err != nil {
+				return diag.FromErr(err)
+			}
 
-		_, err = waitForLB(ctx, lbAPI, zone, lb.ID, d.Timeout(schema.TimeoutCreate))
-		if err != nil {
-			return diag.FromErr(err)
+			_, err = waitForLB(ctx, lbAPI, zone, lb.ID, d.Timeout(schema.TimeoutCreate))
+			if err != nil {
+				return diag.FromErr(err)
+			}
 		}
 	}
 
@@ -353,7 +363,12 @@ func resourceLbRead(ctx context.Context, d *schema.ResourceData, m any) diag.Dia
 		return diag.FromErr(err)
 	}
 
-	_ = d.Set("private_network", flattenPrivateNetworkConfigs(privateNetworks))
+	external := d.Get("external_private_networks").(bool)
+	if !external {
+		_ = d.Set("private_network", flattenPrivateNetworkConfigs(privateNetworks))
+	} else {
+		_ = d.Set("private_network", schema.NewSet(lbPrivateNetworkSetHash, []any{}))
+	}
 
 	privateNetworkIDs := make([]string, 0, len(privateNetworks))
 	for _, pn := range privateNetworks {
@@ -521,7 +536,8 @@ func resourceLbUpdate(ctx context.Context, d *schema.ResourceData, m any) diag.D
 	////
 	// Attach / Detach Private Networks
 	////
-	if d.HasChange("private_network") {
+	external := d.Get("external_private_networks").(bool)
+	if !external && d.HasChange("private_network") {
 		// check current lb stability state
 		_, err = waitForLB(ctx, lbAPI, zone, ID, d.Timeout(schema.TimeoutUpdate))
 		if err != nil {

internal/services/lb/private_network.go

@@ -167,7 +167,7 @@ func resourceLbPrivateNetworkRead(ctx context.Context, d *schema.ResourceData, m
 
 	_ = d.Set("private_network_id", regional.NewIDString(region, foundPN.PrivateNetworkID))
 	_ = d.Set("lb_id", zonal.NewIDString(zone, foundPN.LB.ID))
-	_ = d.Set("ipam_ip_ids", regional.NewRegionalIDs(region, foundPN.IpamIDs))
+	_ = d.Set("ipam_ip_ids", regional.NewIDStrings(region, foundPN.IpamIDs))
 	_ = d.Set("status", foundPN.Status.String())
 	_ = d.Set("created_at", types.FlattenTime(foundPN.CreatedAt))
 	_ = d.Set("updated_at", types.FlattenTime(foundPN.UpdatedAt))