chore: satisfy golangci-lint for cockpit updates

Author: jremy42

internal/services/cockpit/alert_manager.go

@@ -78,8 +78,10 @@ func ResourceCockpitAlertManagerCreate(ctx context.Context, d *schema.ResourceDa
 		if err != nil {
 			return diag.FromErr(err)
 		}
+
 		_ = d.Set("project_id", projectID)
 	}
+
 	contactPoints := d.Get("contact_points").([]any)
 
 	_, err = api.EnableAlertManager(&cockpit.RegionalAPIEnableAlertManagerRequest{
@@ -187,6 +189,7 @@ func ResourceCockpitAlertManagerRead(ctx context.Context, d *schema.ResourceData
 	}
 
 	alertStatusMap := make(map[string]cockpit.AlertStatus)
+
 	for _, alert := range alerts.Alerts {
 		if alert.PreconfiguredData != nil && alert.PreconfiguredData.PreconfiguredRuleID != "" {
 			alertStatusMap[alert.PreconfiguredData.PreconfiguredRuleID] = alert.RuleStatus
@@ -196,6 +199,7 @@ func ResourceCockpitAlertManagerRead(ctx context.Context, d *schema.ResourceData
 	if v, ok := d.GetOk("preconfigured_alert_ids"); ok {
 		requestedIDs := expandStringSet(v.(*schema.Set))
 		requestedMap := make(map[string]bool)
+
 		for _, id := range requestedIDs {
 			requestedMap[id] = true
 		}

internal/services/cockpit/alert_manager_test.go

@@ -409,6 +409,7 @@ func testAccCheckPreconfiguredAlertsCount(tt *acctest.TestTools, resourceName st
 		}
 
 		actualCountStr := rs.Primary.Attributes["preconfigured_alert_ids.#"]
+
 		actualCount, err := strconv.Atoi(actualCountStr)
 		if err != nil {
 			return fmt.Errorf("failed to parse preconfigured_alert_ids count: %w", err)
@@ -423,7 +424,8 @@ func testAccCheckPreconfiguredAlertsCount(tt *acctest.TestTools, resourceName st
 		region := scw.Region(rs.Primary.Attributes["region"])
 
 		userRequestedIDs := make(map[string]bool)
-		for i := 0; i < actualCount; i++ {
+
+		for i := range actualCount {
 			alertID := rs.Primary.Attributes[fmt.Sprintf("preconfigured_alert_ids.%d", i)]
 			if alertID != "" {
 				userRequestedIDs[alertID] = true

internal/services/cockpit/grafana_user.go

@@ -72,7 +72,7 @@ func ResourceCockpitGrafanaUserCreate(ctx context.Context, d *schema.ResourceDat
 	login := d.Get("login").(string)
 	role := cockpit.GrafanaUserRole(d.Get("role").(string))
 
-	grafanaUser, err := api.CreateGrafanaUser(&cockpit.GlobalAPICreateGrafanaUserRequest{
+	grafanaUser, err := api.CreateGrafanaUser(&cockpit.GlobalAPICreateGrafanaUserRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 		ProjectID: projectID,
 		Login:     login,
 		Role:      role,
@@ -93,7 +93,7 @@ func ResourceCockpitGrafanaUserRead(ctx context.Context, d *schema.ResourceData,
 		return diag.FromErr(err)
 	}
 
-	res, err := api.ListGrafanaUsers(&cockpit.GlobalAPIListGrafanaUsersRequest{
+	res, err := api.ListGrafanaUsers(&cockpit.GlobalAPIListGrafanaUsersRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 		ProjectID: projectID,
 	}, scw.WithContext(ctx), scw.WithAllPages())
 	if err != nil {
@@ -149,7 +149,7 @@ func ResourceCockpitGrafanaUserDelete(ctx context.Context, d *schema.ResourceDat
 		return diag.FromErr(err)
 	}
 
-	err = api.DeleteGrafanaUser(&cockpit.GlobalAPIDeleteGrafanaUserRequest{
+	err = api.DeleteGrafanaUser(&cockpit.GlobalAPIDeleteGrafanaUserRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 		ProjectID:     projectID,
 		GrafanaUserID: grafanaUserID,
 	}, scw.WithContext(ctx))

internal/services/cockpit/grafana_user_test.go

@@ -132,7 +132,7 @@ func isGrafanaUserPresent(tt *acctest.TestTools, n string) resource.TestCheckFun
 			return err
 		}
 
-		res, err := api.ListGrafanaUsers(&cockpitSDK.GlobalAPIListGrafanaUsersRequest{
+		res, err := api.ListGrafanaUsers(&cockpitSDK.GlobalAPIListGrafanaUsersRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 			ProjectID: projectID,
 		}, scw.WithAllPages())
 		if err != nil {
@@ -169,7 +169,7 @@ func isGrafanaUserDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 				return err
 			}
 
-			err = api.DeleteGrafanaUser(&cockpitSDK.GlobalAPIDeleteGrafanaUserRequest{
+			err = api.DeleteGrafanaUser(&cockpitSDK.GlobalAPIDeleteGrafanaUserRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 				ProjectID:     projectID,
 				GrafanaUserID: grafanaUserID,
 			})

internal/services/cockpit/preconfigured_alert_data_source.go

@@ -116,6 +116,7 @@ func dataSourceCockpitPreconfiguredAlertRead(ctx context.Context, d *schema.Reso
 		if err != nil {
 			return diag.FromErr(err)
 		}
+
 		projectID = defaultProjectID
 	}
 

internal/services/cockpit/testfuncs/sweep.go

@@ -88,7 +88,7 @@ func testSweepCockpitGrafanaUser(_ string) error {
 				continue
 			}
 
-			listGrafanaUsers, err := cockpitAPI.ListGrafanaUsers(&cockpit.GlobalAPIListGrafanaUsersRequest{
+			listGrafanaUsers, err := cockpitAPI.ListGrafanaUsers(&cockpit.GlobalAPIListGrafanaUsersRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 				ProjectID: project.ID,
 			}, scw.WithAllPages())
 			if err != nil {
@@ -100,7 +100,7 @@ func testSweepCockpitGrafanaUser(_ string) error {
 			}
 
 			for _, grafanaUser := range listGrafanaUsers.GrafanaUsers {
-				err = cockpitAPI.DeleteGrafanaUser(&cockpit.GlobalAPIDeleteGrafanaUserRequest{
+				err = cockpitAPI.DeleteGrafanaUser(&cockpit.GlobalAPIDeleteGrafanaUserRequest{ //nolint:staticcheck // legacy Grafana user resource uses deprecated API
 					ProjectID:     project.ID,
 					GrafanaUserID: grafanaUser.ID,
 				})