feat(mongodb): add test for update tag and password

Author: jremy42

internal/services/mongodb/instance.go

@@ -64,6 +64,7 @@ func ResourceInstance() *schema.Resource {
 			"user_name": {
 				Type:        schema.TypeString,
 				Optional:    true,
+				ForceNew:    true,
 				Description: "Name of the user created when the cluster is created",
 				ConflictsWith: []string{
 					"snapshot_id",
@@ -338,32 +339,35 @@ func ResourceInstanceUpdate(ctx context.Context, d *schema.ResourceData, m inter
 		}
 	}
 
-	_, err = mongodbAPI.UpdateInstance(req, scw.WithContext(ctx))
-	if err != nil {
-		return diag.FromErr(err)
+	if req.Name != nil || req.Tags != nil {
+		_, err = mongodbAPI.UpdateInstance(req, scw.WithContext(ctx))
+		if err != nil {
+			return diag.FromErr(err)
+		}
 	}
 
 	////////////////////
 	// Update user
 	////////////////////
 
 	updateUserRequest := mongodb.UpdateUserRequest{
+		Name:       d.Get("user_name").(string),
 		Region:     region,
 		InstanceID: ID,
 	}
-	if d.HasChange("user_name") {
-		updateUserRequest.Name = d.Get("user_name").(string)
-	}
 
 	if d.HasChange("password") {
 		password := d.Get("password").(string)
 		updateUserRequest.Password = &password
 	}
 
-	_, err = mongodbAPI.UpdateUser(&updateUserRequest, scw.WithContext(ctx))
-	if err != nil {
-		return diag.FromErr(err)
+	if updateUserRequest.Password != nil {
+		_, err = mongodbAPI.UpdateUser(&updateUserRequest, scw.WithContext(ctx))
+		if err != nil {
+			return diag.FromErr(err)
+		}
 	}
+
 	_, err = waitForInstance(ctx, mongodbAPI, region, ID, d.Timeout(schema.TimeoutCreate))
 	if err != nil {
 		return diag.FromErr(err)

internal/services/mongodb/instance_test.go

@@ -93,6 +93,61 @@ func TestAccMongoDBInstance_VolumeUpdate(t *testing.T) {
 	})
 }
 
+func TestAccMongoDBInstance_UpdateNameTagsUser(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      IsInstanceDestroyed(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource scaleway_mongodb_instance main {
+						name = "test-mongodb-update-initial"
+						version = "7.0.12"
+						node_type = "MGDB-PLAY2-NANO"
+						node_number = 1
+						user_name = "user"
+						password = "initial_password"
+						tags = ["initial_tag1", "initial_tag2"]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isMongoDBInstancePresent(tt, "scaleway_mongodb_instance.main"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "name", "test-mongodb-update-initial"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "user_name", "user"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.#", "2"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.0", "initial_tag1"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.1", "initial_tag2"),
+				),
+			},
+			{
+				Config: `
+					resource scaleway_mongodb_instance main {
+						name = "test-mongodb-update-final"
+						version = "7.0.12"
+						node_type = "MGDB-PLAY2-NANO"
+						node_number = 1
+						user_name = "user"
+						password = "updated_password"
+						tags = ["updated_tag1", "updated_tag2", "updated_tag3"]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isMongoDBInstancePresent(tt, "scaleway_mongodb_instance.main"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "name", "test-mongodb-update-final"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.#", "3"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.0", "updated_tag1"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.1", "updated_tag2"),
+					resource.TestCheckResourceAttr("scaleway_mongodb_instance.main", "tags.2", "updated_tag3"),
+				),
+			},
+		},
+	})
+}
+
 func TestAccMongoDBInstance_FromSnapshot(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()