chore: enable govet fieldalignment (#3027)

Author: remyleone

.golangci.yml

@@ -105,6 +105,10 @@ linters:
     - varnamelen # checks that the length of a variable's name matches its scope [fast: false, auto-fix: false]
 
   settings:
+    govet:
+      disable-all: true
+      enable:
+        - fieldalignment
     goconst:
       min-len: 5
     gosec:

internal/datasource/search.go

@@ -60,8 +60,8 @@ func notFound(err error) bool {
 }
 
 type TooManyResultsError struct {
-	Count       int
 	LastRequest interface{}
+	Count       int
 }
 
 func (e *TooManyResultsError) Error() string {

internal/meta/meta.go

@@ -75,13 +75,13 @@ func (m Meta) ZoneSource() string {
 
 type Config struct {
 	ProviderSchema      *schema.ResourceData
+	HTTPClient          *http.Client
 	TerraformVersion    string
 	ForceZone           scw.Zone
 	ForceProjectID      string
 	ForceOrganizationID string
 	ForceAccessKey      string
 	ForceSecretKey      string
-	HTTPClient          *http.Client
 }
 
 // NewMeta creates the Meta object containing the SDK client.
@@ -247,26 +247,26 @@ func loadProfile(ctx context.Context, d *schema.ResourceData) (*scw.Profile, *Cr
 // GetCredentialsSource infers the source of the credentials based on the priority order of the different profiles
 func GetCredentialsSource(defaultZoneProfile, activeProfile, providerProfile, envProfile *scw.Profile) *CredentialsSource {
 	type SourceProfilePair struct {
-		Source  string
 		Profile *scw.Profile
+		Source  string
 	}
 
 	profilesInOrder := []SourceProfilePair{
 		{
-			CredentialsSourceDefault,
-			defaultZoneProfile,
+			Source:  CredentialsSourceDefault,
+			Profile: defaultZoneProfile,
 		},
 		{
-			CredentialsSourceActiveProfile,
-			activeProfile,
+			Source:  CredentialsSourceActiveProfile,
+			Profile: activeProfile,
 		},
 		{
-			CredentialsSourceProviderProfile,
-			providerProfile,
+			Source:  CredentialsSourceProviderProfile,
+			Profile: providerProfile,
 		},
 		{
-			CredentialsSourceEnvironment,
-			envProfile,
+			Source:  CredentialsSourceEnvironment,
+			Profile: envProfile,
 		},
 	}
 	credentialsSource := &CredentialsSource{}

internal/services/baremetal/server.go

@@ -754,24 +754,24 @@ func validateInstallConfig(ctx context.Context, d *schema.ResourceData, m interf
 	diags := diag.Diagnostics(nil)
 
 	installAttributes := []struct {
-		Attribute string
 		Field     *baremetal.OSOSField
+		Attribute string
 	}{
 		{
-			"user",
-			os.User,
+			Attribute: "user",
+			Field:     os.User,
 		},
 		{
-			"password",
-			os.Password,
+			Attribute: "password",
+			Field:     os.Password,
 		},
 		{
-			"service_user",
-			os.ServiceUser,
+			Attribute: "service_user",
+			Field:     os.ServiceUser,
 		},
 		{
-			"service_password",
-			os.ServicePassword,
+			Attribute: "service_password",
+			Field:     os.ServicePassword,
 		},
 	}
 	for _, installAttr := range installAttributes {

internal/services/domain/helpers_test.go

@@ -11,9 +11,9 @@ import (
 
 func TestExpandContact(t *testing.T) {
 	tests := []struct {
-		name        string
 		contactMap  map[string]interface{}
 		expected    *domainSDK.Contact
+		name        string
 		expectError bool
 	}{
 		{
@@ -94,9 +94,9 @@ func TestExpandContact(t *testing.T) {
 
 func TestExpandNewContact(t *testing.T) {
 	tests := []struct {
-		name        string
 		contactMap  map[string]interface{}
 		expected    *domainSDK.NewContact
+		name        string
 		expectError bool
 	}{
 		{

internal/services/instance/instancehelpers/block.go

@@ -52,9 +52,9 @@ type GetUnknownVolumeRequest struct {
 }
 
 type ResizeUnknownVolumeRequest struct {
+	Size     *scw.Size
 	VolumeID string
 	Zone     scw.Zone
-	Size     *scw.Size
 }
 
 type DeleteUnknownVolumeRequest struct {

internal/services/instance/instancehelpers/waiters_test.go

@@ -11,9 +11,9 @@ import (
 
 func TestUnknownVolume_VolumeTemplate(t *testing.T) {
 	tests := []struct {
-		name   string
 		volume *instancehelpers.UnknownVolume
 		want   *instance.VolumeServerTemplate
+		name   string
 	}{
 		{
 			name: "Root Volume",

internal/services/lb/helpers_lb_test.go

@@ -11,9 +11,9 @@ import (
 
 func TestIsEqualPrivateNetwork(t *testing.T) {
 	tests := []struct {
-		name     string
 		A        *lbSDK.PrivateNetwork
 		B        *lbSDK.PrivateNetwork
+		name     string
 		expected bool
 	}{
 		{

internal/transport/retry_aws.go

@@ -56,9 +56,9 @@ func retryWhen[T any](ctx context.Context, config *RetryWhenConfig[T], shouldRet
 }
 
 type RetryWhenConfig[T any] struct {
+	Function func() (T, error)
 	Timeout  time.Duration
 	Interval time.Duration
-	Function func() (T, error)
 }
 
 var ErrRetryWhenTimeout = errors.New("timeout reached")