fix(key_manager): add next_rotation_at in key manager resource

Author: jremy42

internal/services/keymanager/helpers.go

@@ -1,6 +1,7 @@
 package keymanager
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -85,7 +86,7 @@ func ExpandKeyRotationPolicy(v any) (*key_manager.KeyRotationPolicy, error) {
 
 	periodStr, ok := m["rotation_period"].(string)
 	if !ok || periodStr == "" {
-		return nil, nil
+		return nil, fmt.Errorf("rotation_period is required when rotation_policy block is specified")
 	}
 
 	period, err := time.ParseDuration(periodStr)
@@ -95,6 +96,7 @@ func ExpandKeyRotationPolicy(v any) (*key_manager.KeyRotationPolicy, error) {
 
 	return &key_manager.KeyRotationPolicy{
 		RotationPeriod: scw.NewDurationFromTimeDuration(period),
+		NextRotationAt: nil,
 	}, nil
 }
 

internal/services/keymanager/key_resource.go

@@ -52,7 +52,7 @@ func ResourceKeyManagerKey() *schema.Resource {
 				Description: "Key rotation policy.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						"rotation_period":  {Type: schema.TypeString, Optional: true, Description: "Time interval between two key rotations. The minimum duration is 24 hours and the maximum duration is 1 year (876000 hours)."},
+						"rotation_period":  {Type: schema.TypeString, Required: true, Description: "Time interval between two key rotations. The minimum duration is 24 hours and the maximum duration is 1 year (876000 hours)."},
 						"next_rotation_at": {Type: schema.TypeString, Computed: true, Description: "Timestamp indicating the next scheduled rotation."},
 					},
 				},

internal/services/keymanager/key_resource_test.go

@@ -123,3 +123,37 @@ func IsKeyManagerKeyDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 		return nil
 	}
 }
+
+func TestAccKeyManagerKey_WithRotationPolicy(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      IsKeyManagerKeyDestroyed(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+				resource "scaleway_key_manager_key" "main" {
+				  name         = "tf-test-kms-key-rotation"
+				  region       = "fr-par"
+				  usage        = "symmetric_encryption"
+				  description  = "Test key with rotation policy"
+				  unprotected  = true
+				  
+				  rotation_policy {
+				    rotation_period = "720h"
+				  }
+				}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("scaleway_key_manager_key.main", "name", "tf-test-kms-key-rotation"),
+					resource.TestCheckResourceAttr("scaleway_key_manager_key.main", "usage", "symmetric_encryption"),
+					resource.TestCheckResourceAttr("scaleway_key_manager_key.main", "description", "Test key with rotation policy"),
+					resource.TestCheckResourceAttr("scaleway_key_manager_key.main", "rotation_policy.0.rotation_period", "720h0m0s"),
+				),
+			},
+		},
+	})
+}

internal/services/keymanager/testdata/key-manager-key-with-rotation-policy.cassette.yaml

@@ -0,0 +1,3 @@
+---
+version: 2
+interactions: []