feat(cockpit): add update in source

Author: jremy42

internal/services/cockpit/source.go

@@ -18,6 +18,7 @@ func ResourceCockpitSource() *schema.Resource {
 	return &schema.Resource{
 		CreateContext: ResourceCockpitSourceCreate,
 		ReadContext:   ResourceCockpitSourceRead,
+		UpdateContext: ResourceCockpitSourceUpdate,
 		DeleteContext: ResourceCockpitSourceDelete,
 		Timeouts: &schema.ResourceTimeout{
 			Create:  schema.DefaultTimeout(DefaultCockpitTimeout),
@@ -46,7 +47,6 @@ func ResourceCockpitSource() *schema.Resource {
 				Type:        schema.TypeInt,
 				Optional:    true,
 				Default:     6,
-				ForceNew:    true,
 				Description: "The number of days to retain data, must be between 1 and 365.",
 			},
 			// computed
@@ -93,6 +93,9 @@ func ResourceCockpitSourceCreate(ctx context.Context, d *schema.ResourceData, me
 	}
 
 	retentionDays := uint32(d.Get("retention_days").(int))
+	if retentionDays == 0 {
+		retentionDays = 6
+	}
 
 	res, err := api.CreateDataSource(&cockpit.RegionalAPICreateDataSourceRequest{
 		Region:        region,
@@ -101,7 +104,6 @@ func ResourceCockpitSourceCreate(ctx context.Context, d *schema.ResourceData, me
 		Type:          cockpit.DataSourceType(d.Get("type").(string)),
 		RetentionDays: &retentionDays,
 	}, scw.WithContext(ctx))
-
 	if err != nil {
 		return diag.FromErr(err)
 	}
@@ -143,7 +145,38 @@ func ResourceCockpitSourceRead(ctx context.Context, d *schema.ResourceData, meta
 	_ = d.Set("updated_at", types.FlattenTime(res.UpdatedAt))
 	_ = d.Set("project_id", res.ProjectID)
 	_ = d.Set("push_url", pushURL)
-	_ = d.Set("retention_days", res.RetentionDays)
+	_ = d.Set("retention_days", int(res.RetentionDays))
+
+	return nil
+}
+
+func ResourceCockpitSourceUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	api, region, id, err := NewAPIWithRegionAndID(meta, d.Id())
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	updateRequest := &cockpit.RegionalAPIUpdateDataSourceRequest{
+		DataSourceID: id,
+		Region:       region,
+	}
+
+	if d.HasChange("name") {
+		name := d.Get("name").(string)
+		updateRequest.Name = &name
+	}
+
+	if d.HasChange("retention_days") {
+		retentionDays := uint32(d.Get("retention_days").(int))
+		updateRequest.RetentionDays = &retentionDays
+	}
+
+	if updateRequest.Name != nil || updateRequest.RetentionDays != nil {
+		_, err = api.UpdateDataSource(updateRequest, scw.WithContext(ctx))
+		if err != nil {
+			return diag.FromErr(err)
+		}
+	}
 
 	return nil
 }

internal/services/cockpit/source_test.go

@@ -133,6 +133,75 @@ func TestAccCockpitSource_retention_days(t *testing.T) {
 	})
 }
 
+func TestAccCockpitSource_Update(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      isSourceDestroyed(tt),
+		Steps: []resource.TestStep{
+			// Initial creation
+			{
+				Config: `
+					resource "scaleway_account_project" "project" {
+						name = "tf_tests_cockpit_source_update"
+					}
+
+					resource "scaleway_cockpit_source" "main" {
+						project_id = scaleway_account_project.project.id
+						name       = "initial-name"
+						type       = "logs"
+						retention_days = 10
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isSourcePresent(tt, "scaleway_cockpit_source.main"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "name", "initial-name"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "retention_days", "10"),
+				),
+			},
+			{
+				Config: `
+					resource "scaleway_account_project" "project" {
+						name = "tf_tests_cockpit_source_update"
+					}
+
+					resource "scaleway_cockpit_source" "main" {
+						project_id = scaleway_account_project.project.id
+						name       = "initial-name"
+						type       = "logs"
+						retention_days = 20
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isSourcePresent(tt, "scaleway_cockpit_source.main"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "retention_days", "20"),
+				),
+			},
+			{
+				Config: `
+					resource "scaleway_account_project" "project" {
+						name = "tf_tests_cockpit_source_update"
+					}
+
+					resource "scaleway_cockpit_source" "main" {
+						project_id = scaleway_account_project.project.id
+						name       = "updated-name"
+						type       = "logs"
+						retention_days = 20
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isSourcePresent(tt, "scaleway_cockpit_source.main"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "name", "updated-name"),
+				),
+			},
+		},
+	})
+}
+
 func isSourcePresent(tt *acctest.TestTools, n string) resource.TestCheckFunc {
 	return func(state *terraform.State) error {
 		rs, ok := state.RootModule().Resources[n]