fix(inference): use of existing function cast

Author: Laure-di

internal/services/inference/custom_model.go

@@ -145,8 +145,7 @@ func ResourceCustomModelCreate(ctx context.Context, d *schema.ResourceData, m in
 	}
 
 	if secret, ok := d.GetOk("secret"); ok {
-		secretStr := secret.(string)
-		modelSource.Secret = &secretStr
+		modelSource.Secret = types.ExpandStringPtr(secret)
 	}
 
 	reqCreateModel := &inference.CreateModelRequest{
@@ -197,9 +196,9 @@ func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m inte
 	_ = d.Set("parameter_size_bits", int32(model.ParameterSizeBits))
 	_ = d.Set("size_bytes", int64(model.SizeBytes))
 	_ = d.Set("name", model.Name)
-	_ = d.Set("status", model.Status)
+	_ = d.Set("status", model.Status.String())
 	_ = d.Set("description", model.Description)
-	_ = d.Set("tags", types.ExpandUpdatedStringsPtr(model.Tags))
+	_ = d.Set("tags", model.Tags)
 	_ = d.Set("created_at", types.FlattenTime(model.CreatedAt))
 	_ = d.Set("updated_at", types.FlattenTime(model.UpdatedAt))
 	_ = d.Set("has_eula", model.HasEula)

internal/services/inference/deployment.go

@@ -8,9 +8,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"github.com/scaleway/scaleway-sdk-go/api/inference/v1"
 	"github.com/scaleway/scaleway-sdk-go/scw"
-	scwvalidation "github.com/scaleway/scaleway-sdk-go/validation"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/dsf"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/account"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
@@ -186,17 +186,12 @@ func ResourceDeploymentCreate(ctx context.Context, d *schema.ResourceData, m int
 		return diag.FromErr(err)
 	}
 
-	modelID := d.Get("model_id")
-	if !scwvalidation.IsUUID(modelID.(string)) {
-		modelID = regional.ExpandID(modelID).ID
-	}
-
 	req := &inference.CreateDeploymentRequest{
 		Region:       region,
 		ProjectID:    d.Get("project_id").(string),
 		Name:         d.Get("name").(string),
 		NodeTypeName: d.Get("node_type").(string),
-		ModelID:      modelID.(string),
+		ModelID:      locality.ExpandID(d.Get("model_id").(string)),
 		Tags:         types.ExpandStrings(d.Get("tags")),
 		Endpoints:    buildEndpoints(d),
 	}