Apply suggestions from code review

Co-authored-by: Benedikt Rollik <[email protected]>
Co-authored-by: Guillaume Noale <[email protected]>

Author: 3 people

docs/resources/k8s_acl.md

@@ -6,7 +6,7 @@ page_title: "Scaleway: scaleway_k8s_acl"
 # Resource: scaleway_k8s_acl
 
 Creates and manages Scaleway Kubernetes Cluster authorized IPs.
-For more information, please refer to the [API documentation](https://www.scaleway.com/en/developers/api/kubernetes/#path-access-control-list-add-new-acls)
+For more information, please refer to the [API documentation](https://www.scaleway.com/en/developers/api/kubernetes/#path-access-control-list-add-new-acls).
 
 ~> **Important:** When creating a Cluster, it comes with a default ACL rule allowing all ranges `0.0.0.0/0`.
 Defining custom ACLs with Terraform will overwrite this rule, but it will be recreated automatically when deleting the ACL resource.
@@ -62,7 +62,7 @@ resource "scaleway_k8s_acl" "acl_basic" {
 
 The following arguments are supported:
 
-- `cluster_id` - (Required) UUID of the Cluster. The ID of the cluster is also the ID of the ACL resource as there can only be one per cluster.
+- `cluster_id` - (Required) UUID of the cluster. The ID of the cluster is also the ID of the ACL resource, as there can only be one per cluster.
 
 ~> **Important:** Updates to `cluster_id` will recreate the ACL.
 
@@ -82,7 +82,7 @@ The `acl_rules` block supports:
 
 ~> **Important:** If the `ip` field is set, `scaleway_ranges` cannot be set to true in the same rule.
 
-- `scaleway_ranges` - (Optional) Allow access to cluster from all Scaleway ranges as defined in https://www.scaleway.com/en/docs/console/account/reference-content/scaleway-network-information/#ip-ranges-used-by-scaleway.
+- `scaleway_ranges` - (Optional) Allow access to cluster from all Scaleway ranges as defined in [Scaleway Network Information - IP ranges used by Scaleway](https://www.scaleway.com/en/docs/console/account/reference-content/scaleway-network-information/#ip-ranges-used-by-scaleway).
 Only one rule with this field set to true can be added.
 
 ~> **Important:** If the `scaleway_ranges` field is set to true, the `ip` field cannot be set on the same rule.

internal/services/k8s/acl.go

@@ -47,7 +47,7 @@ func ResourceACL() *schema.Resource {
 				Type:         schema.TypeBool,
 				Optional:     true,
 				Default:      false,
-				Description:  "If true, no IP will be allowed",
+				Description:  "If true, no IP will be allowed and the cluster will be fully isolated",
 				ExactlyOneOf: []string{"acl_rules"},
 			},
 			"acl_rules": {
@@ -237,7 +237,7 @@ func expandACL(data []interface{}) ([]*k8s.ACLRuleRequest, error) {
 		r := rule.(map[string]interface{})
 		expandedRule := &k8s.ACLRuleRequest{}
 
-		if ipRaw, ipSet := r["ip"]; ipSet && ipRaw != "" {
+		if ipRaw, ok := r["ip"]; ok && ipRaw != "" {
 			ip, err := types.ExpandIPNet(ipRaw.(string))
 			if err != nil {
 				return nil, err
@@ -246,11 +246,11 @@ func expandACL(data []interface{}) ([]*k8s.ACLRuleRequest, error) {
 			expandedRule.IP = &ip
 		}
 
-		if scwRangesRaw, scwRangesSet := r["scaleway_ranges"]; scwRangesSet && scwRangesRaw.(bool) {
+		if scwRangesRaw, ok := r["scaleway_ranges"]; ok && scwRangesRaw.(bool) {
 			expandedRule.ScalewayRanges = scw.BoolPtr(true)
 		}
 
-		if descriptionRaw, descriptionSet := r["description"]; descriptionSet && descriptionRaw.(string) != "" {
+		if descriptionRaw, ok := r["description"]; ok && descriptionRaw.(string) != "" {
 			expandedRule.Description = descriptionRaw.(string)
 		}