last adjustments

Author: Mia-Cross

docs/resources/k8s_acl.md

@@ -68,7 +68,7 @@ The following arguments are supported:
 
 - `no_ip_allowed` - (Optional) If set to true, no IP will be allowed and the cluster will be in full-isolation.
 
-~> **Important:** This field cannot be set to true if the `acl_rules` is defined.
+~> **Important:** This field cannot be set to true if the `acl_rules` block is defined.
 
 - `acl_rules` - (Optional) A list of ACLs (structure is described below)
 

internal/services/k8s/acl.go

@@ -66,7 +66,7 @@ func ResourceACL() *schema.Resource {
 						"scaleway_ranges": {
 							Type:        schema.TypeBool,
 							Optional:    true,
-							Description: "Allow access to cluster from all Scaleway ranges as defined in https://www.scaleway.com/en/docs/console/account/reference-content/scaleway-network-information/#ip-ranges-used-by-scaleway. Only one rule with this field set to true can be added.",
+							Description: "Allow access to cluster from all Scaleway ranges",
 						},
 						"description": {
 							Type:        schema.TypeString,
@@ -169,7 +169,7 @@ func ResourceACLUpdate(ctx context.Context, d *schema.ResourceData, m interface{
 		return diag.FromErr(err)
 	}
 
-	if d.HasChange("acl_rules") || d.HasChange("no_ip_allowed") {
+	if d.HasChanges("acl_rules", "no_ip_allowed") {
 		acls, err := expandACL(d.Get("acl_rules").([]interface{}))
 		if err != nil {
 			return diag.FromErr(err)
@@ -201,21 +201,20 @@ func ResourceACLDelete(ctx context.Context, d *schema.ResourceData, m interface{
 		return diag.FromErr(err)
 	}
 
-	rulesToSet := []*k8s.ACLRuleRequest(nil)
-
 	allowedIPs, err := types.ExpandIPNet("0.0.0.0/0")
 	if err != nil {
 		return diag.FromErr(err)
 	}
-	rulesToSet = append(rulesToSet, &k8s.ACLRuleRequest{
-		IP:          &allowedIPs,
-		Description: "Automatically generated after scaleway_k8s_acl resource deletion",
-	})
 
 	req := &k8s.SetClusterACLRulesRequest{
 		Region:    region,
 		ClusterID: clusterID,
-		ACLs:      rulesToSet,
+		ACLs: []*k8s.ACLRuleRequest{
+			{
+				IP:          &allowedIPs,
+				Description: "Automatically generated after scaleway_k8s_acl resource deletion",
+			},
+		},
 	}
 
 	_, err = api.SetClusterACLRules(req, scw.WithContext(ctx))